https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43245 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43245 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43245 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203333|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43245 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When sending a reset email, |There should be a message |there should be a message |in the staff interface if a |if no email was provided |patron has no email address | |and you reset their | |password (More > Send | |password reset) Severity|enhancement |normal CC| |david@davidnind.com Text to go in the| |This fixes resetting a release notes| |password for a patron in | |the staff interface ("More | |> Send password reset" | |option when | |OpacResetPassword is set to | |"allowed"). | | | |If a patron has no an email | |message, no message was | |sent. There was no | |indication about this and | |the reason why, so you | |would assume that a | |password reset notice was | |sent (apart from | |redirecting to the patron | |notices section, where you | |may have noticed that there | |isn't a password reset | |notice queued). | | | |Now, if the patron does not | |have an email address, a | |message is shown: | | | | Unable to send | |password reset | | | | The patron has no | |email address --- Comment #3 from David Nind <david@davidnind.com> --- A suggestion and question: 1. A suggestion to change the message in the staff interface - we don't input an email address when we click on "Send password reset", so: - Instead of the current message: Unable to send recovery email No email address provided - Change the message to: Unable to send password reset The patron has no email address 2. Do we need a bug to rename the OpacResetPassword system preference name and update the description? - It is a bit odd (to me) that the name and description are about the OPAC, but the "More > Send password reset" option in the staff interface for a patron only shows when this system preference is set to "allowed". - I am happy to create a bug for this if this is valid. I've changed the importance from "Enhancement" to "Normal", because if a patron doesn't have an email message it silently fails with no message, and no notice generated - library staff would think they had done their job, but nothing has happened. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43245 --- Comment #7 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43245 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43316 --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to Andrew Fuerste-Henry from comment #4)

(In reply to David Nind from comment #3)

...

2. Do we need a bug to rename the OpacResetPassword system preference name and update the description? - It is a bit odd (to me) that the name and description are about the OPAC, but the "More > Send password reset" option in the staff interface for a patron only shows when this system preference is set to "allowed". - I am happy to create a bug for this if this is valid.

Agreed we should change this. I think I'd prefer splitting the staff password reset feature off into a distinct syspref, but rewording this one for accuracy is a good start.

Created two bugs: 1. Bug 43315 - OpacResetPassword system preference - update description 2. Bug 43316 - OpacResetPassword - rename or split into two system preferences -- You are receiving this mail because: You are watching all bug changes.