[Bug 35265] New: Remove drag and drop in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Bug ID: 35265 Summary: Remove drag and drop in Elasticsearch mappings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com Bug 18827 says ordering search fields in Elasticsearch mappings is useless. We can remove it. This may help to convert into a real DataTable Bug 20588 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18827 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20588 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 158493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158493&action=edit Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- After that we may remove lib/jquery/plugins/jquery.tablednd.js looks like it is only used there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I'm working on Bug 35249 which removes the tablednd plugin in favor of the DataTables "official" extension. It is still needed for "Facet order" table found at the bottom of the Bibliographic records tab. Unless I'm wrong in thinking that table uses the row-reordering functionality? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158493|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 158582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158582&action=edit Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This removes the ability to release notes| |drag and drop the order of | |the bibliographic and | |authorities search fields | |(Administration > Catalog > | |Search engine configuration | |(Elasticsearch)). This was | |removed as it feature has | |no effect on the search | |results when using | |Elasticsearch or OpenSearch | |as the search engine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Should there be any cleanup serverside for this? The patch removes the ability to drag and drop sort in the UI, but I'm struggling to see where/how that was stored serverside.. we should clean that side up too if it's really not useful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Can someone please verify whether table row reordering is still needed for the "Facet order" table? If so the plugin should not be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. looking through the code I'm fairly certain now that the sort ordering was never really stored anywhere.. we just displayed in name alpha order always. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I grabbed Nick.. he thinks the Facet Order does still matter. So we can move this bug forward as is.. but we'll want to tackle any change to the facet side in another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Martin Renvoize from comment #8)
I grabbed Nick.. he thinks the Facet Order does still matter.
So we can move this bug forward as is.. but we'll want to tackle any change to the facet side in another bug.
In other words.. bug 35249 is still valid I'm afraid Owen :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158582|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159083&action=edit Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Martin Renvoize from comment #9)
In other words.. bug 35249 is still valid I'm afraid Owen :)
That's fine... I was trying to wait for Bug 34913 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- String changes, deferring -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #8)
I grabbed Nick.. he thinks the Facet Order does still matter.
So we can move this bug forward as is.. but we'll want to tackle any change to the facet side in another bug.
Just double-checking: before this patch, we can re-order the facets and the changed order also was stored for me. This patch breaks this behaviour. Please confirm if this is indeed intended. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- You're right.. I must have switched branches mid-QA session as I know I tested it.. but it's really clearly removed here. Back to you Fridolin I'm afraid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159083|0 |1 is obsolete| | --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 159781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159781&action=edit Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Drag and drop is kept for facets. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Martin Renvoize from comment #14)
You're right.. I must have switched branches mid-QA session as I know I tested it.. but it's really clearly removed here.
Back to you Fridolin I'm afraid.
Indeed :) I've restored DND for facets. Please re-test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Barbara Petritsch <barbara.petritsch@wienmuseum.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.petritsch@wienmuseu | |m.at -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159781|0 |1 is obsolete| | --- Comment #17 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159835&action=edit Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Drag and drop is kept for facets. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Barbara Petritsch <barbara.petritsch@wienmuseum.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159835|0 |1 is obsolete| | --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 160605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160605&action=edit Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Drag and drop is kept for facets. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Barbara Petritsch <barbara.petritsch@wienmuseum.at> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works (facets still ok, adding, removing, editing biblio and auth record mappings too), makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This removes the ability to |This removes the ability to release notes|drag and drop the order of |drag and drop the order of |the bibliographic and |the bibliographic and |authorities search fields |authorities search fields |(Administration > Catalog > |(Administration > Catalog > |Search engine configuration |Search engine configuration |(Elasticsearch)). This was |(Elasticsearch)). This was |removed as it feature has |removed as the feature has |no effect on the search |no effect on the search |results when using |results when using |Elasticsearch or OpenSearch |Elasticsearch or OpenSearch |as the search engine. |as the search engine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org