[Bug 17268] New: Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Bug ID: 17268 Summary: Advanced cataloging editor - rancor - macros are lost when browser storage cleared Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In development macros were stored in the browser to allow different users to have their own. Unfortunately this means macros are lost when browser storage is cleared. Should have a more robust method for retaining these. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 J Schmidt <jschmidt@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #1 from J Schmidt <jschmidt@switchinc.org> --- Additionally, if possible, set up for Koha advanced editor macros should have a built-in shortcut tied to a function key (F1, F2) so that staff may input up to 9 different macros per login. Currently, staff need to mouse click to the field, then mouse click to the macro, then select the macro. The above would make things more efficient. (If you see how CTRL-D is used for inputting a delimiter, it would be like that). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 barbara.johnson@bedfordtx.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #2 from barbara.johnson@bedfordtx.gov --- I second the need for macros to be tied to function keys since it would greatly improve cataloging efficiency. In order to increase the number of options to 36 I would add combinations such as CTRL+F1, ALT+F1 and SHIFT+F1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #3 from J Schmidt <jschmidt@switchinc.org> --- It sounds as though for Firefox, if you used Options to log into a Firefox account you may be able to sync and preserve cookies from macros from one version of that browser to the next. I'll have to try it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #4 from Heather <heather_hernandez@nps.gov> --- (In reply to J Schmidt from comment #3)
It sounds as though for Firefox, if you used Options to log into a Firefox account you may be able to sync and preserve cookies from macros from one version of that browser to the next. I'll have to try it.
This has been working for me, but I find it's not ideal, since I'd prefer not storing cookies (for more privacy). I really like the idea of tying macros to function keys--I'd love it even more if I could choose which key combinations to assign to which macros. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #5 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I agree with being able to customize the key combinations for assigning macros. What works for me and provides me with an efficient workflow might not work for someone else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Ron Houk <rhouk@ottumwapubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rhouk@ottumwapubliclibrary. | |org --- Comment #6 from Ron Houk <rhouk@ottumwapubliclibrary.org> --- I would also like to see macros store in a more robust way. Or at least have the option to export/import our macros. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 kraborn@nrhtx.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kraborn@nrhtx.com --- Comment #7 from kraborn@nrhtx.com --- I agree with the previous comments; it would be wonderful for macros to be structured in such a way that they are not wiped out when a browser cache is cleared. The option of tying the macros to various function keys would be a fabulous enhancement and make the macros an even more powerful tool. The functionality of exporting and importing macros would also be very helpful for training new catalogers and supporting consistency across a team. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93474&action=edit Bug 17268: Add macros table and permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Working on moving the macros into the DB I think we should add a REST route for CRUD and new permissions for public macros Please file a new bug for mapping macros to hotkeys :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #10 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 95948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95948&action=edit Bug 17268: Advanced cataloging editor - rancor - macros are lost when browser storage cleared First pass at api code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93474|0 |1 is obsolete| | Attachment #95948|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96616&action=edit Bug 17268: Add macros table and permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96617&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96618&action=edit Bug 17268: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96616|0 |1 is obsolete| | Attachment #96617|0 |1 is obsolete| | Attachment #96618|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96757&action=edit Bug 17268: Add macros table and permissions Bug 17268: Change public to shared -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96758&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96759&action=edit Bug 17268: Make shared macros use their own path Bug 17268: Update API to use shared instead of public -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96760&action=edit Bug 17268: DO NOT PUSH: Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not ready for testing yet? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 [Bug 24789] Remove 'ITS' macro format -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96757|0 |1 is obsolete| | Attachment #96758|0 |1 is obsolete| | Attachment #96759|0 |1 is obsolete| | Attachment #96760|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100559&action=edit Bug 17268: Add macros table and permissions Bug 17268: Change public to shared -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100560&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100561&action=edit Bug 17268: Make shared macros use their own path Bug 17268: Update API to use shared instead of public -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100562&action=edit Bug 17268: Use API to store/retrieve values To test: 1 - Enable AdvancedCatalogingEditor 2 - Add some macros (they don't need to be valid, just have content) 3 - Apply patches 4 - updatedatabase 5 - Set user to have 'create_shared_macros' and 'delete_shared_macros' 6 - Load the advanced editor (Cataloging->Advanced editor) 7 - Click on 'Macros' 8 - Previous macros should not show, but you should have a 'Convert' button 9 - Convert old macros and confirm they show 10 - Edit the macros, changing content and the public checkbox, confirm 'Saved' shows in the top right of editor when updating 11 - Have at least on valid macro and run it, e.g.: new 100=Testing this out 12 - Run the macro, confirm it runs 13 - Try a macro with gibberish, confirm there is an error when running 14 - Ensure you have a few macros marked public 15 - In a private browser window sign in as a patron with neither shared macro permission 16 - Confirm the public macros load, but cannot be edited 17 - Grant create_shared_macros permission to this patron 18 - Reload editor, they should now be able to edit shared macros 19 - Confirm they cannot delete shared macros 20 - Grant delete_shared_macros permission 21 - Reload editor 22 - Confirm they can now delete shared macros -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100563&action=edit Bug 17268: (follow-up) Fix licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100564&action=edit Bug 17268: DO NOT PUSH: Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100565&action=edit Bug 17268: Set Booleaa for shared column in schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100559|0 |1 is obsolete| | Attachment #100560|0 |1 is obsolete| | Attachment #100561|0 |1 is obsolete| | Attachment #100562|0 |1 is obsolete| | Attachment #100563|0 |1 is obsolete| | Attachment #100564|0 |1 is obsolete| | Attachment #100565|0 |1 is obsolete| | --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100569&action=edit Bug 17268: Add macros table and permissions Bug 17268: Change public to shared -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100570&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100571&action=edit Bug 17268: Make shared macros use their own path Bug 17268: Update API to use shared instead of public -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100572&action=edit Bug 17268: Use API to store/retrieve values To test: 1 - Enable AdvancedCatalogingEditor 2 - Add some macros (they don't need to be valid, just have content) 3 - Apply patches 4 - updatedatabase 5 - Set user to have 'create_shared_macros' and 'delete_shared_macros' 6 - Load the advanced editor (Cataloging->Advanced editor) 7 - Click on 'Macros' 8 - Previous macros should not show, but you should have a 'Convert' button 9 - Convert old macros and confirm they show 10 - Edit the macros, changing content and the public checkbox, confirm 'Saved' shows in the top right of editor when updating 11 - Have at least on valid macro and run it, e.g.: new 100=Testing this out 12 - Run the macro, confirm it runs 13 - Try a macro with gibberish, confirm there is an error when running 14 - Ensure you have a few macros marked public 15 - In a private browser window sign in as a patron with neither shared macro permission 16 - Confirm the public macros load, but cannot be edited 17 - Grant create_shared_macros permission to this patron 18 - Reload editor, they should now be able to edit shared macros 19 - Confirm they cannot delete shared macros 20 - Grant delete_shared_macros permission 21 - Reload editor 22 - Confirm they can now delete shared macros -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100573&action=edit Bug 17268: (follow-up) Fix licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100574&action=edit Bug 17268: DO NOT PUSH: Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100575&action=edit Bug 17268: Set Booleaa for shared column in schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm failing out around step 7. I've applied patches and updated database. When I go to adv editor as either a superlibrarian or a user with all cataloging permissions, when I click Macros I don't see a Convert button. Also, when I click New Macro, give it a name, and click OK I get this error: Failed to create macro:{"errors":[{"message":"anyOf failed: Expected string or null, got boolean.","path":"\/shared"}],"status":500} Jumping over to the database, I see the macro name in advanced_editor_macros, but it doesn't list on the macros page. If leave adv editor, come back in, click Macros again I get the error: Failed to load macros:{"errors":[{"message":"anyOf failed: Expected string or null, got boolean.","path":"\/0\/shared"}],"status":500} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100584&action=edit Bug 17268: (follow-up) wqUpdate API field definition to boolean -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #35 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Am now getting a slightly different error in the same place: Failed to create macro:{"errors":[{"message":"anyOf failed: Expected boolean or null, got number.","path":"\/body\/shared"}],"status":400} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 100604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100604&action=edit Bug 17268: Handle booleans in JS as such Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #36)
Created attachment 100604 [details] [review] Bug 17268: Handle booleans in JS as such
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Andrew, I submitted a follow-up so you can properly test the feature. Nick, squash it if you feel like :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #38 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Macros I had in my cache before applying patches are not visible after patch, so I cannot convert them. Failing QA for this. I also got a weird error that I cannot seem to recreate: - create user with only "catalogue" and "editcatalogue" permissions - open incognito window, log in as your user - create a new macro, mark it public - click away from your new macro - click back to your new macro to edit it, get this error: "Failed to load macros:{"error":"This macro is shared, you must access it via advancededitormacros\/shared"}" But it lets you edit the macro anyway? And it still shows and works for other users? And then once I'd logged out and back in again, the error stopped. As I said, I haven't been able to make it happen again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100569|0 |1 is obsolete| | Attachment #100570|0 |1 is obsolete| | Attachment #100571|0 |1 is obsolete| | Attachment #100572|0 |1 is obsolete| | Attachment #100573|0 |1 is obsolete| | Attachment #100574|0 |1 is obsolete| | Attachment #100575|0 |1 is obsolete| | Attachment #100584|0 |1 is obsolete| | Attachment #100604|0 |1 is obsolete| | --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100758&action=edit Bug 17268: Add macros table and permissions Bug 17268: Change public to shared -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100759&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint Bug 17268: Make shared macros use their own path Bug 17268: Update API to use shared instead of public Bug 17268: (follow-up) Update API field definition to boolean -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100760&action=edit Bug 17268: Use API to store/retrieve values To test: 1 - Enable AdvancedCatalogingEditor 2 - Add some macros (they don't need to be valid, just have content) 3 - Apply patches 4 - updatedatabase 5 - Set user to have 'create_shared_macros' and 'delete_shared_macros' 6 - Load the advanced editor (Cataloging->Advanced editor) 7 - Click on 'Macros' 8 - Previous macros should not show, but you should have a 'Convert' button 9 - Convert old macros and confirm they show 10 - Edit the macros, changing content and the public checkbox, confirm 'Saved' shows in the top right of editor when updating 11 - Have at least on valid macro and run it, e.g.: new 100=Testing this out 12 - Run the macro, confirm it runs 13 - Try a macro with gibberish, confirm there is an error when running 14 - Ensure you have a few macros marked public 15 - In a private browser window sign in as a patron with neither shared macro permission 16 - Confirm the public macros load, but cannot be edited 17 - Grant create_shared_macros permission to this patron 18 - Reload editor, they should now be able to edit shared macros 19 - Confirm they cannot delete shared macros 20 - Grant delete_shared_macros permission 21 - Reload editor 22 - Confirm they can now delete shared macros -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100761&action=edit Bug 17268: (follow-up) Fix licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100762&action=edit Bug 17268: DO NOT PUSH: Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100763&action=edit Bug 17268: Set boolean for shared column in schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100758|0 |1 is obsolete| | Attachment #100759|0 |1 is obsolete| | Attachment #100760|0 |1 is obsolete| | Attachment #100761|0 |1 is obsolete| | Attachment #100762|0 |1 is obsolete| | Attachment #100763|0 |1 is obsolete| | --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100766&action=edit Bug 17268: Add macros table and permissions Bug 17268: Change public to shared -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #46 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100767&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint Bug 17268: Make shared macros use their own path Bug 17268: Update API to use shared instead of public Bug 17268: (follow-up) Update API field definition to boolean -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100768&action=edit Bug 17268: Use API to store/retrieve values To test: 1 - Enable AdvancedCatalogingEditor 2 - Add some macros (they don't need to be valid, just have content) 3 - Apply patches 4 - updatedatabase 5 - Set user to have 'create_shared_macros' and 'delete_shared_macros' 6 - Load the advanced editor (Cataloging->Advanced editor) 7 - Click on 'Macros' 8 - Previous macros should not show, but you should have a 'Convert' button 9 - Convert old macros and confirm they show 10 - Edit the macros, changing content and the public checkbox, confirm 'Saved' shows in the top right of editor when updating 11 - Have at least on valid macro and run it, e.g.: new 100=Testing this out 12 - Run the macro, confirm it runs 13 - Try a macro with gibberish, confirm there is an error when running 14 - Ensure you have a few macros marked public 15 - In a private browser window sign in as a patron with neither shared macro permission 16 - Confirm the public macros load, but cannot be edited 17 - Grant create_shared_macros permission to this patron 18 - Reload editor, they should now be able to edit shared macros 19 - Confirm they cannot delete shared macros 20 - Grant delete_shared_macros permission 21 - Reload editor 22 - Confirm they can now delete shared macros -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #48 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100769&action=edit Bug 17268: (follow-up) Fix licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100770&action=edit Bug 17268: DO NOT PUSH: Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100771&action=edit Bug 17268: Set boolean for shared column in schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100766|0 |1 is obsolete| | Attachment #100767|0 |1 is obsolete| | Attachment #100768|0 |1 is obsolete| | Attachment #100769|0 |1 is obsolete| | Attachment #100770|0 |1 is obsolete| | Attachment #100771|0 |1 is obsolete| | --- Comment #51 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100772&action=edit Bug 17268: Add macros table and permissions Bug 17268: Change public to shared -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #52 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100773&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint Bug 17268: Make shared macros use their own path Bug 17268: Update API to use shared instead of public Bug 17268: (follow-up) Update API field definition to boolean -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100774&action=edit Bug 17268: Use API to store/retrieve values To test: 1 - Enable AdvancedCatalogingEditor 2 - Add some macros (they don't need to be valid, just have content) 3 - Apply patches 4 - updatedatabase 5 - Set user to have 'create_shared_macros' and 'delete_shared_macros' 6 - Load the advanced editor (Cataloging->Advanced editor) 7 - Click on 'Macros' 8 - Previous macros should not show, but you should have a 'Convert' button 9 - Convert old macros and confirm they show 10 - Edit the macros, changing content and the public checkbox, confirm 'Saved' shows in the top right of editor when updating 11 - Have at least on valid macro and run it, e.g.: new 100=Testing this out 12 - Run the macro, confirm it runs 13 - Try a macro with gibberish, confirm there is an error when running 14 - Ensure you have a few macros marked public 15 - In a private browser window sign in as a patron with neither shared macro permission 16 - Confirm the public macros load, but cannot be edited 17 - Grant create_shared_macros permission to this patron 18 - Reload editor, they should now be able to edit shared macros 19 - Confirm they cannot delete shared macros 20 - Grant delete_shared_macros permission 21 - Reload editor 22 - Confirm they can now delete shared macros -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #54 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100775&action=edit Bug 17268: (follow-up) Fix licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100776&action=edit Bug 17268: DO NOT PUSH: Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100777&action=edit Bug 17268: Set boolean for shared column in schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100772|0 |1 is obsolete| | --- Comment #57 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100780&action=edit Bug 17268: Add macros table and permissions Bug 17268: Change public to shared Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100773|0 |1 is obsolete| | --- Comment #58 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100781&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint Bug 17268: Make shared macros use their own path Bug 17268: Update API to use shared instead of public Bug 17268: (follow-up) Update API field definition to boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100774|0 |1 is obsolete| | --- Comment #59 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100782&action=edit Bug 17268: Use API to store/retrieve values To test: 1 - Enable AdvancedCatalogingEditor 2 - Add some macros (they don't need to be valid, just have content) 3 - Apply patches 4 - updatedatabase 5 - Set user to have 'create_shared_macros' and 'delete_shared_macros' 6 - Load the advanced editor (Cataloging->Advanced editor) 7 - Click on 'Macros' 8 - Previous macros should not show, but you should have a 'Convert' button 9 - Convert old macros and confirm they show 10 - Edit the macros, changing content and the public checkbox, confirm 'Saved' shows in the top right of editor when updating 11 - Have at least on valid macro and run it, e.g.: new 100=Testing this out 12 - Run the macro, confirm it runs 13 - Try a macro with gibberish, confirm there is an error when running 14 - Ensure you have a few macros marked public 15 - In a private browser window sign in as a patron with neither shared macro permission 16 - Confirm the public macros load, but cannot be edited 17 - Grant create_shared_macros permission to this patron 18 - Reload editor, they should now be able to edit shared macros 19 - Confirm they cannot delete shared macros 20 - Grant delete_shared_macros permission 21 - Reload editor 22 - Confirm they can now delete shared macros Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100775|0 |1 is obsolete| | --- Comment #60 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100783&action=edit Bug 17268: (follow-up) Fix licenses Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100776|0 |1 is obsolete| | --- Comment #61 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100784&action=edit Bug 17268: DO NOT PUSH: Schema update Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100777|0 |1 is obsolete| | --- Comment #62 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100785&action=edit Bug 17268: Set boolean for shared column in schema Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100780|0 |1 is obsolete| | --- Comment #63 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100983&action=edit Bug 17268: Add macros table and permissions Bug 17268: Change public to shared Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100781|0 |1 is obsolete| | --- Comment #64 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100984&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint Bug 17268: Make shared macros use their own path Bug 17268: Update API to use shared instead of public Bug 17268: (follow-up) Update API field definition to boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100782|0 |1 is obsolete| | --- Comment #65 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100985&action=edit Bug 17268: Use API to store/retrieve values To test: 1 - Enable AdvancedCatalogingEditor 2 - Add some macros (they don't need to be valid, just have content) 3 - Apply patches 4 - updatedatabase 5 - Set user to have 'create_shared_macros' and 'delete_shared_macros' 6 - Load the advanced editor (Cataloging->Advanced editor) 7 - Click on 'Macros' 8 - Previous macros should not show, but you should have a 'Convert' button 9 - Convert old macros and confirm they show 10 - Edit the macros, changing content and the public checkbox, confirm 'Saved' shows in the top right of editor when updating 11 - Have at least on valid macro and run it, e.g.: new 100=Testing this out 12 - Run the macro, confirm it runs 13 - Try a macro with gibberish, confirm there is an error when running 14 - Ensure you have a few macros marked public 15 - In a private browser window sign in as a patron with neither shared macro permission 16 - Confirm the public macros load, but cannot be edited 17 - Grant create_shared_macros permission to this patron 18 - Reload editor, they should now be able to edit shared macros 19 - Confirm they cannot delete shared macros 20 - Grant delete_shared_macros permission 21 - Reload editor 22 - Confirm they can now delete shared macros Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100783|0 |1 is obsolete| | --- Comment #66 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100986&action=edit Bug 17268: (follow-up) Fix licenses Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100784|0 |1 is obsolete| | --- Comment #67 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100987&action=edit Bug 17268: DO NOT PUSH: Schema update Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100785|0 |1 is obsolete| | --- Comment #68 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100988&action=edit Bug 17268: Set boolean for shared column in schema Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #69 from Heather <heather_hernandez@nps.gov> --- I'm so happy to have had a chance to help this along--this would save me SO MUCH time in cataloging and would allow me to create macros for others cataloging at my institution to use so would not only save them time but would enhance the quality and accuracy of our cataloging records immensely. Anything that anyone can do to help this along would be most appreciated!! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, do we have precedents for adding stuffs REST API side only? Here you are adding permission checks in Koha/REST/V1, not in the regular Koha object class. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- On another note I think the error messages are not translatable (but I did not test, that may be wrong). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Having a look here too. Database update and permissions look good. Seems to work well, although I have some concerns about macros working correctly in our current version (see 5) Found only some small stuff that needs fixing: 1) QA test tool fail FAIL Koha/AdvancedEditorMacros.pm FAIL pod coverage POD is missing for 'object_class' OK spelling 2) Translatability Jonathan, I think you are right, if these show in the GUI (which it looks like) they won't be translatable. openapi => { error => "To create shared macros you must use advancededitor/shared" } ); openapi => { error => "To create private macros you must use advancededitor" } ); There are also some other glitches in the Javascript code: + $convert = $( '<button class="btn btn-default" id="convert-macros" title="Convert browser storage macros"><i class="fa fa-adjust"></i> Convert old macros</button>' ); 3) Should these API additions be voted on? 4) Capitalization I've noticed lots of glitches there in patches recently - makes my inner librarian unhappy: + "description": "Advanced Editor Macro internal identifier", 5) Testing went well, but I am wondering if there is an issue with our MACRO language. A lot of the examples I tried from the wiki would not work: https://wiki.koha-community.org/wiki/Advanced_editor_macros Especially the RDA macros that add multiple subfields - only the first subfield code will be recognized. I assume they used to work (trusting Heather), so what happened there? As this is so heavy on API it would be nice to get Tomas to have a look too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #73 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm sad to say, those RDA macros work in master without these patches. Just tested this one on master and it made all three new fields: new 336=‡atext ǂb txt ǂ2 rdacontent new 337=‡aunmediated ǂb n ǂ2 rdamedia new 338=‡avolume ǂb nc ǂ2 rdacarrier If it's only making one of the three with these patches then that ain't good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io, | |martin.renvoize@ptfs-europe | |.com --- Comment #74 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The fact it relies on the API should be a good thing for everyone, no one wants to add new CGI controller scripts that can only be tested with selenium :-D About translatability, the JS libraries usually just detect faulty codes (4XX, 5XX, and so on). And the error message is not what gets presented to the end user. That should be handled as usual in JS with translatability in mind. For example, if we do GET /a/resource/12 and get a 404, it doesn't matter the JSON that is returned (even though we try to be consistent on the format and texts there). The code on the UI should handle the fact that the requested resource doesn't exist, based on the 404 code. That said, maybe Nick relied on those messages for the UI, and that should be fixed. I haven't checked that myself. Regarding the need for a vote, I'd say we should, yes. This patchset requires something different than others: the resources (macros) can belong to a patron, but can also be shared. And we can only specify AND conditions for resource access. So we cannot say (on the spec) things like: 'you can edit this if you are superlibrarian or the owner'. It could be worked out in a different way, but I don't think we can avoid (at least) a minimum check in the controller, and is just fine IMHO. I will recheck this patchset in deep and provide more feedback ASAP. Specially if some design change can make this cleaner to implement. I haven't found a better option, thus adding Martin and Agustin to the conversation to gather more ideas. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #73)
I'm sad to say, those RDA macros work in master without these patches. Just tested this one on master and it made all three new fields: new 336=‡atext ǂb txt ǂ2 rdacontent new 337=‡aunmediated ǂb n ǂ2 rdamedia new 338=‡avolume ǂb nc ǂ2 rdacarrier
If it's only making one of the three with these patches then that ain't good.
Do the subfield codes show up the right 'color' for you? I have the text added by the macro, but only the first is a real 'subfield' delimeter somehow. When I save and look at the record, they show in the record as ǂb and ǂ2 in normal view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #76 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #74)
The fact it relies on the API should be a good thing for everyone, no one wants to add new CGI controller scripts that can only be tested with selenium :-D
The problem is having all the logic in Koha::REST, how do you do if you want to reuse this code outside of a REST API call? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #77 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 101980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101980&action=edit Bug 17268: (follow-up) Fix translatability This patch moves the error messages to translatable strings Also includes capitalization fixes and POD adjustment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #78 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #72)
1) QA test tool fail
Fixed - new POD complaint is false positive
2) Translatability
Fixed
There are also some other glitches in the Javascript code:
Fixed
3) Should these API additions be voted on?
https://wiki.koha-community.org/wiki/Advanced_editor_macros_endpoint_RFC
4) Capitalization
Fixed
5) Testing went well, but I am wondering if there is an issue with our MACRO language. A lot of the examples I tried from the wiki would not work:
Several of the wiki examples had bad characters ǂ != ‡ - fixing those made the macros work for me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #79 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #76)
(In reply to Tomás Cohen Arazi from comment #74)
The fact it relies on the API should be a good thing for everyone, no one wants to add new CGI controller scripts that can only be tested with selenium :-D
The problem is having all the logic in Koha::REST, how do you do if you want to reuse this code outside of a REST API call?
The logic in the API is mostly permission based, and pretty light in my opinion. Why are you interacting with this code outside of the API, and what are you trying to do? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #80 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #76)
(In reply to Tomás Cohen Arazi from comment #74)
The fact it relies on the API should be a good thing for everyone, no one wants to add new CGI controller scripts that can only be tested with selenium :-D
The problem is having all the logic in Koha::REST, how do you do if you want to reuse this code outside of a REST API call?
Well, we try not to do that. In this case there's really no business logic besides permission checking, which we traditionally do in the controllers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Several of the wiki examples had bad characters ǂ != ‡ - fixing those made the macros work for me
That's a relief! Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Leaving this for the moment in Tomas' and Nick's hands to resolve and hope to see things move soon! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #83 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Tomás Cohen Arazi from comment #80)
(In reply to Jonathan Druart from comment #76)
(In reply to Tomás Cohen Arazi from comment #74)
The fact it relies on the API should be a good thing for everyone, no one wants to add new CGI controller scripts that can only be tested with selenium :-D
The problem is having all the logic in Koha::REST, how do you do if you want to reuse this code outside of a REST API call?
Well, we try not to do that. In this case there's really no business logic besides permission checking, which we traditionally do in the controllers.
First of all, really great work Nick! * About the endpoint path, if we are talking about patron's macros, I believe it would make more sense to have something like GET /api/v1/patrons/{patron_id}/advancededitormacros GET /api/v1/patrons/{patron_id}/advancededitormacros/{advancededitormacro_id} etc... Meaning patron_id should be in the path * An idea for having OR conditions for resources access is to have it specified in x-koha-authorization, for example "x-koha-authorization": { "permissions": { "editcatalogue": "advanced_editor" }, "or-condition": { "shared": 1 } } and have object.search build that dbic query whit the patron_id it founds in the path.. permissions will always be checked before this in Auth.pm. Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #84 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we just voted on a little change with the RFC - not sure if more work is need, Nick, can you comment please? https://wiki.koha-community.org/wiki/Advanced_editor_macros_endpoint_RFC Note: Seems to be missng from the summary page (https://wiki.koha-community.org/wiki/REST_api_RFCs) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100983|0 |1 is obsolete| | Attachment #100984|0 |1 is obsolete| | Attachment #100985|0 |1 is obsolete| | Attachment #100986|0 |1 is obsolete| | Attachment #100987|0 |1 is obsolete| | Attachment #100988|0 |1 is obsolete| | Attachment #101980|0 |1 is obsolete| | --- Comment #85 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103507&action=edit Bug 17268: Add macros table and permissions Bug 17268: Change public to shared Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #86 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103508&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint Bug 17268: Make shared macros use their own path Bug 17268: Update API to use shared instead of public Bug 17268: (follow-up) Update API field definition to boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #87 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103509&action=edit Bug 17268: Use API to store/retrieve values To test: 1 - Enable AdvancedCatalogingEditor 2 - Add some macros (they don't need to be valid, just have content) 3 - Apply patches 4 - updatedatabase 5 - Set user to have 'create_shared_macros' and 'delete_shared_macros' 6 - Load the advanced editor (Cataloging->Advanced editor) 7 - Click on 'Macros' 8 - Previous macros should not show, but you should have a 'Convert' button 9 - Convert old macros and confirm they show 10 - Edit the macros, changing content and the public checkbox, confirm 'Saved' shows in the top right of editor when updating 11 - Have at least on valid macro and run it, e.g.: new 100=Testing this out 12 - Run the macro, confirm it runs 13 - Try a macro with gibberish, confirm there is an error when running 14 - Ensure you have a few macros marked public 15 - In a private browser window sign in as a patron with neither shared macro permission 16 - Confirm the public macros load, but cannot be edited 17 - Grant create_shared_macros permission to this patron 18 - Reload editor, they should now be able to edit shared macros 19 - Confirm they cannot delete shared macros 20 - Grant delete_shared_macros permission 21 - Reload editor 22 - Confirm they can now delete shared macros Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #88 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103510&action=edit Bug 17268: (follow-up) Fix licenses Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #89 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103511&action=edit Bug 17268: DO NOT PUSH: Schema update Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #90 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103512&action=edit Bug 17268: Set boolean for shared column in schema Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #91 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103513&action=edit Bug 17268: (follow-up) Fix translatability This patch moves the error messages to translatable strings Also includes capitalization fixes and POD adjustment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #92 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103514&action=edit Bug 17268: Update patchs per RFC https://wiki.koha-community.org/wiki/Advanced_editor_macros_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103507|0 |1 is obsolete| | --- Comment #93 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104144&action=edit Bug 17268: Add macros table and permissions Bug 17268: Change public to shared Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103508|0 |1 is obsolete| | --- Comment #94 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104145&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint Bug 17268: Make shared macros use their own path Bug 17268: Update API to use shared instead of public Bug 17268: (follow-up) Update API field definition to boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103509|0 |1 is obsolete| | --- Comment #95 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104146&action=edit Bug 17268: Use API to store/retrieve values To test: 1 - Enable AdvancedCatalogingEditor 2 - Add some macros (they don't need to be valid, just have content) 3 - Apply patches 4 - updatedatabase 5 - Set user to have 'create_shared_macros' and 'delete_shared_macros' 6 - Load the advanced editor (Cataloging->Advanced editor) 7 - Click on 'Macros' 8 - Previous macros should not show, but you should have a 'Convert' button 9 - Convert old macros and confirm they show 10 - Edit the macros, changing content and the public checkbox, confirm 'Saved' shows in the top right of editor when updating 11 - Have at least on valid macro and run it, e.g.: new 100=Testing this out 12 - Run the macro, confirm it runs 13 - Try a macro with gibberish, confirm there is an error when running 14 - Ensure you have a few macros marked public 15 - In a private browser window sign in as a patron with neither shared macro permission 16 - Confirm the public macros load, but cannot be edited 17 - Grant create_shared_macros permission to this patron 18 - Reload editor, they should now be able to edit shared macros 19 - Confirm they cannot delete shared macros 20 - Grant delete_shared_macros permission 21 - Reload editor 22 - Confirm they can now delete shared macros Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103510|0 |1 is obsolete| | --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104147&action=edit Bug 17268: (follow-up) Fix licenses Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103511|0 |1 is obsolete| | --- Comment #97 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104148&action=edit Bug 17268: DO NOT PUSH: Schema update Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103512|0 |1 is obsolete| | --- Comment #98 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104149&action=edit Bug 17268: Set boolean for shared column in schema Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Heather Hernandez <Heather_Hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103513|0 |1 is obsolete| | --- Comment #99 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104150&action=edit Bug 17268: (follow-up) Fix translatability This patch moves the error messages to translatable strings Also includes capitalization fixes and POD adjustment Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103514|0 |1 is obsolete| | --- Comment #100 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104151&action=edit Bug 17268: Update patchs per RFC https://wiki.koha-community.org/wiki/Advanced_editor_macros_endpoint_RFC Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #101 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104152&action=edit Bug 17268: (QA follow-up) Make "Convert old browser macros" translatable The code was missing the necessary markup to make the string translatable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #102 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104153&action=edit Bug 17268: (follow-up) Don't show the macro ID in front of description I believe it's nicer to allow users to organize the macros as they want using the descrpitions they prefer. Submitting as a suggestion. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #103 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Last patch is a suggestion - but easiest to show in the code, what I mean :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #104 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #103)
Last patch is a suggestion - but easiest to show in the code, what I mean :)
I am happy with that. I think I only had id because you can reuse the same name, but this works. Thank you! So happy to see this :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #105 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #106 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25494 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 [Bug 25494] Warnings in advanced editor macros routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26954 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26954 [Bug 26954] Display macros in Advanced Cataloging Editor in alphabetical order and add sort capability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26955 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26955 [Bug 26955] Allow macros in Advanced Cataloging Editor to be renamed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26965 [Bug 26965] streetnumber field not shown in table when searching by partial patron data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26929 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 [Bug 26929] Koha will only display the first 20 macros Advanced Editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26965 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26965 [Bug 26965] streetnumber field not shown in table when searching by partial patron data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 [Bug 26964] The option to Save is not showing on the Advanced Editor when created a Macro -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org