[Bug 25494] New: Warnings in advanced editor macros routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 Bug ID: 25494 Summary: Warnings in advanced editor macros routes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com To reproduce: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/advanced_editor_macros.t => FAIL: Two numbers are warned -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 104855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104855&action=edit Bug 25494: Remove warnings in advanced editor macros routes There's a couple leftover 'warn's in the controller code. This patch removes that. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/advanced_editor_macros.t => FAIL: Two numbers are warned 2. Apply this patch and repeat 1 => SUCCESS: No more warns 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_candidate Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |17268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #1)
To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/advanced_editor_macros.t
Can this be tested in a 'legacy' install? No vagrant/docker but a simple dev install Test fails for me, but perhaps I need some other setup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |nick@bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 25482 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 Bug 25494 depends on bug 17268, which changed state. Bug 17268 Summary: Advanced cataloging editor - rancor - macros are lost when browser storage cleared https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org