[Bug 41521] New: WebService::ILS::OverDrive not passing pl_valid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Bug ID: 41521 Summary: WebService::ILS::OverDrive not passing pl_valid Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org
From bug 40680 comment 23
Those patches fix most of the issues. Remaining ones: not ok 455 - Koha/ExternalContent/OverDrive.pm has syntax warnings. # Failed test 'Koha/ExternalContent/OverDrive.pm has syntax warnings.' # at xt/pl_valid.t line 63. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. not ok 2266 - opac/external/overdrive/auth.pl has syntax warnings. # Failed test 'opac/external/overdrive/auth.pl has syntax warnings.' # at xt/pl_valid.t line 63. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. not ok 2356 - opac/svc/overdrive has syntax warnings. # Failed test 'opac/svc/overdrive has syntax warnings.' # at xt/pl_valid.t line 63. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. Test plan: Startup ktd using trixie's image export DB_IMAGE=mariadb:latest; export KOHA_IMAGE=main-trixie; ktd pull && ktd down && ktd --selenium --es7 up Run prove xt/pl_valid.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40680 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41077 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41077 [Bug 41077] [OMNIBUS] Debian 13 and Perl 5.40 compatibility -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Do we embed WebService::ILS::OverDrive in Koha (under lib)? At least for a quick solution, and maybe improve the situation later. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #1)
Do we embed WebService::ILS::OverDrive in Koha (under lib)?
At least for a quick solution, and maybe improve the situation later.
Yeah, I think that's probably going to be the only viable option for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- There are already 2 other libs forked there. So yep, why not a third. Subclassing WebService/ILS/OverDrive/Patron.pm and overriding the relevant methods would introduce another way of managing such forking without an obvious benefit vs using /lib -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- I suppose one thing to keep in mind is that we might have to update other code than just those few lines so that it passes our tests. I bumped into that when subclassing Template::Stash::XS. But that's all right. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191897&action=edit Bug 41521: Remove deps from cpanfile Patch from commit 2a15a6b -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191897|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191898&action=edit Bug 41521: Add WebService::ILS to lib/ Patch from commit a34697d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191899&action=edit Bug 41521: Remove perl valid warnings % perl -wc Koha/ExternalContent/OverDrive.pm Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 365. Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 573. Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 643. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191900&action=edit Bug 41521: Reject lib/ from tidy check Patch from commit 0978bb7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191901&action=edit Bug 41521: Remove deps from cpanfile Patch from commit 2a15a6b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191902&action=edit Bug 41521: Exclude lib/WebService from pod xt tests Patch from commit f10f0b8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191903&action=edit Bug 41521: Fix spelling Patch from commit 77e0a35 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191904&action=edit Bug 41521: Fix forbidden patterns (trailing spaces and http) Patch from commit 19d32ef -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191905&action=edit Bug 41521: Silent perlcritic warnings Stricture disabled at line 67, column 5. See page 429 of PBP. (Severity: 5) We should deal with that later instead of ignoring the warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- The qa script is still raising errors on POD but they are going to be ignored by the tests and CI should not complain. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191917&action=edit Bug 41521: Add WebService::ILS to lib/ Patch from commit a34697d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191918&action=edit Bug 41521: Remove perl valid warnings % perl -wc Koha/ExternalContent/OverDrive.pm Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 365. Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 573. Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 643. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191919&action=edit Bug 41521: Reject lib/ from tidy check Patch from commit 0978bb7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191919|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191918|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191917|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191898|0 |1 is obsolete| | --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 192669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192669&action=edit Bug 41521: Add WebService::ILS to lib/ Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191899|0 |1 is obsolete| | --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 192670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192670&action=edit Bug 41521: Remove perl valid warnings % perl -wc Koha/ExternalContent/OverDrive.pm Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 365. Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 573. Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 643. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191900|0 |1 is obsolete| | --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 192671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192671&action=edit Bug 41521: Reject lib/ from tidy check Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191901|0 |1 is obsolete| | --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 192672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192672&action=edit Bug 41521: Remove deps from cpanfile Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191902|0 |1 is obsolete| | --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 192673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192673&action=edit Bug 41521: Exclude lib/WebService from pod xt tests Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191903|0 |1 is obsolete| | --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 192674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192674&action=edit Bug 41521: Fix spelling Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191904|0 |1 is obsolete| | --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 192675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192675&action=edit Bug 41521: Fix forbidden patterns (trailing spaces and http) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191905|0 |1 is obsolete| | --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 192676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192676&action=edit Bug 41521: Silent perlcritic warnings Stricture disabled at line 67, column 5. See page 429 of PBP. (Severity: 5) We should deal with that later instead of ignoring the warnings Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- QA note: no accidental changes done to the lib And the changes look good. With another signoff I could pass QA. (compared with: # checkout commit 1 # then in KTD: mkdir /kohadevbox/koha/tmp cp -r /usr/share/perl5/WebService /kohadevbox/koha/tmp/ # host: meld tmp/WebService lib/WebService ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #28 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 192671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192671 Bug 41521: Reject lib/ from tidy check Review of attachment 192671: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=41521&attachment=192671) ----------------------------------------------------------------- ::: Koha/Devel/Files.pm @@ +35,4 @@
qw( Koha/Schema/Result Koha/Schema.pm + lib/
At some point, I was hoping that we'd start moving our modules into this directory though? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #28)
Comment on attachment 192671 [details] [review] Bug 41521: Reject lib/ from tidy check
Review of attachment 192671 [details] [review]: -----------------------------------------------------------------
::: Koha/Devel/Files.pm @@ +35,4 @@
qw( Koha/Schema/Result Koha/Schema.pm + lib/
At some point, I was hoping that we'd start moving our modules into this directory though?
Yes, "at some point" :D We will adjust when we will be there I'd say. We will certainly need to move those to lib/External or lib/ThirdParty. But this is not a new pattern. What do you suggest exactly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #30 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #29)
(In reply to David Cook from comment #28)
Comment on attachment 192671 [details] [review] [review] Bug 41521: Reject lib/ from tidy check
Review of attachment 192671 [details] [review] [review]: -----------------------------------------------------------------
::: Koha/Devel/Files.pm @@ +35,4 @@
qw( Koha/Schema/Result Koha/Schema.pm + lib/
At some point, I was hoping that we'd start moving our modules into this directory though?
Yes, "at some point" :D
Haha fair.
We will adjust when we will be there I'd say. We will certainly need to move those to lib/External or lib/ThirdParty. But this is not a new pattern.
I'm not sure what you mean here?
What do you suggest exactly?
I just mean rather than adding "lib/" to Koha/Devel/Files.pm, perhaps it would be better just to add "lib/WebService/ILS/OverDrive/"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #31 from David Cook <dcook@prosentient.com.au> --- Anyway... I'm just splitting hairs a bit I think so let's not worry about my comment there. Like Jonathan said we can always change that later if need be. "prove xt/pl_valid.t" takes a long time to run... I ran it to reproduce the original warning messages but to prove it after applying the patch I just did the following: perl -cw Koha/ExternalContent/OverDrive.pm perl -cw opac/external/overdrive/auth.pl perl -cw opac/svc/overdrive -- I'm not sure I understand the changes to Koha/Devel/Files.pm but I'm not too worried about that. Maybe it just means that we don't fail the "qa" tools for fails? Otherwise... changes look fairly straightforward. The warnings go away after the patch. I trust Jonathan and Victor but I figure I'll do a quick comparison of the modules anyway using "diff -r /usr/share/perl5/WebService/ lib/WebService/" Changes are minimal and logical, and they eliminate the problem. Looks solid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192669|0 |1 is obsolete| | --- Comment #32 from David Cook <dcook@prosentient.com.au> --- Created attachment 193819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193819&action=edit Bug 41521: Add WebService::ILS to lib/ Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192670|0 |1 is obsolete| | --- Comment #33 from David Cook <dcook@prosentient.com.au> --- Created attachment 193820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193820&action=edit Bug 41521: Remove perl valid warnings % perl -wc Koha/ExternalContent/OverDrive.pm Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 365. Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 573. Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 643. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192671|0 |1 is obsolete| | --- Comment #34 from David Cook <dcook@prosentient.com.au> --- Created attachment 193821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193821&action=edit Bug 41521: Reject lib/ from tidy check Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192672|0 |1 is obsolete| | --- Comment #35 from David Cook <dcook@prosentient.com.au> --- Created attachment 193822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193822&action=edit Bug 41521: Remove deps from cpanfile Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192673|0 |1 is obsolete| | --- Comment #36 from David Cook <dcook@prosentient.com.au> --- Created attachment 193823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193823&action=edit Bug 41521: Exclude lib/WebService from pod xt tests Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192674|0 |1 is obsolete| | --- Comment #37 from David Cook <dcook@prosentient.com.au> --- Created attachment 193824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193824&action=edit Bug 41521: Fix spelling Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192675|0 |1 is obsolete| | --- Comment #38 from David Cook <dcook@prosentient.com.au> --- Created attachment 193825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193825&action=edit Bug 41521: Fix forbidden patterns (trailing spaces and http) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192676|0 |1 is obsolete| | --- Comment #39 from David Cook <dcook@prosentient.com.au> --- Created attachment 193826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193826&action=edit Bug 41521: Silent perlcritic warnings Stricture disabled at line 67, column 5. See page 429 of PBP. (Severity: 5) We should deal with that later instead of ignoring the warnings Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #31)
I'm not sure I understand the changes to Koha/Devel/Files.pm but I'm not too worried about that. Maybe it just means that we don't fail the "qa" tools for fails?
We don't list files that are in the exception list, so those files are not tested (depending on the filetype and the test: "tidy", "valid", "codespell"). It's used by the xt/t tests and the QA script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Embedding release notes| |WebService::ILS::OverDrive | |into Koha to fix several | |perl validation errors. | |The author of the module is | |not reachable on CPAN. | |This can be reverted once | |upstream has been fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Bug 41521 depends on bug 40680, which changed state. Bug 40680 Summary: Many warnings on Perl 5.40 due to importing methods from not yet defined packages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 --- Comment #42 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org