[Bug 41585] New: Refunds should accept a cash register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Bug ID: 41585 Summary: Refunds should accept a cash register Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Point of Sale Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk We're not consistently recording cash registers for refund actions.. cash refunds in particular should require a cash register. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Refunds should accept a |Refunds don't always appear |cash register |on the register page --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I was wrong.. we have been generally handling this correctly.. what we weren't doing properly was the redirect flow to reload the page and display the results of the refund action. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191238&action=edit Bug 41585: Fix cash refund payouts not appearing in register transactions This patch fixes two issues with cash refunds on the register page: 1. Payouts were not appearing in the transactions table after being created because accountlines were fetched before the refund operation completed. 2. Account credit (AC) refunds were incorrectly creating payout transactions when no cash should leave the register. Changes: - Only create payout for non-AC refund types - Use explicit registerid from page context for payout - Add POST/REDIRECT/GET pattern after refund to refresh page data - Add client-side validation for cash register requirement on patron account page Test plan: 1. Navigate to POS register page with transactions 2. Issue a cash refund on a transaction 3. Verify the payout appears in the transactions table 4. Issue an account credit (AC) refund 5. Verify no payout is created (only the refund credit) 6. On patron account page, attempt cash refund without register 7. Verify validation message appears -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdunne-howrie@westminster.g | |ov.uk, | |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41592 [Bug 41592] Add an enhanced workflow for refunds against anonymous transactions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193260&action=edit Bug 41585: Fix cash refund payouts not appearing in register transactions This patch fixes two issues with cash refunds on the register page: 1. Payouts were not appearing in the transactions table after being created because accountlines were fetched before the refund operation completed. 2. Account credit (AC) refunds were incorrectly creating payout transactions when no cash should leave the register. Changes: - Only create payout for non-AC refund types - Use explicit registerid from page context for payout - Add POST/REDIRECT/GET pattern after refund to refresh page data - Add client-side validation for cash register requirement on patron account page Test plan: 1. Navigate to POS register page with transactions 2. Issue a cash refund on a transaction 3. Verify the payout appears in the transactions table 4. Issue an account credit (AC) refund 5. Verify no payout is created (only the refund credit) 6. On patron account page, attempt cash refund without register 7. Verify validation message appears Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add a 'cashup' process to accounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Signed Off |Failed QA --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Hi Martin, I'm seeing some merge issues when trying to apply the bug. CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 41585: Fix cash refund payouts not appearing in register transactions hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-41585-Fix-cash-refund-payouts-not-appearing-in-fmt2pg4p.patch Could you please rebase and then I would be happy to continue QAing it! Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193260|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195615&action=edit Bug 41585: Fix cash refund payouts not appearing in register transactions This patch fixes two issues with cash refunds on the register page: 1. Payouts were not appearing in the transactions table after being created because accountlines were fetched before the refund operation completed. 2. Account credit (AC) refunds were incorrectly creating payout transactions when no cash should leave the register. Changes: - Only create payout for non-AC refund types - Use explicit registerid from page context for payout - Add POST/REDIRECT/GET pattern after refund to refresh page data - Add client-side validation for cash register requirement on patron account page Test plan: 1. Navigate to POS register page with transactions 2. Issue a cash refund on a transaction 3. Verify the payout appears in the transactions table 4. Issue an account credit (AC) refund 5. Verify no payout is created (only the refund credit) 6. On patron account page, attempt cash refund without register 7. Verify validation message appears Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195615|0 |1 is obsolete| | --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 195626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195626&action=edit Bug 41585: Fix cash refund payouts not appearing in register transactions This patch fixes two issues with cash refunds on the register page: 1. Payouts were not appearing in the transactions table after being created because accountlines were fetched before the refund operation completed. 2. Account credit (AC) refunds were incorrectly creating payout transactions when no cash should leave the register. Changes: - Only create payout for non-AC refund types - Use explicit registerid from page context for payout - Add POST/REDIRECT/GET pattern after refund to refresh page data - Add client-side validation for cash register requirement on patron account page Test plan: 1. Navigate to POS register page with transactions 2. Issue a cash refund on a transaction 3. Verify the payout appears in the transactions table 4. Issue an account credit (AC) refund 5. Verify no payout is created (only the refund credit) 6. On patron account page, attempt cash refund without register 7. Verify validation message appears Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes two issues release notes| |with cash refunds on the | |register page: | | | |1. Payouts were not | |appearing in the | |transactions table after | |being | | created because | |accountlines were fetched | |before the refund | | operation completed. | | | |2. Account credit (AC) | |refunds were incorrectly | |creating payout | | transactions when no | |cash should leave the | |register. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41688 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 [Bug 41688] Refund modal and amount as NaN, rejected comma separator -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|41688 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 [Bug 41688] Refund modal and amount as NaN, rejected comma separator -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41819 [Bug 41819] Refunds via the Cash registers page should not result in PAYOUTS if the transaction type is 'Account Credit' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org