[Bug 36507] New: Cannot set desk as non superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Bug ID: 36507 Summary: Cannot set desk as non superlibrarian Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: 1. Turn on UseCirculationDesks 2. Create some desks 3. Login as a non-superlibrarian 4. Try to switch desks Undefined subroutine &C4::Context::IsSuperLibraian called at /kohadevbox/koha/circ/set-library.pl line 54 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Typo: IsSuperLibraian/IsSuperLibrarian -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- N(In reply to Lucas Gass from comment #1)
Typo: IsSuperLibraian/IsSuperLibrarian
Not just a typo though, with that fixed I am still unable to set a desk as a non-superlibrarian -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot set desk as non |Cannot set desk or register |superlibrarian |as non superlibrarian -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164395&action=edit Bug 36507: Allow non-superlibrarians to set desk and register To test: 1. Turn on UseCirculationDesks 2. Create some desks 3. Login as a non-superlibrarian 4. Try to switch desks, get an error 5. Turn on UseCashRegisters 6. Create some registers 7. As a non-superlibrarian try to change your register, get an error. 8. APPLY PATCH and restart_all 9. Try changing your desk and register again, it should now work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164395|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 164396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164396&action=edit Bug 36507: Allow non-superlibrarians to set desk and register To test: 1. Turn on UseCirculationDesks 2. Create some desks 3. Login as a non-superlibrarian 4. Try to switch desks, get an error 5. Turn on UseCashRegisters 6. Create some registers 7. As a non-superlibrarian try to change your register, get an error. 8. APPLY PATCH and restart_all 9. Try changing your desk and register again, it should now work. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Existing patch is good and fixes what's supposed to fix. But I think additional work is required here: When you set a desk and save, if you go back to the set desk screen, you'll notice the pre-selected value is not the one you just saved to. I believe this is caused by something wrong happening in desk_selection.js. If you apply the below changes, the issue I mention above gets fixed (but I'm unsure what it breaks - if anything): +++ b/koha-tmpl/intranet-tmpl/prog/js/desk_selection.js @@ -2,7 +2,7 @@ $(document).ready(function() { $("#desk_id").children().each(function() { var selectedBranch = $("#branch"). children("option:selected"). val(); if ($(this).attr('id') === "nodesk") { //set no desk by default, should be first element - $(this).prop("selected", true); + // $(this).prop("selected", true); $(this).prop("disabled", false); $(this).show(); } @@ -11,7 +11,7 @@ $(document).ready(function() { $('#nodesk').hide(); $(this).prop("disabled", false); $(this).show(); - $(this).prop("selected", true) + // $(this).prop("selected", true) } else { ---- FURTHER TESTING ---- Delete a desk: /cgi-bin/koha/admin/desks.pl?op=delete_confirm&desk_id=1 Confirmation screen has all blank data ---- Following the above, click confirm delete, you get: An error occurred when deleting this desk. Check the logs for details. ---- Edit an existing desk: /cgi-bin/koha/admin/desks.pl?op=add_form&desk_id=1 You're unable to change library (unsure if this is intended or not) ----- Some of the above may be considered their own separate bugs (the delete and edit(?) issues), but I feel like at least the first issue (wrong pre-selected desk) should be fixed here. Let me know if you disagree, and we can turn this to PQA and fix the others in their own bugs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Another note: circulate permission is not required for the staff member to set a desk/cash register, but upon successful update the patron is redirected to /cgi-bin/koha/circ/circulation.pl and that page does require the circulate permission, i.e. patron is presented with a 403 screen after successfully setting a desk/cash_register in this specific use case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Pedro Amorim from comment #5)
Existing patch is good and fixes what's supposed to fix. But I think additional work is required here:
When you set a desk and save, if you go back to the set desk screen, you'll notice the pre-selected value is not the one you just saved to.
I believe this is caused by something wrong happening in desk_selection.js. If you apply the below changes, the issue I mention above gets fixed (but I'm unsure what it breaks - if anything):
Pedro, have a look at Bug 30123, there is work been done to fix this particular issue there: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Lucas Gass from comment #7)
(In reply to Pedro Amorim from comment #5)
Existing patch is good and fixes what's supposed to fix. But I think additional work is required here:
When you set a desk and save, if you go back to the set desk screen, you'll notice the pre-selected value is not the one you just saved to.
I believe this is caused by something wrong happening in desk_selection.js. If you apply the below changes, the issue I mention above gets fixed (but I'm unsure what it breaks - if anything):
Pedro, have a look at Bug 30123, there is work been done to fix this particular issue there:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123
Hey, cool! Thanks. Should we PQA this one (36507) then and address the other issues in different bugs? i.e. "cannot delete a desk" and/or the others if they are indeed bugs? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like this bug survived way too long undetected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please file bugs for the other issues detected! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36572 [Bug 36572] Cleanup the set library page and avoid extra confirmation step -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like it depends on CSRF work, not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Did the follow-up issues here get resolved/reported? Can we drop the additional_work_needed keyword yet? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |david@davidnind.com --- Comment #14 from David Nind <david@davidnind.com> --- No changes required to the manual. Response required to comment #13 about additional work required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- @Pedro: can you please review your comments and let us know which additional bugs need filing so that we can remove the keyword? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #15)
@Pedro: can you please review your comments and let us know which additional bugs need filing so that we can remove the keyword?
I've done through my own notes, and I can't reproduce any of the 3 issues I listed at the time. All seems to have been fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #16)
(In reply to Katrin Fischer from comment #15)
@Pedro: can you please review your comments and let us know which additional bugs need filing so that we can remove the keyword?
I've done through my own notes, and I can't reproduce any of the 3 issues I listed at the time. All seems to have been fixed.
Thank you! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org