https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37096 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau@gmail.com Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37096 --- Comment #1 from Sam Lau <samalau@gmail.com> --- Created attachment 169869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169869&action=edit Bug 37096: Display error message for budget creation/modification if start/end date is left blank This patch adds an error message for a failed budget creation or modifcation due to the dates being empty. To test: 1) Go to the acquisitions tab, then on the side under 'Administration' select the 'Budgets' tab. 2) Click 'New budget', enter only a description and press save. 3) Note that the budget was not created, but no messages were displayed. 4) Apply patch, restart_all 5) Once again select 'New budget' and enter only a description. 6) This time when submitting, you will see an error message that says the process failed. 7) Edit an exisitng budget and remove the start date from this budget. 8) Attempt to save and note that the error message displays properly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37096 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169869|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169873&action=edit Bug 37096: Display error message for budget creation/modification if start/end date is left blank This patch adds an error message for a failed budget creation or modifcation due to the dates being empty. To test: 1) Go to the acquisitions tab, then on the side under 'Administration' select the 'Budgets' tab. 2) Click 'New budget', enter only a description and press save. 3) Note that the budget was not created, but no messages were displayed. 4) Apply patch, restart_all 5) Once again select 'New budget' and enter only a description. 6) This time when submitting, you will see an error message that says the process failed. 7) Edit an exisitng budget and remove the start date from this budget. 8) Attempt to save and note that the error message displays properly. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37096 --- Comment #4 from Sam Lau <samalau@gmail.com> --- (In reply to Roman Dolny from comment #3)

This works as described, but shouldn't we prevent the form from being saved until all required fields are filled in?

Validating flatpickr values isn't the easiest thing to do. I couldn't find a way to make both of them required before submission while still utilizing jquery validation, so this solution was the next best thing for now -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37096 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Roman Dolny from comment #3)

This works as described, but shouldn't we prevent the form from being saved until all required fields are filled in?

Yeah, sounds good. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37096 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Some minor QA comments: my $action = $budget_period_id ne '' ? 'modify' : 'add'; This probably may trigger an uninitialized warning. Shouldnt we fix by adding a fallback here: my $budget_period_id = $input->param('budget_period_id'); if ( $budget_period_startdate eq '' || $budget_period_enddate eq '' ) { Same here. Add fallback to: my $budget_period_startdate = $input->param('budget_period_startdate'); my $budget_period_enddate = $input->param('budget_period_enddate'); EXIT_IF: { [etc] $op = 'else'; last EXIT_IF; Using last (goto) is not the best programming style. And it seems easy to adjust the next if / else to prevent needing it. + [% IF failed_add_validate %] I wonder if adding something with no start- or enddate here would be more clear? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37096 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.