[Bug 23383] New: IdRef link appears even with syspref is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Bug ID: 23383 Summary: IdRef link appears even with syspref is off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org IdRef link is displayed via XSLT. There is a test of syspref with just if value is defined. But in installer/data/mysql/sysprefs.sql you see this pref will be 0 by default, which is true in XPATH. We should test that pref is 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 [Bug 8992] Add an interfacing with the idref webservice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 91812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91812&action=edit Bug 23383: fix IdRef syspref test in XSLT IdRef link is displayed via XSLT. There is a test of syspref with just if value is defined. But in installer/data/mysql/sysprefs.sql you see this pref will be 0 by default, which is true in XPATH. We should test that pref is 1. Test plan : 1) Create a fresh UNIMARC database 2) You have pref IdRef disabled 3) Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 4) Go to the opac detail page of the record => You don't see IdRef link 5) Enable IdRef syspref 6) Go to the opac detail page of the record => You see IdRef link 7) Disable IdRef syspref 8) Go to the opac detail page of the record => You don't see IdRef link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi, testing this. Patch is simple and syntactically correct. What framework are you using? With english or unimarc_complete (fr-FR) field 009 is hidden. Are you using another one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91812|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100329&action=edit Bug 23383: fix IdRef syspref test in XSLT IdRef link is displayed via XSLT. There is a test of syspref with just if value is defined. But in installer/data/mysql/sysprefs.sql you see this pref will be 0 by default, which is true in XPATH. We should test that pref is 1. Test plan : 1) Create a fresh UNIMARC database 2) You have pref IdRef disabled 3) Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 4) Go to the opac detail page of the record => You don't see IdRef link 5) Enable IdRef syspref 6) Go to the opac detail page of the record => You see IdRef link 7) Disable IdRef syspref 8) Go to the opac detail page of the record => You don't see IdRef link Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice catch Fridolin, Code scans well and I believe would do as expected. I agree, looking at the code Bernardo's point makes sense.. I don't have Unimarc test set here so haven't directly tested but I can't see that though would cause a negative regression so am signing off anyway to let it move forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100329|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100588&action=edit Bug 23383: fix IdRef syspref test in XSLT IdRef link is displayed via XSLT. There is a test of syspref with just if value is defined. But in installer/data/mysql/sysprefs.sql you see this pref will be 0 by default, which is true in XPATH. We should test that pref is 1. Test plan : 1) Create a fresh UNIMARC database 2) You have pref IdRef disabled 3) Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 4) Go to the opac detail page of the record => You don't see IdRef link 5) Enable IdRef syspref 6) Go to the opac detail page of the record => You see IdRef link 7) Disable IdRef syspref 8) Go to the opac detail page of the record => You don't see IdRef link Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in| |19.05.10 CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #9 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Minor/normal patch will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org