[Bug 24851] New: No sample libraries for UNIMARC installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Bug ID: 24851 Summary: No sample libraries for UNIMARC installations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100590&action=edit Bug 24851: Insert libraries sample data for "UNIMARC" I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. misc4dev will use fr-FR sample data for "UNIMARC" This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29 Test plan: outside your box, in koha-testing-docker (up-to-date), edit .env and set KOHA_MARC_FLAVOUR=unimarc DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc Then start the koha container When the misc4dev will start its job, the scripts will have the expected data to continue. Without this patch you will get koha_1 | Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. And plenty of errors will follow. Also, the sample data used in misc4dev will use CPL (/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100590|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 100596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100596&action=edit Bug 24851: Insert libraries sample data for "UNIMARC" I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. misc4dev will use fr-FR sample data for "UNIMARC" This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29 Test plan: outside your box, in koha-testing-docker (up-to-date), edit .env and set KOHA_MARC_FLAVOUR=unimarc DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc Then start the koha container When the misc4dev will start its job, the scripts will have the expected data to continue. Without this patch you will get koha_1 | Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. And plenty of errors will follow. Also, the sample data used in misc4dev will use CPL (/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql) Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Thanks Jonathan for doing this, and Jon for testing. It will be great to be able to test UNIMARC related bugs using koha-testing-docker! I was trying to test this earlier, and I couldn't get it to work by following the test plan - so I'm probably doing something wrong! What I did and the results: 1) git pull for the koha-testing-docker repository (so that is up-to-date) and docker-compose pull so that all the images are up-to-date as well. 2) Started up, kshell, applied patch, shut down 3) Made the changes to the .env file 4) Started up koha-testing-docker 5) Get these messages during start up: Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. ... ... C4::Installer::load_sql returned the following errors while attempting to load /kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql: koha_1 | DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at /usr/share/perl5/DBIx/RunSQL.pm line 273. koha_1 | Something went wrong loading file /kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql ([SQL ERROR]: INSERT INTO `items` ( `itemn... ..... ..... error retrieving biblio 1 at /kohadevbox/koha/misc/migration_tools/rebuild_zebra.pl line 681. ^^^^ that message repeats - trying to retrieve all the biblio entries (number after changes) Use of uninitialized value in string eq at /kohadevbox/koha/misc/migration_tools/rebuild_zebra.pl line 663. ^^^^ line number changes between 86, 92, and 663 6) When I go to 127.0.0.1:8081 I get the web installer Not sure what I'm doing wrong here, but I'm sure it is something simple and obvious to you! The patch is applied, so I shouldn't be getting all the errors above! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24856 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes David, that's exactly the purpose of this patch here :) I have just done a pull request on koha-misc4dev: https://gitlab.com/koha-community/koha-misc4dev/-/issues/29 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could you retry using the test plan I let on the pull request? What you tried should have worked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 --- Comment #6 from David Nind <david@davidnind.com> --- Thanks Jonathan! I'll have another go at it this evening. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 100691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100691&action=edit Bug 24851: UNIMARC - koha-testing-docker start up I had another go. Bug 24851 and Bug 24856 seem to have applied successfully, and it seems to have picked up the changes from https://gitlab.com/joubu/koha-misc4dev/-/tree/issue_29 I've attached the log of the koha-testing-docker start up - I've removed the repeating error lines at 14346 and 14385, and the insertion of reocords and authorities. End result for me = web installer appears when you go to 127.0.0.1:8081 I'll let someone else have a go - they may be more successful in getting this working! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Only one thing here: +++ b/installer/data/mysql/fr-FR/2-Optionel/sample_libraries.txt I think this should be in French! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100736&action=edit Bug 24851: Translate the .txt in French -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100596|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 100818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100818&action=edit Bug 24851: Insert libraries sample data for "UNIMARC" I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. misc4dev will use fr-FR sample data for "UNIMARC" This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29 Test plan: outside your box, in koha-testing-docker (up-to-date), edit .env and set KOHA_MARC_FLAVOUR=unimarc DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc Then start the koha container When the misc4dev will start its job, the scripts will have the expected data to continue. Without this patch you will get koha_1 | Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. And plenty of errors will follow. Also, the sample data used in misc4dev will use CPL (/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql) Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100818|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 100819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100819&action=edit Bug 24851: Insert libraries sample data for "UNIMARC" I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. misc4dev will use fr-FR sample data for "UNIMARC" This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29 Test plan: outside your box, in koha-testing-docker (up-to-date), edit .env and set KOHA_MARC_FLAVOUR=unimarc DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc Then start the koha container When the misc4dev will start its job, the scripts will have the expected data to continue. Without this patch you will get koha_1 | Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. And plenty of errors will follow. Also, the sample data used in misc4dev will use CPL (/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql) Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Current status: Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100736|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 100820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100820&action=edit Bug 24851: Translate the .txt in French Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #14 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in| |19.05.10 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #16 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Enhancement/normal will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org