http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8972 --- Comment #1 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 13064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13064&action=edit Screen Shot 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8972 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- I think the fix here is to remove the ability to type, ie they have to use the datepicker. Or refuse to accept 2 digit dates. Trying to guess if the person means 1912, 2012, 2112 .. is just building technical debt. So i vote force them to enter a valid date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8972 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8972 --- Comment #5 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13295&action=edit Bug 8972 - Due Date set to 100 years ago In order to prevent submission of dates with ambiguous two-digit years this patch makes date-due input fields read-only so that users must use date/time picker. Other minor fixes: - Adding missing labels - Adding common class wrapper to datepicker for checkout and renewal - Correcting focus handling on "specify due date" field (should focus on barcode field after a date has been selected). - Removing trailing comma from JavaScript (breaks IE) To test, try typing an invalid number in any of the date due entry fields: Under 'specify due date,' 'renewal due date,' or the confirm "invalid" date dialog (after specifying a date in the past). Manual entry should not work. Choosing a date/time using the widget should work. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8972 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13287|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8972 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Melia Meggs <melia@bywatersolutions.com> --- I tested this patch by following Owen's test plan. It worked beautifully in all three cases (specify due date, renewal date, and confirm invalid date). And I like the little slide bars for the hours and minutes. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8972 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com Severity|critical |normal --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments: * passes koha-qa.pl * I think, even if I couldn't check it, that there's no string change (the "Specify due date..." is not translated in french for 3.10 * I don't think libraries will complain that the behaviour changed, but I just wanted to point that this patch introduces a small change in circulation workflow. * the severity is not critical, because it's a bug only when the librarian put silly data in the date. Lowering severity Overall, not sure it should be pushed for 3.10.0 because of string freeze, but for 3.10.1 yes. passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8972 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Does not apply to 3.8.x, please create a rebased patch if it is needed in 3.8.x -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8972 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.