[Bug 8931] New: submit buttons have blue background
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Priority: P5 - low Change sponsored?: --- Bug ID: 8931 Assignee: oleonard@myacpl.org Summary: submit buttons have blue background Severity: normal Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: rel_3_10 Component: Templates Product: Koha Created attachment 12862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12862&action=edit one example In my staff client on Mac/FF all submit buttons have a blue shaded background - I think it should be white or be included in the outline for the box. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Happens on Chrome on Mac as well. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12863&action=edit Bug 8931 - submit buttons have blue background This patch specifies a transparent background for fieldsets and divs with the class "action," which are typically containers for the submit/cancel actions. For testers, a good example page to view is the "set library" page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12863|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12864&action=edit [SIGNED-OFF] Bug 8931 - submit buttons have blue background This patch specifies a transparent background for fieldsets and divs with the class "action," which are typically containers for the submit/cancel actions. For testers, a good example page to view is the "set library" page. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12957&action=edit example of the opposite This button on /cgi-bin/koha/members/files.pl?borrowernumber=53 should have a blue background - or be below the blue box ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #4)
Created attachment 12957 [details] example of the opposite
This button on /cgi-bin/koha/members/files.pl?borrowernumber=53 should have a blue background - or be below the blue box ...
Nicole, what do you want to mean with this attachment ? Does it mean I should not push this patch (I see no difference between before and after this patch for the background-color, that is white in both cases) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Pushing the patch is A-OK. I'm just showing Owen one other example that similar that this patch doesn't fix. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #5)
(In reply to comment #4)
Created attachment 12957 [details] example of the opposite
This button on /cgi-bin/koha/members/files.pl?borrowernumber=53 should have a blue background - or be below the blue box ...
Nicole, what do you want to mean with this attachment ? Does it mean I should not push this patch (I see no difference between before and after this patch for the background-color, that is white in both cases)
i have confirmed a difference before and after this patch passing QA, patch works as stated :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and is suitable for backporting to 3.10. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12864|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13311&action=edit Bug 8931 [Follow-up] submit buttons have blue background This follow-up removes the white background from fieldsets with class "action" when they are embedded inside another fieldset (Comment 4). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13311|0 |1 is obsolete| | --- Comment #11 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13324&action=edit [Signed off] Bug 8931 [Follow-up] submit buttons have blue background This follow-up removes the white background from fieldsets with class "action" when they are embedded inside another fieldset (Comment 4). Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia@bywatersolutions.com --- Comment #12 from Melia Meggs <melia@bywatersolutions.com> --- I tested on the "files" tab of the patron record, and I see that the white part behind the upload button is now gone. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Simple css fix. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- follow-up pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8931 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org