[Bug 10825] New: detail.tt displays duplicated enumchron values for serial items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Bug ID: 10825 Summary: detail.tt displays duplicated enumchron values for serial items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org when a serial is received, its serialseq info is automatically copied into it's item.enumchron field when that newly created item is displayed in the staff details page both its enumchron and serialseq values are displayed together. the bug is - both values are identical creating a duplication of info (pic attached) the solution is to only display one of the two fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 20792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20792&action=edit pic -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Created attachment 20793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20793&action=edit Bug 10825 - detail.tt displays duplicated enumchron values for serial items -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 20794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20794&action=edit pic, after applied patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20793|0 |1 is obsolete| | --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Comment on attachment 20793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20793 Bug 10825 - detail.tt displays duplicated enumchron values for serial items hmm, this patch looks buggy - i will test and resumbit... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Created attachment 21110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21110&action=edit Bug 10825 - detail.tt displays duplicated enumchron values for serial items -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21110|0 |1 is obsolete| | --- Comment #6 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 21120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21120&action=edit Bug 10825 - detail.tt displays duplicated enumchron values for serial items -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|oleonard@myacpl.org |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mason, I am sorry, but I can't reproduce the wrong display. I am wondering where the date and serialseq should be pulled from? Can you please clarify? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Bob Birchall <bob@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob@calyx.net.au --- Comment #8 from Bob Birchall <bob@calyx.net.au> --- (In reply to Katrin Fischer from comment #7)
Hi Mason,
I am sorry, but I can't reproduce the wrong display. I am wondering where the date and serialseq should be pulled from? Can you please clarify?
Hi Cait, as far as I understand, the problem arises only for serials items received through the Serials module. Mason tells me that both items.enumchron and serial.serialseq are displayed, hence the duplication. I hope this helps. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Bob, thx for the comment :) I had tested with items created in serials, but I just couldn't make both fields show up :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |liz@catalyst.net.nz --- Comment #10 from Liz Rea <liz@catalyst.net.nz> --- I am actually seeing this bug - will get test data that can replicate to test the patch. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #11 from Liz Rea <liz@catalyst.net.nz> --- I suspect there is a combination of system preferences that makes this bug manifest. Among the possibilities are XSLT vs Normal display, Separate holdings vs unified holdings, and possibly others. This patch only addresses one of the possibilities - will submit follow up for second case. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #12 from Nicole C. Engard <nengard@gmail.com> --- I have seen this, but I would like to note that not always are items.enumchron and serial.serialseq the same thing - I think we actually had someone make it show both a little while back because of just that. I thought I had a bug suggestion a way to break this in to two columns or style it so we can hide one if want but I can't find that bug. I do not vote to removing one altogether though. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21120|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26224&action=edit [SIGNED OFF] Bug 10825 - detail.tt displays duplicated enumchron values for serial items TEST PLAN --------- 1) Find a data point that displays like the picture on this bug report. 2) Apply the patch 3) Refresh the screen 4) Does it look like the second picture now with the duplication removed? 5) Run koha qa test tools I did attempt with default and blank for the XSLT system preferences for the staff client. This does go against Nicole's comment #12. Counter patch to follow. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26225&action=edit Bug 10825 - detail.tt displays duplicated enumchron values for serial items TEST PLAN --------- 1) Find a data point that displays like the picture on this bug report. 2) Apply the patch 3) Refresh the screen 4) Does it look like the second picture now with the duplication removed? 5) Run koha qa test tools I did attempt with default and blank for the XSLT system preferences for the staff client. This accounts for Nicole's comment #12. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #15 from Magnus Enger <magnus@enger.priv.no> --- Hm, I'm a bit confused. This bug has two patches, both with Mason as the author. Both batches are uploaded by Mark, but one has a signed off line from Mark and one does not. Mark: Did you mean to sign off both of these, but forgot to add the signoff to the second one? Should it be marked "Signed off"? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Magnus, the first one does not account for Nicole's comment #12. However, since I do not know the validity of the suggestion, I coded a counter-patch which does account for it as noted in comment #14. You apply one or the other -- not both. The first patch will only put out enumchron if enumchron is defined, and if it is not defined, then it will consider putting out serialseq. The second patch will put out both enumchron and serialseq if they are different. And it will only put them out if they are defined. Hope this clears that up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- In order to find one try select biblionumber,serialseq from serial and then use one of those biblionumbers in the http://STAFF/cgi-bin/koha/catalogue/detail.pl?biblionumber=### URL. select serial.biblionumber as bibno,biblioitems.biblioitemnumber as bibino,items.itemnumber as itemno,items.dateaccessioned,items.enumchron,serialseq from serial,biblioitems,items,serialitems where serial.serialid=serialitems.serialid and serialitems.itemnumber=items.itemnumber and serial.biblionumber=biblioitems.biblionumber and biblioitems.biblioitemnumber=items.biblioitemnumber order by biblioitems.biblionumber; -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #18 from M. Tompsett <mtompset@hotmail.com> --- Useful information for testing 1) Log into staff client, note library branch. 2) Change branch to one that has serials. 3) Click 'Serials'. 4) Click 'Submit' button for lots of results. 5) Choose one that has received items, click the title. 6) Click 'Serial collection' in the left panel. 7) Check an edit box, and click the 'Edit serials' button. 8) Manually edit the "Numbered" as needed. 9) Click 'Home' 10) Click 'Serials' 11) Click 'Submit' button for lots of results. 12) For the item modified (or just viewed), note the ISSN number. Use it to find the biblio number. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10823 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion Depends on| |10823 --- Comment #19 from M. Tompsett <mtompset@hotmail.com> --- This will solve the duplicate problem after the styling issue is dealt with. Hence, I have made this depend on 10823. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #20 from Mason James <mtj@kohaaloha.com> --- (In reply to M. Tompsett from comment #16)
Magnus, the first one does not account for Nicole's comment #12. However, since I do not know the validity of the suggestion, I coded a counter-patch which does account for it as noted in comment #14.
You apply one or the other -- not both.
The first patch will only put out enumchron if enumchron is defined, and if it is not defined, then it will consider putting out serialseq.
The second patch will put out both enumchron and serialseq if they are different. And it will only put them out if they are defined.
Hope this clears that up.
Mark's patch sounds better than my patch, lets use that one... i will mark my patch 'obsolete' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26224|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26225|0 |1 is obsolete| | --- Comment #21 from Mason James <mtj@kohaaloha.com> --- Created attachment 27090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27090&action=edit Bug 10825 - detail.tt displays duplicated enumchron values for serial items TEST PLAN --------- 1) Find a data point that displays like the picture on this bug report. 2) Apply the patch 3) Refresh the screen 4) Does it look like the second picture now with the duplication removed? 5) Run koha qa test tools I did attempt with default and blank for the XSLT system preferences for the staff client. This accounts for Nicole's comment #12. Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #22 from Mason James <mtj@kohaaloha.com> --- Mark you might need to update the 'author' of your patch.. you patch still has my name on it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10823 | Blocks| |10823 Depends on|10823 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #23 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #22)
Mark you might need to update the 'author' of your patch..
you patch still has my name on it
i've tested Mark's patch, it looks good and works as expected thanks Mark! :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27090|0 |1 is obsolete| | --- Comment #24 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 27100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27100&action=edit Bug 10825 - detail.tt displays duplicated enumchron values for serial items TEST PLAN --------- 1) Find a data point that displays like the picture on this bug report. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 2) Apply the patch 3) Refresh the screen 4) Does it look like the second picture now with the duplication removed? 5) Run koha qa test tools I did attempt with default and blank for the XSLT system preferences for the staff client. This accounts for Nicole's comment #12. Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27100|0 |1 is obsolete| | --- Comment #25 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 27101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27101&action=edit [SIGNED OFF] Bug 10825 - detail.tt displays duplicated enumchron values for serial items TEST PLAN --------- 1) Find a data point that displays like the picture on this bug report. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 2) Apply the patch 3) Refresh the screen 4) Does it look like the second picture now with the duplication removed? 5) Run koha qa test tools I did attempt with default and blank for the XSLT system preferences for the staff client. This accounts for Nicole's comment #12. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #26 from M. Tompsett <mtompset@hotmail.com> --- Considering that both you and I tested it, Mason, and it was initially your patch. I'm not concerned about the author. I'm concerned about getting patches into Koha to improve it. We have two independent folk saying the patch is good. QA'ing seems the next logical step. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not totally sure why we'd want to display both there or why they might be different, but the patch just ensures that only one shows when both are the same - so this seems a harmless improvement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27101|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27119&action=edit [PASSED QA] Bug 10825 - detail.tt displays duplicated enumchron values for serial items TEST PLAN --------- 1) Find a data point that displays like the picture on this bug report. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 2) Apply the patch 3) Refresh the screen 4) Does it look like the second picture now with the duplication removed? 5) Run koha qa test tools I did attempt with default and blank for the XSLT system preferences for the staff client. This accounts for Nicole's comment #12. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. Template change only. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #29 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mason and Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #30 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 5768 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #31 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Picked for 3.12.15! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org