[Bug 12081] New: tmpl_process3.pl delete temp files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Bug ID: 12081 Summary: tmpl_process3.pl delete temp files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Every time you run translate script it makes temporary files on /tmp This files are not deleted, and over time it takes a lot of space. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27110&action=edit Bug 12081 - tmpl_process3.pl - delete temp files This patch enable deletion of temp files used by tmpl_process3.pl. Just removed coments on existing code To test: 1. Do a count of files on /tmp ( ls /tmp | wc -l ) 2. Update preferred language 3. Count again, new files on /tmp 4. Apply the patch 5. Update again, check, no new files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27110|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 27137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27137&action=edit [SIGNED OFF] Bug 12081 - tmpl_process3.pl - delete temp files This patch enable deletion of temp files used by tmpl_process3.pl. Just removed coments on existing code To test: 1. Do a count of files on /tmp ( ls /tmp | wc -l ) 2. Update preferred language 3. Count again, new files on /tmp 4. Apply the patch 5. Update again, check, no new files Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I watched what temp files were actually in /tmp to make sure other processes didn't magically increase/decrease the number. $ perl translate update {lang code} generated 10 temporary files for me (2x5 po files). After removing those ten files, and applying the patch, no other files were generated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27166&action=edit Bug 12081 - tmpl_process3.pl - delete temp files This patch enable deletion of temp files used by tmpl_process3.pl. Just removed coments on existing code To test: 1. Do a count of files on /tmp ( ls /tmp | wc -l ) 2. Update preferred language 3. Count again, new files on /tmp 4. Apply the patch 5. Update again, check, no new files Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I watched what temp files were actually in /tmp to make sure other processes didn't magically increase/decrease the number. $ perl translate update {lang code} generated 10 temporary files for me (2x5 po files). After removing those ten files, and applying the patch, no other files were generated. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> These lines has been commented by commit a399dcefad193fc21ef2dc1fe31d07686ab2da46 without any apparent good reason. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Summary|tmpl_process3.pl delete |tmpl_process3.pl does not |temp files |delete temp files Severity|enhancement |normal --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- In my opinion, this is a bug, not an enhancement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27137|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Comment on attachment 27137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27137 [SIGNED OFF] Bug 12081 - tmpl_process3.pl - delete temp files Obsolted old patch :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Picked for 3.12.15! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org