[Bug 41043] New: Use op 'add_form' and 'edit_form' instead of 'add' and 'edit'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 Bug ID: 41043 Summary: Use op 'add_form' and 'edit_form' instead of 'add' and 'edit' Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form. This is missing only in admin/oai_servers.pl and admin/z3950servers.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 188057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188057&action=edit Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form. This is missing only in admin/z3950servers.pl This patch also removes TT variable add_form to avoid confusion Test plan : 1) Create a new z3950 server 2) Enter mandatory datas in form and save 3) Edit this server 4) Copy this server 5) Repeat 1 to 4 for a SRU server -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 188058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188058&action=edit Bug 41043: Use op 'add_form' and 'edit_form' in oai servers Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form. This is missing only in admin/oai_servers.pl This patch also removes TT variable add_form to avoid confusion Test plan : 1) Create a new OAI repository 2) Enter mandatory datas in form and save 3) Edit this repository 4) Copy this repository -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188057|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 188059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188059&action=edit Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form. This is missing only in admin/z3950servers.pl This patch also removes TT variable add_form to avoid confusion Test plan : 1) Create a new z3950 server 2) Enter mandatory datas in form and save 3) Edit this server 4) Copy this server 5) Repeat 1 to 4 for a SRU server -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188058|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 190003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190003&action=edit Bug 41043: Use op 'add_form' and 'edit_form' in oai servers Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form. This is missing only in admin/oai_servers.pl This patch also removes TT variable add_form to avoid confusion Test plan : 1) Create a new OAI repository 2) Enter mandatory datas in form and save 3) Edit this repository 4) Copy this repository Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188059|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 190004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190004&action=edit Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form. This is missing only in admin/z3950servers.pl This patch also removes TT variable add_form to avoid confusion Test plan : 1) Create a new z3950 server 2) Enter mandatory datas in form and save 3) Edit this server 4) Copy this server 5) Repeat 1 to 4 for a SRU server Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190003|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 --- Comment #6 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192253&action=edit Bug 41043: Use op 'add_form' and 'edit_form' in oai servers Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form. This is missing only in admin/oai_servers.pl This patch also removes TT variable add_form to avoid confusion Test plan : 1) Create a new OAI repository 2) Enter mandatory datas in form and save 3) Edit this repository 4) Copy this repository Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 --- Comment #7 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192254&action=edit Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form. This is missing only in admin/z3950servers.pl This patch also removes TT variable add_form to avoid confusion Test plan : 1) Create a new z3950 server 2) Enter mandatory datas in form and save 3) Edit this server 4) Copy this server 5) Repeat 1 to 4 for a SRU server Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40841 [Bug 40841] Limit z39.50 targets to specific branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41043 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org