[Bug 40568] New: Various corrections to recalls templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 Bug ID: 40568 Summary: Various corrections to recalls templates Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 40560, 40566 I've got a few random corrections to make to a couple of recalls templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40560 [Bug 40560] Incorrect breadcrumb on recall history https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40566 [Bug 40566] "Home library" empty on "Recalls history" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184937&action=edit Bug 40568: Various corrections to recalls templates This patch makes various minor changes to recalls templates. - Correct markup in dropdown menu - Correct sorting of dates in tables - Wrap recalls table in "page-section" div. - Hide "Show old recalls" if there are no recalls. To test, apply the patch and enable Recalls if necessary. - If necessary, place some recalls. - Go to Circulation -> Recalls queue and check the "Actions" menu for one of the recalls. The "Mark as overdue" menu item should be formatted correctly. - Check the sorting of date columns on the "Recalls queue" page. It should be correct. - View a patron who has never placed a recall. Go to their recalls history and confirm that you see a "Patron has no recalls" message but no "Show old recalls" checkbox. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40589 [Bug 40589] Add table settings to recalls pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- The patch still applies, however: 1. I have no idea on the SQL required to make a recall overdue so that the "Mark as overdue" menu item is shown. 2. For sorting of date columns on the "Recalls queue" page, it seems to work OK before the patch--so I'm not sure how to reproduce that it is not working. (Example SQL to update the created date: update recalls set created_date = "2025-11-07 00:00:00" where recall_id=1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... git bz apply 40568 Bug 40568 - Various corrections to recalls templates 184937 - Bug 40568: Various corrections to recalls templates Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 40568: Various corrections to recalls templates Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/recalls.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/recalls.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/recalls.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 40568: Various corrections to recalls templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184937|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190902&action=edit Bug 40568: Various corrections to recalls templates This patch makes various minor changes to recalls templates. - Correct sorting of dates in tables - Wrap recalls table in "page-section" div. - Hide "Show old recalls" if there are no recalls. To test, apply the patch and enable Recalls if necessary. - If necessary, place some recalls. - Check the sorting of date columns on the "Recalls queue" page. It should be correct. - View a patron who has never placed a recall. Go to their recalls history and confirm that you see a "Patron has no recalls" message but no "Show old recalls" checkbox. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190902|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 190913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190913&action=edit Bug 40568: Various corrections to recalls templates This patch makes various minor changes to recalls templates. - Correct sorting of dates in tables - Wrap recalls table in "page-section" div. - Hide "Show old recalls" if there are no recalls. To test, apply the patch and enable Recalls if necessary. - If necessary, place some recalls. - Check the sorting of date columns on the "Recalls queue" page. It should be correct. - View a patron who has never placed a recall. Go to their recalls history and confirm that you see a "Patron has no recalls" message but no "Show old recalls" checkbox. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This makes some minor release notes| |changes to recalls | |templates: | |- Fixes the date sorting on | |the recalls queue page | |- Hides "Show old recalls" | |if there are no recalls in | |a patron's recalls history, | |and adds the "page-section" | |div (white background) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190913|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 194095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194095&action=edit Bug 40568: Various corrections to recalls templates This patch makes various minor changes to recalls templates. - Correct sorting of dates in tables - Wrap recalls table in "page-section" div. - Hide "Show old recalls" if there are no recalls. To test, apply the patch and enable Recalls if necessary. - If necessary, place some recalls. - Check the sorting of date columns on the "Recalls queue" page. It should be correct. - View a patron who has never placed a recall. Go to their recalls history and confirm that you see a "Patron has no recalls" message but no "Show old recalls" checkbox. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40568 Bug 40568 depends on bug 40566, which changed state. Bug 40566 Summary: "Home library" empty on "Recalls history" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40566 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org