[Bug 34993] New: Framework don't load in existing records or duplicate as new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Bug ID: 34993 Summary: Framework don't load in existing records or duplicate as new Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lauren_denny@sil.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The system preference, ApplyFrameworkDefaults no longer works as expected on versions of 22.11 after 22.11.09. When 'Select All' is checked the ability to load the framework in 'existing records' and 'editing as new (duplicate)' no longer loads the text from the framework into the record. Koha still works as expected with creating new records and importing with Z39.50. The system preference connected with Frameworks still works on 22.05.15 but doesn't work on 22.11.09 or 22.11.10. Something happened in between 22.11.07 or 22.11.08 and 22.11.09. This issue was connected to Bug 30250 - Configure when to apply framework defaults when cataloguing which provided this feature in earlier updates of 22.05 & 22.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #1 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I can confirm that when I set ApplyFrameworkDefaults to apply defaults in all situations, I do not get default values applied either when duplicating an existing record in that framework or when creating a new record in that framework via z39.50. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Andrew Fuerste-Henry from comment #1)
I can confirm that when I set ApplyFrameworkDefaults to apply defaults in all situations, I do not get default values applied either when duplicating an existing record in that framework or when creating a new record in that framework via z39.50.
This was on 22.11.09.000. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Version|22.11 |master Depends on| |32484 --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Confirmed in master as well. A git bisect indicates this is likely a side effect of bug 32484 - Enable framework plugins when UseACQFrameworkForBiblioRecords is set. I don't have time to drill down further into debugging this at the moment, but if someone else does, hopefully this will be helpful. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Severity|normal |major --- Comment #4 from David Nind <david@davidnind.com> --- I've increased the importance to major - mainly as it is a regression, as well as the discussion at the koha-US conference and koha-US cataloguing SIG. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 33688 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 34499 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 [Bug 30250] Configure when to apply framework defaults when cataloguing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Framework don't load in |Framework doesn't load |existing records or |defaults in existing |duplicate as new |records or duplicate as new -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 34606 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 --- Comment #8 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 158277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158277&action=edit Bug 34993: Pass context parameters to generate_subfield_form Pass necessary parameters from the UI to ensure that the basic MARC editor can correctly identify when a framework is changed, a bib is being duplicated, or a bib is being imported with Z39.50 - for purposes of filling in default values according to the settings of ApplyFrameworkDefaults. To test: 1. Set the system preference ApplyFrameworkDefaults - Select All 2. Create or edit a MARC bibliographic framework with a default value in one of the fields (such as 500$a) 3. Go to the Cataloguing module and create a new record using the framework from step 2 --> Confirm that the default value is filled in 4. Search for an existing bib record 5. Click Edit > Edit record to open the basic editor 6. If the field from step 2 already has data, clear it 7. Switch the framework to the framework from step 2 --> Confirm that the default value is filled in 8. Clear the field again, and save the edit 9. Click Edit > Edit as new (duplicate) --> Confirm that the default value is filled in 10. Go to the cataloguing module and do a Z39.50 search 11. Find a record that does not have a value for the subfield from step 2 12. Import the record using the framework from step 2 --> Confirm that the default value is filled in -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158277|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158287&action=edit Bug 34993: Pass context parameters to generate_subfield_form Pass necessary parameters from the UI to ensure that the basic MARC editor can correctly identify when a framework is changed, a bib is being duplicated, or a bib is being imported with Z39.50 - for purposes of filling in default values according to the settings of ApplyFrameworkDefaults. To test: 1. Set the system preference ApplyFrameworkDefaults - Select All 2. Create or edit a MARC bibliographic framework with a default value in one of the fields (such as 500$a) 3. Go to the Cataloguing module and create a new record using the framework from step 2 --> Confirm that the default value is filled in 4. Search for an existing bib record 5. Click Edit > Edit record to open the basic editor 6. If the field from step 2 already has data, clear it 7. Switch the framework to the framework from step 2 --> Confirm that the default value is filled in 8. Clear the field again, and save the edit 9. Click Edit > Edit as new (duplicate) --> Confirm that the default value is filled in 10. Go to the cataloguing module and do a Z39.50 search 11. Find a record that does not have a value for the subfield from step 2 12. Import the record using the framework from step 2 --> Confirm that the default value is filled in Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please remember to run QA tests and perltidy :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158287|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158460&action=edit Bug 34993: Pass context parameters to generate_subfield_form Pass necessary parameters from the UI to ensure that the basic MARC editor can correctly identify when a framework is changed, a bib is being duplicated, or a bib is being imported with Z39.50 - for purposes of filling in default values according to the settings of ApplyFrameworkDefaults. To test: 1. Set the system preference ApplyFrameworkDefaults - Select All 2. Create or edit a MARC bibliographic framework with a default value in one of the fields (such as 500$a) 3. Go to the Cataloguing module and create a new record using the framework from step 2 --> Confirm that the default value is filled in 4. Search for an existing bib record 5. Click Edit > Edit record to open the basic editor 6. If the field from step 2 already has data, clear it 7. Switch the framework to the framework from step 2 --> Confirm that the default value is filled in 8. Clear the field again, and save the edit 9. Click Edit > Edit as new (duplicate) --> Confirm that the default value is filled in 10. Go to the cataloguing module and do a Z39.50 search 11. Find a record that does not have a value for the subfield from step 2 12. Import the record using the framework from step 2 --> Confirm that the default value is filled in Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158461&action=edit Bug 34993: (QA follow-up) Perltidy Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks a lot Emily for fixing this one! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@trust-box.at -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 --- Comment #15 from Phil Ringnalda <phil@chetcolibrary.org> --- *** Bug 35289 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 --- Comment #16 from Lauren Denny <lauren_denny@sil.org> --- Will it be backported to 22.11 or 23.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lauren Denny from comment #16)
Will it be backported to 22.11 or 23.05?
Bugs marked major that are in lower versions usually are backported. But the RMaint always makes the last decision. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.06 released in| | --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 --- Comment #19 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org