[Bug 34931] New: Collapsed Additional attributes and identifiers that contain a PA_CLASS do not display well.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Bug ID: 34931 Summary: Collapsed Additional attributes and identifiers that contain a PA_CLASS do not display well. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Create some PA_CLASS authorized values. 2. Create some custom patron attributes and add them to the newly created PA_CLASS's. 3. Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'. 4. Go to a new or existing patron record. 5. At the top of the page click the checkbox for "Show collapsed fields:". 6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Furthermore, this produces invalid HTML. If you run the outputted HTML through a validator it will tell you: fieldset not allowed as child of element ol -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 157003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157003&action=edit Bug 34931: Remove fieldset/legend in favor of div/h3 1. Create some PA_CLASS authorized values. 2. Create some custom patron attributes and add them to the newly created PA_CLASS's. 3. Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'. 4. Go to a new or existing patron record. 5. At the top of the page click the checkbox for "Show collapsed fields:". 6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS. 7. Apply patch 8. Try again, the Additional attributes and identifiers fieldset should display properly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157003|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 157562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157562&action=edit Bug 34931: Remove fieldset/legend in favor of div/h3 1. Create some PA_CLASS authorized values. 2. Create some custom patron attributes and add them to the newly created PA_CLASS's. 3. Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'. 4. Go to a new or existing patron record. 5. At the top of the page click the checkbox for "Show collapsed fields:". 6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS. 7. Apply patch 8. Try again, the Additional attributes and identifiers fieldset should display properly. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|Collapsed Additional |Collapsed additional |attributes and identifiers |attributes and identifiers |that contain a PA_CLASS do |with a PA_CLASS don't |not display well. |display well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157562|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158422&action=edit Bug 34931: Remove fieldset/legend in favor of div/h3 1. Create some PA_CLASS authorized values. 2. Create some custom patron attributes and add them to the newly created PA_CLASS's. 3. Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'. 4. Go to a new or existing patron record. 5. At the top of the page click the checkbox for "Show collapsed fields:". 6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS. 7. Apply patch 8. Try again, the Additional attributes and identifiers fieldset should display properly. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.06 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34931 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org