[Bug 31973] New: Restore background color to message-style alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 Bug ID: 31973 Summary: Restore background color to message-style alerts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 30952 We use <div class="dialog message"> for informational alerts, for instance to inform the user of some kind of successful action or to provide information. In the redesign, these .message alerts have a white background, making them hard to see and not much different than the standard page-section. I think we should restore the old background color. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142615&action=edit Bug 31973: Restore background color to message-style alerts This patch restores the background color to message-style alerts, those which use the markup <div class="dialog message">. These alerts should stand out more to the user. To test, apply the patch and rebuild the staff interface CSS. - Test areas which use the message-style dialog. Perhaps the easiest example is to try to view a bibliographic record which doesn't exist: /cgi-bin/koha/catalogue/detail.pl?biblionumber=1234567890 - It can also be found as a confirmation when deleting a basket in Acquisitions, deleting a patron attribute type in Administration, updating a Z39.50 server in Administration, etc. - Confirm that the alert looks correct and is suitable visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142615|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142656&action=edit Bug 31973: Restore background color to message-style alerts This patch restores the background color to message-style alerts, those which use the markup <div class="dialog message">. These alerts should stand out more to the user. To test, apply the patch and rebuild the staff interface CSS. - Test areas which use the message-style dialog. Perhaps the easiest example is to try to view a bibliographic record which doesn't exist: /cgi-bin/koha/catalogue/detail.pl?biblionumber=1234567890 - It can also be found as a confirmation when deleting a basket in Acquisitions, deleting a patron attribute type in Administration, updating a Z39.50 server in Administration, etc. - Confirm that the alert looks correct and is suitable visible. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 [Bug 31996] Make note-style messages consistent with dialogs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think having some notes about the different classes for those dialogs would be a great addition to the style guide in the works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is also an instance on the transport cost matrix page if you haven't turned on the system preference activating the feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142656|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142683&action=edit Bug 31973: Restore background color to message-style alerts This patch restores the background color to message-style alerts, those which use the markup <div class="dialog message">. These alerts should stand out more to the user. To test, apply the patch and rebuild the staff interface CSS. - Test areas which use the message-style dialog. Perhaps the easiest example is to try to view a bibliographic record which doesn't exist: /cgi-bin/koha/catalogue/detail.pl?biblionumber=1234567890 - It can also be found as a confirmation when deleting a basket in Acquisitions, deleting a patron attribute type in Administration, updating a Z39.50 server in Administration, etc. - Confirm that the alert looks correct and is suitable visible. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 Bug 31973 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org