[Bug 12707] New: Remove CGI::scrolling_list from some Reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 Bug ID: 12707 Summary: Remove CGI::scrolling_list from some Reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org Six files, 5 functional, one commented. Depends on Bug 12696. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30522&action=edit Bug 12707: Remove CGI::scrolling_list from some Reports This patch removes similar instances on 5 files, same code. Also removes a commented one, changed in case some plan to resurrect the code. This bug depends on Bug 12696. In all cases but the commented one, what was replaced is a pulldown with one value, 'CSV' To test: 1. Apply patch for Bug 12696 2. Apply this patch Check for the pulldown 'Into an application' 3. Go to Reports > Statistics wizard > Borrowers 4. Go to Reports > Statistics wizard > Circulation 5. Go to Reports > Statistics wizard > Holds 6. Go to Reports > Top lists > Most-circulated items 7. Go to Reports > Inactive > Patrons who haven't checked out 8. There is also a commented code on catalogue_stats, no fuctional changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Blocks| |766 Depends on| |12696 Assignee|oleonard@myacpl.org |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #2 from Marc Véron <veron@veron.ch> --- Sorry, mistaked in Bug-number. Reset to Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 30542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30542&action=edit [Signed-off] Bug 12707: Remove CGI::scrolling_list from some Reports This patch removes similar instances on 5 files, same code. Also removes a commented one, changed in case some plan to resurrect the code. This bug depends on Bug 12696. In all cases but the commented one, what was replaced is a pulldown with one value, 'CSV' To test: 1. Apply patch for Bug 12696 2. Apply this patch Check for the pulldown 'Into an application' 3. Go to Reports > Statistics wizard > Borrowers 4. Go to Reports > Statistics wizard > Circulation 5. Go to Reports > Statistics wizard > Holds 6. Go to Reports > Top lists > Most-circulated items 7. Go to Reports > Inactive > Patrons who haven't checked out 8. There is also a commented code on catalogue_stats, no fuctional changes. Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30522|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, this one is being stubborn and won't apply: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 12707: Remove CGI::scrolling_list from some Reports fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12707: Remove CGI::scrolling_list from some Reports The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Missed the dependency - going to retry a bit later. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30852&action=edit [PASSED QA] Bug 12707: Remove CGI::scrolling_list from some Reports This patch removes similar instances on 5 files, same code. Also removes a commented one, changed in case some plan to resurrect the code. This bug depends on Bug 12696. In all cases but the commented one, what was replaced is a pulldown with one value, 'CSV' To test: 1. Apply patch for Bug 12696 2. Apply this patch Check for the pulldown 'Into an application' 3. Go to Reports > Statistics wizard > Borrowers 4. Go to Reports > Statistics wizard > Circulation 5. Go to Reports > Statistics wizard > Holds 6. Go to Reports > Top lists > Most-circulated items 7. Go to Reports > Inactive > Patrons who haven't checked out 8. There is also a commented code on catalogue_stats, no fuctional changes. Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org