http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12745 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Blocks| |12742 Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12745 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 30709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30709&action=edit Bug 12745: Add a sanity check for QueryParser configuration on about.pl Currently there's no way for the user to know he has a bad QueryParser configuration. Koha would just fallback to not using it. This patch adds a check for QueryParser configuration sanity in about.pl To test: - Have UseQueryParser = "Don't try" - Go to More > About Koha > System information - No QueryParser-related warnings - Set UseQueryParser = "Try" - Go to More > About Koha > System information - On a normal setup you shouldn't have any QueryParser-related warnings - Edit your koha-conf.xml file and change the queryparser_config entry to a non-existent filename. - Reload More > About Koha > System information => SUCCESS: a warning message tells you the filename used, and says it failed. - Now just delete the entry in koha-conf.xml - Reload More > About Koha > System information => SUCCESS: a warning message tells you don't have the queryparser_entry in your koha-conf.xml file. Subtest: a - The file /etc/koha/searchengine/queryparser.yaml exists: => SUCCESS: a warning saying it used a fallback is shown b - The file doesn't exist => SUCCESS: Missing entry warning, plus a failure message for the fallback. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12745 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12745 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 30847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30847&action=edit Bug 12745: (QA followup) remove misleading 'No warnings' message Current code displays "No warnings" even if there are actually warnings printed. It is not related to the bug itself, but as it was pointed out by the QAM, I attach a followup to solve that. Regards To+ Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30714|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12745 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30848&action=edit [PASSED QA] Bug 12745: Add a sanity check for QueryParser configuration on about.pl Currently there's no way for the user to know he has a bad QueryParser configuration. Koha would just fallback to not using it. This patch adds a check for QueryParser configuration sanity in about.pl To test: - Have UseQueryParser = "Don't try" - Go to More > About Koha > System information - No QueryParser-related warnings - Set UseQueryParser = "Try" - Go to More > About Koha > System information - On a normal setup you shouldn't have any QueryParser-related warnings - Edit your koha-conf.xml file and change the queryparser_config entry to a non-existent filename. - Reload More > About Koha > System information => SUCCESS: a warning message tells you the filename used, and says it failed. - Now just delete the entry in koha-conf.xml - Reload More > About Koha > System information => SUCCESS: a warning message tells you don't have the queryparser_entry in your koha-conf.xml file. Subtest: a - The file /etc/koha/searchengine/queryparser.yaml exists: => SUCCESS: a warning saying it used a fallback is shown b - The file doesn't exist => SUCCESS: Missing entry warning, plus a failure message for the fallback. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> With the typo in the path (non existing file), 'no warnings' is stil shown below the warnings. The follow-up fixes that. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12745 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.