https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38428 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174436&action=edit Bug 38428: Use links for stock rotation action buttons This patch converts the action buttons on the stock rotation rota manage items page to be links to avoid repeating form values (CSRF tokens, etc) It moves the confirmation for removal from a rota to be a confirm and not a full page reload. It also moves the fetch of a transfer into a shared variable. Lastly, there is some chomping added to remove extra whitespace. To test: 1 - Enable SotckRotation 2 - Create a rota 3 - Add some stages 4 - Add items to the rota 5 - Test the buttons to advance stage, add 'in demand' and remove 6 - Apply patch 7 - Confirm all buttons continue to function 8 - Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38428 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174436|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 174447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174447&action=edit Bug 38428: Use links for stock rotation action buttons This patch converts the action buttons on the stock rotation rota manage items page to be links to avoid repeating form values (CSRF tokens, etc) It moves the confirmation for removal from a rota to be a confirm and not a full page reload. It also moves the fetch of a transfer into a shared variable. Lastly, there is some chomping added to remove extra whitespace. To test: 1 - Enable SotckRotation 2 - Create a rota 3 - Add some stages 4 - Add items to the rota 5 - Test the buttons to advance stage, add 'in demand' and remove 6 - Apply patch 7 - Confirm all buttons continue to function 8 - Sign off Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38428 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Wow.. thanks for this Nick.. of course prior to the CSRF stuff most of these were already just simple links. This is quit an improvement and I'd go so far as to say it's an important regression fix. Passing QA straight.. it's a simple change that works seamlessly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38428 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38428 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.