https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 --- Comment #2 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 134953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134953&action=edit Bug 30745: handle ES ranges for date of acquisition Test plan: - Enable elasticsearch - git to labels/label-item-search.pl - search using after date only => check you get items with date-of-acquisition greater than after date - search using before date only => check you get items with date-of-acquisition less than before date - search using after and before date => check you get items with date-of-acquisition between after and before - Combine this searches with a specified index - enable zebra and repeat these tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com --- Comment #3 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- For Bug 16355, the patch doesn't apply and the last comment is from 2018. I tested the patch with elasticsearch and it works for me, but I do not have a functioning zebra to test with. Do I signoff nonetheless? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134953|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 135785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135785&action=edit Bug 30745: handle ES ranges for date of acquisition Test plan: - Enable elasticsearch - git to labels/label-item-search.pl - search using after date only => check you get items with date-of-acquisition greater than after date - search using before date only => check you get items with date-of-acquisition less than before date - search using after and before date => check you get items with date-of-acquisition between after and before - Combine this searches with a specified index - enable zebra and repeat these tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135785|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 135967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135967&action=edit Bug 30745: handle ES ranges for date of acquisition Test plan: - Enable elasticsearch - git to labels/label-item-search.pl - search using after date only => check you get items with date-of-acquisition greater than after date - search using before date only => check you get items with date-of-acquisition less than before date - search using after and before date => check you get items with date-of-acquisition between after and before - Combine this searches with a specified index - enable zebra and repeat these tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=30845 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 28987 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135966|0 |1 is obsolete| | --- Comment #13 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 157192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157192&action=edit Bug 30745: Use query builder and search_compat in label-item-search Test plan: - apply this patch, - make some searches in labels/label-item-search.pl using the 3 form input (index, after date, before date), - check it works like before Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=30845 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135966|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135967|0 |1 is obsolete| | --- Comment #15 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 157195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157195&action=edit Bug 30745: handle ES ranges for date of acquisition Test plan: - Enable elasticsearch - git to labels/label-item-search.pl - search using after date only => check you get items with date-of-acquisition greater than after date - search using before date only => check you get items with date-of-acquisition less than before date - search using after and before date => check you get items with date-of-acquisition between after and before - Combine this searches with a specified index - enable zebra and repeat these tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=30845 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alex.arnaud@biblibre.com |emily-rose.francoeur@inLibr | |o.com CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #19 from David Nind <david@davidnind.com> --- I was about to sign off, but then came across this Zebra only error - I get this error after the patches are applied (and a reindex): Error: Can't use an undefined value as an ARRAY reference at /kohadevbox/koha/labels/label-item-search.pl line 88 .... 1. Generated by putting a letter in the input box for these index searches (without any dates in the filters): publication date, standard number, ISBN, ISSN, call number, acquisition date 2. I could also generate this error with a number in a text field, for example: Author index, 2011 (but with 2000 no error is generated) 3. With Elasticsearch, no results are displayed and the form just refreshes (both before and after the patches, and the same with Zebra before the patches) Other notes =========== 1. I couldn't work out how or where cgi-bin/koha/labels/label-item-search.pl is used/accessed from - something to do with acquisitions? 2. I've changed the assignee. 3. I didn't test with a UNIMARC installation. Testing notes (using koha-testing-docker) ========================================= Setup ~~~~~ To test with Elasticsearch or OpenSearch - start up KTD with Elasticsearch or OpenSearch: ktd --es8 up OR ktd --os2 up (I didn't test with Open Search, just Zebra and Elasticsearch) Go to this page in the staff interface: http://127.0.0.1:8081/cgi-bin/koha/labels/label-item-search.pl Searching using Zebra (after KTD is started with --es8): - Change the SearchEngine system preference to Zebra - Reload http://127.0.0.1:8081/cgi-bin/koha/labels/label-item-search.pl - Reindex: koha-rebuild-zebra -d -f -v kohadev - Repeat all the example searches - you should get the same results Demonstrating the issue and that the patches fix it ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Notes: In the sample data, the acquisition date is recorded in 952$d - Date acquired. For many items, 09/04/2014 is used. For some items, these dates are used 05/08/2014, 05/07/2014, 10/15/2014, 12/04/2014, 1/05/2015. Many items don't have a date recorded. If there is no value in the index field, it is ignored. If an index is selected and a value is entered, the results should be filtered by any values entered in 'Added on or after date' and 'Added on or before date' fields. Before the patches: index searches work, but when used with 'Added on or after date' and 'Added on or before date' options, the search results ignore them. However, entering a date for the 'Acquisition date' index does work. A title index search: - Title index: perl => Expected result: 11 => Actual result: 11 A combined search with dates: - Title index: perl - Added on or after date: 09/04/2014 => Expected result: 10 (1 perl record has no items) => Actual result: No results A combined search with dates: - Title index: perl - Added on or before date: 09/04/2014 => Expected result: 10 (1 perl record has no items) => Actual result: No results Acquisition date index search: - Index: select 'Acquisition date' from the dropdown list - Value to enter: 09/04/2014 => Expected result: 352 results => Actual result: 352 result Acquisition date index search: - Index: select 'Acquisition date' from the dropdown list - Value to enter: 09/04/2014 - Added on or after date: 09/04/2014 OR - Added on or before date: 09/04/2014 OR Use both or none => Expected result: 352 results => Actual result: 352 results Search using 'Added on or after date' (after date) only: - Added on or after date: 09/04/2014 => Expected result: should get 408 records => Actual result: 0 results Search using 'Added on or before date' (before date) only: - Added on or after date: 09/04/2014 => Expected result: should get 354 records => Actual result: 0 results Publication date index search using 2011 (AFTER patches are applied - doesn't work as expected BEFORE the patches are applied): - Results if no before or after filter added: 8 (as expected) - Results if Added on or after date: 09/04/2014 - 8 (as expected) - Results if Added on or before date: 09/04/2014 - 7 (as expected) - Results for a date range - 7 (as expected): . Added on or after date: 09/04/2014 . Added on or before date: 09/05/2014 - Results for a date range - 8 (as expected): . Added on or after date: 09/04/2014 . Added on or before date: 10/15/2014 - Results for a date range - 1 (as expected): . Added on or after date: 09/05/2014 . Added on or before date: 10/15/2014 (One record and all its items has acquisition dates of 10/15/2014 - Blackstone's statutes on company law 2014-2015; the rest have 09/04/2014 acquisition dates) Search using just a date range (and no index) (AFTER patches are applied - doesn't work as expected BEFORE the patches are applied): - Added on or after date: 09/04/2014 => should get 408 results - Added on or before date: 09/03/2014 => should get 3 results - Added on or before date: today's date => should get 410 results (note: 408 + 3 doesn't equal 410 but it is correct, as one record has items with different acquisition dates: The C programming language has items with different acquisition dates - 1 x 09/04/2014 and 3 x 05/08/2014) - Added on or after date: 09/05/2014 => should get 56 results - Added on or after date: 12/04/2014 => should get 40 results - Added on or after date: 09/05/2014 - Added on or before date: 12/03/2014 => should get 16 records Pagination of search results ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1. Perform a search that returns more than 20 results - for example Title index, a: 2. Navigate through different result page navigation using page numbers, the "Next" button, and the "Previous" button => On each page, check that "Results X through X of X" displays the correct information - 20 results are displayed for each page - the total number of results should not change -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Phan Tung Bui <phan-tung.bui@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from David Nind <david@davidnind.com> --- Thanks for fixing the error identified in the previous testing. This no longer occurs (using Zebra and putting a letter in number index fields such as ISBN, Publication date, and so on). However, for: 1. Search results: the pagination is no longer working - it just goes back to the search form if you click on next or any of the numbers. There are some console errors on the search results page (using the web developer tools) 2. The select all and clear all links no longer work -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Phan Tung Bui <phan-tung.bui@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #24 from David Cook <dcook@prosentient.com.au> --- We've bumped into this issue, so I will be looking at this more. -- Note for testing: 1. Go to /cgi-bin/koha/labels/label-edit-batch.pl?op=new 2. Click "Add item(s)" 3. In the pop-up window, click the date picker next to "Added on or before date:" and choose today's date 4. Click "Search" button -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24895 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 --- Comment #27 from Fridolin Somers <fridolin.somers@biblibre.com> --- Thanks all for keeping this alive ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 --- Comment #28 from David Cook <dcook@prosentient.com.au> --- Note that the paging is broken due to CSRF stuff in master as well. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 --- Comment #30 from David Cook <dcook@prosentient.com.au> --- So... my workaround works and is considerably less scary: my $search_engine = C4::Context->preference('SearchEngine'); my $is_elasticsearch = 1 if $search_engine && $search_engine eq 'Elasticsearch'; $idx = $query->param('idx'); $ccl_textbox = $query->param('ccl_textbox'); if ( $ccl_textbox && $idx ) { $ccl_query = "$idx:$ccl_textbox"; } $datefrom = $query->param('datefrom'); $dateto = $query->param('dateto'); if ($datefrom) { $ccl_query .= ' AND ' if $ccl_textbox; if ($is_elasticsearch){ $ccl_query .= "acqdate:>" . $datefrom; } else { $ccl_query .= "acqdate,ge,st-date-normalized=" . $datefrom; } } if ($dateto) { $ccl_query .= ' AND ' if ( $ccl_textbox || $datefrom ); if ($is_elasticsearch){ $ccl_query .= "acqdate:<" . $dateto; } else { $ccl_query .= "acqdate,le,st-date-normalized=" . $dateto; } } -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36931 [Bug 36931] label-item-search.pl paging doesn't work (due to CSRF changes) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 kamilzade.toghrul@yahoo.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kamilzade.toghrul@yahoo.com --- Comment #33 from kamilzade.toghrul@yahoo.com --- Hello. Can anyone fixed this issue? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Bug 30745 depends on bug 36931, which changed state. Bug 36931 Summary: label-item-search.pl paging doesn't work (due to CSRF changes) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36931 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157195|0 |1 is obsolete| | --- Comment #36 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170678&action=edit Bug 30745: handle ES ranges for date of acquisition Test plan: - Enable elasticsearch - git to labels/label-item-search.pl - search using after date only => check you get items with date-of-acquisition greater than after date - search using before date only => check you get items with date-of-acquisition less than before date - search using after and before date => check you get items with date-of-acquisition between after and before - Combine this searches with a specified index - enable zebra and repeat these tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=30845 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 --- Comment #38 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170680&action=edit Bug 30745 : Fix error 500 when item is not found while using zebra Plan test : - Apply this batch - Set Zebra as searchEngine - Go to Cataloging -> # Label creator - Click on New, Select Label batch - Click on Add item(s) - Search for for inexisting items => The page should refresh itself (so that it has the same behavior as elasticSearch) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170678|0 |1 is obsolete| | --- Comment #40 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170682&action=edit Bug 30745: handle ES ranges for date of acquisition Test plan: - Enable elasticsearch - git to labels/label-item-search.pl - search using after date only => check you get items with date-of-acquisition greater than after date - search using before date only => check you get items with date-of-acquisition less than before date - search using after and before date => check you get items with date-of-acquisition between after and before - Combine this searches with a specified index - enable zebra and repeat these tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=30845 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 --- Comment #42 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170684&action=edit Bug 30745: Fix error 500 when item is not found while using zebra Plan test : - Apply this batch - Set Zebra as searchEngine - Go to Cataloging -> # Label creator - Click on New, Select Label batch - Click on Add item(s) - Search for for inexisting items => The page should refresh itself (so that it has the same behavior as elasticSearch) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 --- Comment #43 from Hammat wele <hammat.wele@inlibro.com> --- (In reply to David Nind from comment #21)

However, for:

1. Search results: the pagination is no longer working - it just goes back to the search form if you click on next or any of the numbers. There are some console errors on the search results page (using the web developer tools)

2. The select all and clear all links no longer work

There are some console errors because we are not supposed to access labels/label-item-search.pl directly from the url, the test plan is not correct we should go to Cataloging -> # Label creator -> Click on New -> Select Label batch then Click on Add item(s) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching |Searching - Elasticsearch Summary|ES : Search never return |Elasticsearch: Search never |result using after-date |returns with after-date |and/or before-date in |and/or before-date in label |labels/label-item-search.pl |batch item search -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170682|0 |1 is obsolete| | --- Comment #46 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170730&action=edit Bug 30745: handle ES ranges for date of acquisition Test plan: - Enable elasticsearch - git to labels/label-item-search.pl - search using after date only => check you get items with date-of-acquisition greater than after date - search using before date only => check you get items with date-of-acquisition less than before date - search using after and before date => check you get items with date-of-acquisition between after and before - Combine this searches with a specified index - enable zebra and repeat these tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=30845 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170684|0 |1 is obsolete| | --- Comment #48 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170732&action=edit Bug 30745: Fix error 500 when item is not found while using zebra Plan test : - Apply this batch - Set Zebra as searchEngine - Go to Cataloging -> # Label creator - Click on New, Select Label batch - Click on Add item(s) - Search for for inexisting items => The page should refresh itself (so that it has the same behavior as elasticSearch) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170730|0 |1 is obsolete| | --- Comment #51 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 171003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171003&action=edit Bug 30745: handle ES ranges for date of acquisition Test plan: - Enable elasticsearch - git to labels/label-item-search.pl - search using after date only => check you get items with date-of-acquisition greater than after date - search using before date only => check you get items with date-of-acquisition less than before date - search using after and before date => check you get items with date-of-acquisition between after and before - Combine this searches with a specified index - enable zebra and repeat these tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=30845 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170732|0 |1 is obsolete| | --- Comment #53 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 171005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171005&action=edit Bug 30745: Fix error 500 when item is not found while using zebra Plan test : - Apply this batch - Set Zebra as searchEngine - Go to Cataloging -> # Label creator - Click on New, Select Label batch - Click on Add item(s) - Search for for inexisting items => The page should refresh itself (so that it has the same behavior as elasticSearch) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Olivier Vezina <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ovezina@inlibro.com --- Comment #55 from Olivier Vezina <ovezina@inlibro.com> --- The patch says it as a conflict, but i can't seem to be able to find any conflict for the patch "adding some handling for st-date-normalized", i'm not sure if its just my installation or if the patch will need to be rewritten and pushed again -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 --- Comment #57 from Blou <philippe.blouin@inlibro.com> --- Olivier needs to read the error output :-) He gets the dreaded SHA1. He'll rewrite the patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Olivier Vezina <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171006|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171002|0 |1 is obsolete| | --- Comment #59 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 173943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173943&action=edit Bug 30745: Use query builder and search_compat in label-item-search Test plan: - apply this patch, - make some searches in labels/label-item-search.pl using the 3 form input (index, after date, before date), - check it works like before Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=30845 Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171004|0 |1 is obsolete| | --- Comment #61 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 173945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173945&action=edit Bug 30745: Display pagination for the results page I have fixed the pagination issue when the search returns multiple results. Test plan: - Enable elasticsearch - git to labels/label-item-search.pl - search using after date only => check you get items with date-of-acquisition greater than after date - search using before date only => check you get items with date-of-acquisition less than before date - search using after and before date => check you get items with date-of-acquisition between after and before - Combine this searches with a specified index - enable zebra and repeat these tests pagination tests - Perform a search that returns more than 20 notices - Navigate through different result pages using page numbers, the "Next" button, and the "Previous" button => On each page, check that "Results X through X of X" displays the correct information Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173280|0 |1 is obsolete| | --- Comment #63 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 173947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173947&action=edit Bug 30745: (follow-up) Rewritting the st-date-normalized test The patch was corrupted, and was rewritten as the original one by Hammat Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 --- Comment #65 from David Cook <dcook@prosentient.com.au> --- I'm not super happy with the way the changes have been implemented to label-item-search.pl, but I can confirm that it appears to work, and that's the key thing. I'd say that's good enough. Since label-item-search.pl is a fairly isolated and niche script, I'm not fussed. I'm going to just double-check the QueryBuilder stuff a bit more... I'm also noticing the following warnings with the QA tools: WARN Koha/SearchEngine/Elasticsearch/QueryBuilder.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 315, now: 322) OK koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt WARN labels/label-item-search.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 53, now: 63) WARN t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t WARN tidiness The file is less tidy than before (bad/messy lines before: 326, now: 336) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173943|0 |1 is obsolete| | --- Comment #67 from David Cook <dcook@prosentient.com.au> --- Created attachment 174486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174486&action=edit Bug 30745: Use query builder and search_compat in label-item-search Test plan: - apply this patch, - make some searches in labels/label-item-search.pl using the 3 form input (index, after date, before date), - check it works like before Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=30845 Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173945|0 |1 is obsolete| | --- Comment #69 from David Cook <dcook@prosentient.com.au> --- Created attachment 174488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174488&action=edit Bug 30745: Display pagination for the results page I have fixed the pagination issue when the search returns multiple results. Test plan: - Enable elasticsearch - git to labels/label-item-search.pl - search using after date only => check you get items with date-of-acquisition greater than after date - search using before date only => check you get items with date-of-acquisition less than before date - search using after and before date => check you get items with date-of-acquisition between after and before - Combine this searches with a specified index - enable zebra and repeat these tests pagination tests - Perform a search that returns more than 20 notices - Navigate through different result pages using page numbers, the "Next" button, and the "Previous" button => On each page, check that "Results X through X of X" displays the correct information Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173947|0 |1 is obsolete| | --- Comment #71 from David Cook <dcook@prosentient.com.au> --- Created attachment 174490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174490&action=edit Bug 30745: (follow-up) Rewritting the st-date-normalized test The patch was corrupted, and was rewritten as the original one by Hammat Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|emily-rose.francoeur@inLibr |eric.begin@inLibro.com |o.com, | |phan-tung.bui@inlibro.com | -- You are receiving this mail because: You are watching all bug changes.