[Bug 9586] New: Remove $ENV{DEBUG} info from Member Template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 Bug ID: 9586 Summary: Remove $ENV{DEBUG} info from Member Template Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au Currently, if $ENV{DEBUG} is set (for example to 1), the debug level will be printed on the Add/Edit Patron pages (memberentrygen.tt) in the form of: "Debug is on (level 1)". While many if not most folks might not set $ENV{DEBUG} on a production system, there is no reason to have this information printing on the member template(s). No where else in Koha is there a template that prints $ENV{DEBUG} information, with the exception of calendar.inc, although that doesn't activate until at least debug level 2 or 5, so it might be worth holding on to. It is certainly more complicated than simply printing the debug level. I don't do development on the calendars, so I'm not going to address that one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 15216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15216&action=edit Bug 9586 - Remove $ENV{DEBUG} info from Member Template Test Plan: Before applying patch... 1) Modify koha-httpd.conf, and add the following line, in the virtualhost (if it does not already exist): SetEnv DEBUG 1 2) Restart/reload Apache 3) Go to Add a New Patron 4) Note that the message "Debug is on (level 1)" appears at the top of the page above the patron entry form After applying patch... 5) Reload the patron add/edit page 6) Note that the message "Debug is on (level 1)" no longer appears 7) Change your koha-httpd.conf settings back as necessary... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15216|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15351&action=edit Bug 9586 - Remove $ENV{DEBUG} info from Member Template Currently, if $ENV{DEBUG} is set (for example to 1), the debug level will be printed on the Add/Edit Patron pages (memberentrygen.tt) in the form of: "Debug is on (level 1)". While many if not most folks might not set $ENV{DEBUG} on a production system, there is no reason to have this information printing on the member template(s). No where else in Koha is there a template that prints $ENV{DEBUG} information, with the exception of calendar.inc, although that doesn't activate until at least debug level 2 or 5, so it might be worth holding on to. It is certainly more complicated than simply printing the debug level. I don't do development on the calendars, so I'm not going to address that one. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 --- Comment #3 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 15894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15894&action=edit Bug 9586 - Remove $ENV{DEBUG} info from Member Template Currently, if $ENV{DEBUG} is set (for example to 1), the debug level will be printed on the Add/Edit Patron pages (memberentrygen.tt) in the form of: "Debug is on (level 1)". While many if not most folks might not set $ENV{DEBUG} on a production system, there is no reason to have this information printing on the member template(s). No where else in Koha is there a template that prints $ENV{DEBUG} information, with the exception of calendar.inc, although that doesn't activate until at least debug level 2 or 5, so it might be worth holding on to. It is certainly more complicated than simply printing the debug level. I don't do development on the calendars, so I'm not going to address that one. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Elliott Davis <elliott@bywatersolions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |elliott@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15351|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org