http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9620 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |major --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The problem is, that only sometimes the ISBN will falsely match an authority record. So the problem is a bit hard to reproduce this way, as I have not found out how to make sure that ISBN and Koha's authority number match. We had this occuring twice for a dataset of about 50.000 records. So this is a sure way to reproduce the problem: 1) Change your frameworks: * Make sure 084 $a is visible * Create a 084 $9 that you link to PERSO_NAME authorities. 2) Create a record or edit an existing one: * Use the plugin on 084 to link the record to an authority. * Make sure 400 is filled in your authority record. Preparations all done, now test indexing: 1) Make sure IncludeSeeFromInSearches is OFF

Reindexing should work without any problems.

2) Activate IncludeSeeFromInSearches

Reindexing should throw an error and stop: 201.Subfields are only for data fields (generally, just tags >= 010 at /home/koha/Koha/Filter/MARC/EmbedSee FromHEadings.pm line 94

So what happened: The system found the $9, found the matching authority, found the 400, wanted to add the content of 400 to the bibliographic record for indexing, constructed a field that was below >010 to store the data in - and exploded. Because controlfields have no subfields. (Naturally) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9620 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15382&action=edit Bug 9620: IncludeSeeFromInSearches and date in $9 subfields can break indexing In Germany 020$9 is used to store the ISBN with hyphens. In rare cases this can break indexing in combination with IncludeSeeFromInSearches. To reproduce: 1) Change your frameworks: * Make sure 084 $a is visible * Create a 084 $9 that you link to PERSO_NAME authorities. 2) Create a record or edit an existing one: * Use the plugin on 084 to link the record to an authority. * Make sure 400 is filled in your authority record. Preparations all done, now test indexing: 3) Make sure IncludeSeeFromInSearches is OFF * Reindexing should work without any problems. 4) Activate IncludeSeeFromInSearches * Reindexing should throw an error and stop: 201.Subfields are only for data fields (generally, just tags >= 010 at /home/koha/Koha/Filter/MARC/EmbedSee FromHEadings.pm line 94 5) Apply patch and reindex. * No error should occur. * Test 4xx fields from other tags were properly indexed. What causes the problem is the fact, that Koha tries to store the date from the 400 in the bibliographic record for indexing. For this it calculates a tag in the bibliographic record from the tag it found the authority link in and the 4xx tags used in the authority record. If you have an authority linked to a 0xx field and the matching authority has a 4xx where xx < 10, the calculated tag will be a control field. The attempt to add subfields to this control field, is causing the error and breaks the indexing process. So what happened: The system found the $9, found the matching authority, found the 400, wanted to add the content of 400 to the bibliographic record for indexing, constructed a field that was below >010 to store the data in - and exploded. Because controlfields have no subfields. (Naturally) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9620 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9620 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9620 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15422|0 |1 is obsolete| | --- Comment #5 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 15924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15924&action=edit Bug 9620: IncludeSeeFromInSearches and date in $9 subfields can break indexing In Germany 020$9 is used to store the ISBN with hyphens. In rare cases this can break indexing in combination with IncludeSeeFromInSearches. To reproduce: 1) Change your frameworks: * Make sure 084 $a is visible * Create a 084 $9 that you link to PERSO_NAME authorities. 2) Create a record or edit an existing one: * Use the plugin on 084 to link the record to an authority. * Make sure 400 is filled in your authority record. Preparations all done, now test indexing: 3) Make sure IncludeSeeFromInSearches is OFF * Reindexing should work without any problems. 4) Activate IncludeSeeFromInSearches * Reindexing should throw an error and stop: 201.Subfields are only for data fields (generally, just tags >= 010 at /home/koha/Koha/Filter/MARC/EmbedSee FromHEadings.pm line 94 5) Apply patch and reindex. * No error should occur. * Test 4xx fields from other tags were properly indexed. What causes the problem is the fact, that Koha tries to store the date from the 400 in the bibliographic record for indexing. For this it calculates a tag in the bibliographic record from the tag it found the authority link in and the 4xx tags used in the authority record. If you have an authority linked to a 0xx field and the matching authority has a 4xx where xx < 10, the calculated tag will be a control field. The attempt to add subfields to this control field, is causing the error and breaks the indexing process. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, and is a long description :) Test: 1) Enabled 084 (all subfields visible), added 084_9 (missing from default framework) linked to PERSO_NAME 2) Edited authority record and added some data to 400 3) Edited bib record, linked 084 to previous auth record 4) With IncludeSeeFromInSearches OFF, re-index without problem 5) With IncludeSeeFromInSearches ON, re-index problems!!! ==================== exporting biblio ==================== 1...Subfields are only for data fields (generally, just tags >= 010) at... Abort 6) Applied patch 7) With IncludeSeeFromInSearches ON, re-index without problem ... ==================== 5001.................................................................................................... Records exported: 5060 ==================== ... ==================== 2001.................................................................................................... Records exported: 2024 ==================== CLEANING ==================== Good! *) That's "works as described", don't know if other tests are needed. No errors from koha-qa Signed-off-by: Elliott Davis <elliott@bywatersolions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9620 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.4 -- You are receiving this mail because: You are watching all bug changes.