[Bug 4510] New: acq/supplier.pl mistaken about return from GetBooksellerById
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4510 Summary: acq/supplier.pl mistaken about return from GetBooksellerById Product: Koha Version: HEAD Platform: PC OS/Version: Windows NT Status: NEW Severity: enhancement Priority: P5 Component: About AssignedTo: nengard@gmail.com ReportedBy: colin.campbell@ptfs-europe.com Estimated Hours: 0.0 Change sponsored?: --- Script written as though GetBooksellerFromId returns an array. It doesn't it returns a hashref. Let's make life for future maintainers easy and make the code say what it does -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4510 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nengard@gmail.com |colin.campbell@ptfs- | |europe.com Severity|enhancement |normal Component|About |Acquisitions Priority|P5 |PATCH-Sent --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-05-15 14:17:11 --- Patch sent. Also removes some rather confused code in what should be a simple routine. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4510 --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-05-18 10:48:33 --- Created an attachment (id=1908) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1908) Proposed Patch NB Patch explicitly calls GetContract from C4::Contract as C4::Acquisition also included a GetContract routine. The Use statements explicitly name the routines pulled in from Contract and Acquisition otherwise you get compile time errors -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4510 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1908 is|0 |1 obsolete| | --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-05-19 17:40:16 --- Created an attachment (id=1922) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1922) improved patch Merging some fixes from developments elsewhere made me see that the patch could be improved, leaving supplier.pl in a cleaner, more maintainable state, I hope. The cleaner currency loop also has all the html removed from it -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com