[Bug 4532] New: Use include file for bibliodefaultview logic
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4532 Summary: Use include file for bibliodefaultview logic Product: Koha Version: HEAD Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org Estimated Hours: 0.0 Change sponsored?: --- The BiblioDefaultView and IntranetBiblioDefaultView preferences control which view should be used when the user clicks a link to a bibliographic record. Currently the logic for choosing this view is most often done in the template: <!-- TMPL_IF name="BiblioDefaultViewmarc" --> <a class="title" href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber" ESCAPE="URL" -->"> <!-- TMPL_ELSIF NAME="BiblioDefaultViewlabeled_marc" --> <a class="title" href="/cgi-bin/koha/catalogue/labeledMARCdetail.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber" ESCAPE="URL" -->"> <!-- TMPL_ELSIF NAME="BiblioDefaultViewisbd" --> <a class="title" href="/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber" ESCAPE="URL" -->"> <!-- TMPL_ELSE --> <a class="title" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber" ESCAPE="URL" -->"> <!-- /TMPL_IF --> This block of markup should be moved to an include file to simplify the process of building the templates. Existing templates should be updated to use this include. This should also simplify the process of updating templates which do not currently respect the default view preference. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4532 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2010-05-19 16:09:09 --- Created an attachment (id=1921) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1921) Proposed fix Note that this new include builds only the first half of the anchor tag (<a>). Because title and subtitle are output differently on some pages, rendering of the second half of the tag is left to individual pages. Includes fixes for staff client templates. Change to basket.pl fixes a bug wherein the OPAC's bibliodefaultview preference was being checked instead of the staff client's. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon@kohaorg.ec2.liblime.com