[Bug 18277] New: Koha::Biblio - Remove GetBiblionumberFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Bug ID: 18277 Summary: Koha::Biblio - Remove GetBiblionumberFromItemnumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61127&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - Easy ones To retrieve a biblionumber from an itemnumber, we can use: Koha::Item->biblio->biblionumber This is only what this patchset does. Doing that we will be able to get rid of the C4::Biblio::GetBiblionumberFromItemnumber subroutine. Test plan: - Acquisition module: cancel a receipt - Export a record to CSV - Modify items in a batch Item's info should be correct Other changes with be checked by QA team, by reading the code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61128&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem Test plan: Enable EasyAnalyticalRecords and link an item to another one (Edit > link to host item) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61129&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - create_analytical_rel.pl I have no idea how to test this patch, see bug 5528, or simply read the code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61130&action=edit Bug 18277: Remove the C4::Biblio::GetBiblionumberFromItemnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61127|0 |1 is obsolete| | Attachment #61128|0 |1 is obsolete| | Attachment #61129|0 |1 is obsolete| | Attachment #61130|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63301&action=edit [SIGNED-OFF] Bug 18277: Remove GetBiblionumberFromItemnumber - Easy ones To retrieve a biblionumber from an itemnumber, we can use: Koha::Item->biblio->biblionumber This is only what this patchset does. Doing that we will be able to get rid of the C4::Biblio::GetBiblionumberFromItemnumber subroutine. Test plan: - Acquisition module: cancel a receipt - Export a record to CSV - Modify items in a batch Item's info should be correct Other changes with be checked by QA team, by reading the code. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63302&action=edit [SIGNED-OFF] Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem Test plan: Enable EasyAnalyticalRecords and link an item to another one (Edit > link to host item) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63303&action=edit [SIGNED-OFF] Bug 18277: Remove GetBiblionumberFromItemnumber - create_analytical_rel.pl I have no idea how to test this patch, see bug 5528, or simply read the code. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63304&action=edit [SIGNED-OFF] Bug 18277: Remove the C4::Biblio::GetBiblionumberFromItemnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63301|0 |1 is obsolete| | Attachment #63302|0 |1 is obsolete| | Attachment #63303|0 |1 is obsolete| | Attachment #63304|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64819&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - Easy ones To retrieve a biblionumber from an itemnumber, we can use: Koha::Item->biblio->biblionumber This is only what this patchset does. Doing that we will be able to get rid of the C4::Biblio::GetBiblionumberFromItemnumber subroutine. Test plan: - Acquisition module: cancel a receipt - Export a record to CSV - Modify items in a batch Item's info should be correct Other changes with be checked by QA team, by reading the code. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64820&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem Test plan: Enable EasyAnalyticalRecords and link an item to another one (Edit > link to host item) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64821&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - create_analytical_rel.pl I have no idea how to test this patch, see bug 5528, or simply read the code. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64822&action=edit Bug 18277: Remove the C4::Biblio::GetBiblionumberFromItemnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches have been rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 [Bug 18260] Koha::Biblio - Remove GetBiblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64819|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64892&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - Easy ones To retrieve a biblionumber from an itemnumber, we can use: Koha::Item->biblio->biblionumber This is only what this patchset does. Doing that we will be able to get rid of the C4::Biblio::GetBiblionumberFromItemnumber subroutine. Test plan: - Acquisition module: cancel a receipt - Export a record to CSV - Modify items in a batch Item's info should be correct Other changes with be checked by QA team, by reading the code. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64820|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64893&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem Test plan: Enable EasyAnalyticalRecords and link an item to another one (Edit > link to host item) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64821|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64894&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - create_analytical_rel.pl I have no idea how to test this patch, see bug 5528, or simply read the code. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64822|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64895&action=edit Bug 18277: Remove the C4::Biblio::GetBiblionumberFromItemnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64896&action=edit Bug 18277: [QA Follow-up] Additional polishing Fix POD error in Biblio.pm, as reported by qa tools: Apparent command =cut not preceded by blank line Resolve crash in t/db_dependent/Items/DelItem.t: Can't call method "biblio" on an undefined value at C4/Items.pm line 669. Add find test in tools/batchMod.pl. Increase readability of map statement. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Bug 18277 depends on bug 18276, which changed state. Bug 18276 Summary: Koha::Biblio - Remove GetBiblioFromItemNumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |RESOLVED --- Comment #21 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org