[Bug 9238] New: fund pull down says 'select budget'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Bug ID: 9238 Summary: fund pull down says 'select budget' Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com When you're ordering it says 'Fund:' and has a pull down to the right of it that says 'select budget' but really you're selecting a fund. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20312&action=edit Bug 9238 - fund pull down says 'select budget' When adding a new order to a basket the fund selection field is labeled "Fund:" but the default option is "Select a budget." This patch changes this string to "Select a fund" and also corrects the associated JavaScript error message text displayed when one doesn't choose a fund. To test, add an order to basket. The "New order" form should show "Select a fund" as the default option for "Fund" in the "Accounting details" section. If you submit the form without selecting a fund the error message should read "You must select a fund." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20312|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 20319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20319&action=edit [SIGNED-OFF] Bug 9238 - fund pull down says 'select budget' When adding a new order to a basket the fund selection field is labeled "Fund:" but the default option is "Select a budget." This patch changes this string to "Select a fund" and also corrects the associated JavaScript error message text displayed when one doesn't choose a fund. To test, add an order to basket. The "New order" form should show "Select a fund" as the default option for "Fund" in the "Accounting details" section. If you submit the form without selecting a fund the error message should read "You must select a fund." Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> tests pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20319|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20426&action=edit Bug 9238 - fund pull down says 'select budget' When adding a new order to a basket the fund selection field is labeled "Fund:" but the default option is "Select a budget." This patch changes this string to "Select a fund" and also corrects the associated JavaScript error message text displayed when one doesn't choose a fund. To test, add an order to basket. The "New order" form should show "Select a fund" as the default option for "Fund" in the "Accounting details" section. If you submit the form without selecting a fund the error message should read "You must select a fund." Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> tests pass Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> String updates only, passes koha-qa.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9238 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org