[Bug 10686] New: Fielded searches confuse highlighter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Bug ID: 10686 Summary: Fielded searches confuse highlighter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: jcamins@cpbibliography.com Reporter: jcamins@cpbibliography.com QA Contact: testopia@bugs.koha-community.org If you do a fielded search like au:smith, "Smith" will not get highlighted on the results page because the Javascript is looking for the exact string "au:smith" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 20119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20119&action=edit Bug 10686: Remove fields from searches for highlighting If you do a fielded search like au:smith, "Smith" will not get highlighted on the results page because the Javascript is looking for the exact string "au:smith." To test: 1) Turn on OpacHighlightedWords. 2) Do a simple keyword search. 3) Confirm that the word is highlighted on the results and details page. 4) Do a fielded search by entering au:smith (or whatever). 5) Confirm that the word is highlighted on the results and details page. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20119|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 20192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20192&action=edit Bug 10686: Remove fields from searches for highlighting If you do a fielded search like au:smith, "Smith" will not get highlighted on the results page because the Javascript is looking for the exact string "au:smith." To test: 1) Turn on OpacHighlightedWords. 2) Do a simple keyword search. 3) Confirm that the word is highlighted on the results and details page. 4) Do a fielded search by entering au:smith (or whatever). 5) Confirm that the word is highlighted on the results and details page. 6) Sign off. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20192|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20404&action=edit Bug 10686: Remove fields from searches for highlighting If you do a fielded search like au:smith, "Smith" will not get highlighted on the results page because the Javascript is looking for the exact string "au:smith." To test: 1) Turn on OpacHighlightedWords. 2) Do a simple keyword search. 3) Confirm that the word is highlighted on the results and details page. 4) Do a fielded search by entering au:smith (or whatever). 5) Confirm that the word is highlighted on the results and details page. 6) Sign off. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jared! Not quite bulletproof yet, though (not that I think it will *ever* be completely) -- consider ti,wrdl:history -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Jared! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org