[Bug 7350] New: In New order the "+" button duplicates input text but not the "selected" in ddl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 Bug #: 7350 Summary: In New order the "+" button duplicates input text but not the "selected" in ddl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: P3 Component: Acquisitions AssignedTo: christophe.croullebois@biblibre.com ReportedBy: christophe.croullebois@biblibre.com QAContact: ian.walls@bywatersolutions.com All in the title... Due to CloneNode limitation in additem.js. cloneNode() does not preserve select box selections... I have made a little function that paste the selected in the clone. Patch follows. Thx for testing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-12-13 10:36:05 UTC --- Created attachment 6743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6743 new proposed patch easy to test... thx -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 Duncan <duncan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6743|0 |1 is obsolete| | --- Comment #2 from Duncan <duncan@catalyst.net.nz> 2011-12-13 21:33:32 UTC --- Created attachment 6762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6762 Signed off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 Duncan <duncan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |duncan@catalyst.net.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|ian.walls@bywatersolutions. |m.de.rooy@rijksmuseum.nl |com | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-11 12:27:48 UTC --- This report misses information to test it well. You say "all is in the title" but that is not sufficient. Please tell which + do you actually mean? Where? Under which conditions (syspref values..) can it be tested? I suppose that value of AcqCreateItem for instance is relevant. In order to test a report, we should not grep Koha code in order to see where the javascript you change, is called, etc. Setting status to Failed QA. Please include more information first. Thanks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 --- Comment #4 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-01-15 13:49:05 UTC --- Hello M. de Rooy, sorry... So I join you two snapshots. Koha is moving so kickly, no more "+" but now we have "Add"... So step by step : 1° You create a basket in acqui or you use an active one, no matter. 2° After you choose Add Order To Basket, new, from..., no matter. 3° You fill in "Item" block, all the Drop Down Lists, don't choose the first value. 4° You want a second item, so you clone it with "Add", and as you are lazy, you expect that all your choices will be kept... :o( Only the imput text are kept. Regards -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 --- Comment #5 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-01-15 13:51:31 UTC --- Created attachment 7160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7160 to clone -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 --- Comment #6 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-01-15 13:53:30 UTC --- Created attachment 7161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7161 ddl are not duplicated -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7160|0 |1 is obsolete| | --- Comment #7 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-01-15 13:54:44 UTC --- Created attachment 7162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7162 to clone -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-16 11:25:52 UTC --- Thanks for clarifying. Please note that your patch only is relevant when AcqCreateItem is set to "When ordering". (And some people may not exactly have your pref values ;) When I haved added one item, your patch copies the values of the combo boxes in the new item. So that is OK. But when I want to add another item by clicking the second Add button, nothing seems to happen? Could you verify please? Note that this may probably be not related to your code, but if we change this code and could resolve this too, that would be great.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 --- Comment #9 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-01-16 12:45:27 UTC --- Hello M. de Rooy, thx, oups, you'r right, we need "AcqCreateItem" to test... For the second clone failure, I 'll see, I think too, even if it is not due to my patch it would be better to solve with it. So I'll propose a new patch with the correction about this problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 --- Comment #10 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-01-28 16:01:28 UTC --- Hello M. de Rooy, I have tested as you said, but can't reproduce the bug. I join two snapshots, for me it's ok, the third clone herits of its parent's content, and of course the link "add" is active for me. I have no idea why it's not the same for you. Another test ? thx -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 --- Comment #11 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-01-28 16:03:08 UTC --- Created attachment 7375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7375 2 clones plus changes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 --- Comment #12 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-01-28 16:03:50 UTC --- Created attachment 7376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7376 3 clones -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-30 08:23:08 UTC --- hmm..cannot reproduce it either? anymore (current master)? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-30 08:25:27 UTC --- QA Comment: Code looks good. Marking as Passed QA. Relevance depends on value of AcqCreateItem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-30 21:22:04 UTC --- This patch has been pushed, I also tested with AcqCreateItem=recieve, it works well -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org