[Bug 7342] New: aqbudgets statistics doesn't work when using Authorized values on sort1_authcat or sort2_authcat
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 Bug #: 7342 Summary: aqbudgets statistics doesn't work when using Authorized values on sort1_authcat or sort2_authcat Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: alex.arnaud@biblibre.com QAContact: ian.walls@bywatersolutions.com 2 problems when using Authorized values to fill statisctic 1 or statistic 2 in neworderempty: 1) Values selected in the drop-down list are not saved in database (aqorder.sort1, aqorder.sort2). Create a new order (neworderempty.pl), select something in the statistic 1 and statistic 2 drop-down list at the bottom and save. So sort1 and sort2 columns for the related record in aqorder table is empty. 2) When i change the value in fund drop-down list, statistic 1 and 2 are empty. On the same page, change the value of fund list. So statistic 1 and 2 are empty. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high AssignedTo|henridamien@koha-fr.org |alex.arnaud@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> 2011-12-09 08:36:51 UTC --- Created attachment 6691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6691 Creating new order -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 --- Comment #2 from Alex Arnaud <alex.arnaud@biblibre.com> 2011-12-09 08:37:27 UTC --- Created attachment 6692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6692 Changing fund in new order -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> 2011-12-09 08:38:24 UTC --- patch is coming soon -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> 2011-12-09 09:47:26 UTC --- Created attachment 6693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6693 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-10 09:18:24 UTC --- Hi Alex A little thing is this patch, that will cause the tests to fail, is the address for the FSF is wrong It is # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. (check mainpage.pl in master). I wont fail QA it for that, but it will need either a follow up or Paul to fix when he pushes it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-10 09:24:23 UTC --- Created attachment 6696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6696 Bug 7342: Follow up fixing FSF address and adding use warnings -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 --- Comment #7 from Francois Charbonnier <francois.charbonnier@biblibre.com> 2011-12-13 16:09:34 UTC --- Created attachment 6753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6753 [SIGNED-OFF] bug 7342 - neworderempty: Fix empty values in statistic 1 and 2 dropboxes Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 --- Comment #8 from Francois Charbonnier <francois.charbonnier@biblibre.com> 2011-12-13 16:10:58 UTC --- Created attachment 6754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6754 [SIGNED-OFF] Bug 7342: Follow up fixing FSF address and adding use warnings Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 Francois Charbonnier <francois.charbonnier@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6693|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 Francois Charbonnier <francois.charbonnier@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6696|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 Francois Charbonnier <francois.charbonnier@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@biblib | |re.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 --- Comment #9 from Francois Charbonnier <francois.charbonnier@biblibre.com> 2011-12-13 16:25:14 UTC --- Test I did : 1/ define authorised values categories that you will use to set up funds. 2/ then set up (at least) 2 funds and choose the categories define above within "Statistic 1 done on:" and "Statistic 2 done on:" fields 3/ create new basket and place one order 4/ when placing the order : choose the funds you created and check that the authorised values within "statistic 1" and "statistic 2" change correctly. 5/ save the orderline and click on "modify" to make sure that the chosen values got recorded 6/ check the database. go to mysql and try : SELECT sort1, sort2 FROM aqorders WHERE ordernumber='XXX'; 7/ you will have the values you just entered when placing your order. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-10 15:19:22 UTC --- Just a (dumb) question: Patch creates a new script, but where does Koha call it? Couldn't see that just browsing through.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-18 13:08:58 UTC --- Still waiting for an answer on earlier comment. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 --- Comment #12 from Alex Arnaud <alex.arnaud@biblibre.com> 2012-01-18 14:52:48 UTC --- Hi Marcel, This patch RE-creates a script that probably had been deleted by mistake. This script is used by "fetchSortDropbox()" javascript function (in tmpl_dir/prog/en/js/acq.js) which is called by an onchange event on budget_id select in neworderempty.tt. It's an ajax call in order to fill correctly the 'statistic 1' and 'statistic 2' comboboxes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-19 11:29:53 UTC --- Hi ALex, Thanks for responding. Just a few minor points: I see a POD line with only title of the script ;) See a FIXME after template name. See a new commented line for #my $dropbox_values; See a 1; at the end of the script (but this is not a module !!) Could you still adjust ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6753|0 |1 is obsolete| | Attachment #6754|0 |1 is obsolete| | --- Comment #14 from Alex Arnaud <alex.arnaud@biblibre.com> 2012-01-20 09:05:39 UTC --- Created attachment 7253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7253 Replacement patch Marcel, here is the new patch. This is not a follow up but a replacement patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Needs Signoff |Signed Off Severity|critical |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7253|0 |1 is obsolete| | --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-23 08:13:19 UTC --- Created attachment 7289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7289 Signed replacement patch Tested. Comments have been incorporated. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org