[Bug 38988] New: If JobsNotificationMethod is not STOMP the about page shows as if there was a problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 Bug ID: 38988 Summary: If JobsNotificationMethod is not STOMP the about page shows as if there was a problem Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org I'm not sure how bug 35655 ended up doing this, but it is not ok: * If polling is selected, the `text-bg-warning` is picked, and in the STOMP case it is `text-bg-info`. Both are ok so should be displayed the same. * In the `System information` section, you end up with the message about not being able to connect to the message broker. Which is a feature if you chose `polling` so no error at all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com Depends on| |36655 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36655 [Bug 36655] Add ability to requeue a background job from the staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37260 [Bug 37260] Problem with connection to broker not displayed on the about page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 177286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177286&action=edit Bug 38988: Make the polling use case be normal in about page This patch makes choosing `polling` for the `JobsNotificationMethod` system preference not be considered problematic or different than `STOMP`. To test: 1. In `KTD` make sure you have `STOMP` selected 2. Make sure rabbitmq is running: $ ktd --shell k$ sudo -s $ service rabbitmq-server start 3. Go to the about page, 'Server information' => SUCCESS: 'Using RabbitMQ' displayed 4. Stop rabbit $ service rabbitmq-server stop 5. Repeat 3 => SUCCESS: Using Rabbit but fallback to polling 6. Go to the 'System information' tab => SUCCESS: Error message about the broker not functional 7. Choose 'polling' 8. Repeat 3 => FAIL: It says 'Using SQL polling' but in bold face <.< 9. Repeat 6 => FAIL: There's an error about the broker, which we explicitly asked not to use <.< 10. Apply this patch 11. Repeat 3 => SUCCESS: Nothing weird, 'Using SQL polling' displayed. 12. Repeat 6 => SUCCESS: No weird error about the broker. 13. Switch to 'STOMP' => SUCCESS: Behavior is the same with/without rabbit running 14. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177286|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 177307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177307&action=edit Bug 38988: Make the polling use case be normal in about page This patch makes choosing `polling` for the `JobsNotificationMethod` system preference not be considered problematic or different than `STOMP`. To test: 1. In `KTD` make sure you have `STOMP` selected 2. Make sure rabbitmq is running: $ ktd --shell k$ sudo -s $ service rabbitmq-server start 3. Go to the about page, 'Server information' => SUCCESS: 'Using RabbitMQ' displayed 4. Stop rabbit $ service rabbitmq-server stop 5. Repeat 3 => SUCCESS: Using Rabbit but fallback to polling 6. Go to the 'System information' tab => SUCCESS: Error message about the broker not functional 7. Choose 'polling' 8. Repeat 3 => FAIL: It says 'Using SQL polling' but in bold face <.< 9. Repeat 6 => FAIL: There's an error about the broker, which we explicitly asked not to use <.< 10. Apply this patch 11. Repeat 3 => SUCCESS: Nothing weird, 'Using SQL polling' displayed. 12. Repeat 6 => SUCCESS: No weird error about the broker. 13. Switch to 'STOMP' => SUCCESS: Behavior is the same with/without rabbit running 14. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the messages release notes| |displayed in About Koha | |"Server information" and | |"System information" tabs, | |depending on whether the | |RabbitMQ service is running | |and the options for the | |JobsNotificationMethod | |system preference. | |Previously, an error | |message was shown in the | |system information tab when | |the "Polling" option was | |selected and RabbitMQ was | |not running, when it | |shouldn't have. | | | |Expected | |behavour: | |- RabbitMQ | |running: | | . STOMP option: | |message broker shows as | |"Using RabbitMQ", no | |warnings in the system | |information tab | | . Polling | |option: message broker | |shows as "Using SQL | |polling", no warnings in | |the system information tab | |- RabbitMQ not running: | | . | |STOMP option: message | |broker shows as "Using SQL | |polling (Fallback, Error | |connecting to RabbitMQ)", | |error message shown in the | |system information tab | | . | |Polling option: message | |broker shows as "Using SQL | |polling", no warnings in | |the system information tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35655 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177307|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177638&action=edit Bug 38988: Make the polling use case be normal in about page This patch makes choosing `polling` for the `JobsNotificationMethod` system preference not be considered problematic or different than `STOMP`. To test: 1. In `KTD` make sure you have `STOMP` selected 2. Make sure rabbitmq is running: $ ktd --shell k$ sudo -s $ service rabbitmq-server start 3. Go to the about page, 'Server information' => SUCCESS: 'Using RabbitMQ' displayed 4. Stop rabbit $ service rabbitmq-server stop 5. Repeat 3 => SUCCESS: Using Rabbit but fallback to polling 6. Go to the 'System information' tab => SUCCESS: Error message about the broker not functional 7. Choose 'polling' 8. Repeat 3 => FAIL: It says 'Using SQL polling' but in bold face <.< 9. Repeat 6 => FAIL: There's an error about the broker, which we explicitly asked not to use <.< 10. Apply this patch 11. Repeat 3 => SUCCESS: Nothing weird, 'Using SQL polling' displayed. 12. Repeat 6 => SUCCESS: No weird error about the broker. 13. Switch to 'STOMP' => SUCCESS: Behavior is the same with/without rabbit running 14. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38988 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #7 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org