[Bug 38773] New: SMTP server is not showing on the library detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Bug ID: 38773 Summary: SMTP server is not showing on the library detail page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: marion.durand@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When an SMTP server is selected for a library, it is well displayed in the form to modify the library and in the list of all libraries (in column SMTP server) but when viewing a library detail (without editing) the line "SMTP server" is empty. To reproduce : 1- Create an SMTP server in Koha (it doesn't need to be valid) a- Go to Administration > Additional parameters > SMTP servers b- Click on "New STP server" c- Fill all mandatory fields (it doesn't need to be valid information) d- Click on "Submit" 2- Add the created SMTP server to a library a- Go to Administration > Basic parameters > Libraries b- Choose a library and click on Edit (in column "Actions") c- On the line "SMTP server" select the server created d- Click on "Submit" 3- Check the display a- Go to Administration > Basic parameters > Libraries b- Check that the name of the SMTP server you just selected is displayed in the column SMTP server c- Click on the name of the library you modified d- Check that the line "SMTP server" is empty e- Click on "Edit library" f- Check that the name of the SMTP server you just selected is still selected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Bosse <bosse@gustavsson.one> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bosse@gustavsson.one --- Comment #1 from Bosse <bosse@gustavsson.one> --- Hello, The SMTP server isn't displaying because the template variable smtp_server isn't correctly referencing the associated SMTP server object. Should be an easy fix :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177360&action=edit Bug 38773: SMTP server is not showing on the library detail page This patch fixes and incorrect template variable name, making it possible to see a library's SMTP server when viewing the details of an individual library. Test plan copied from the original bug report: 1. Create an SMTP server in Koha (it doesn't need to be valid) a. Go to Administration -> Additional parameters -> SMTP servers b. Click "New STP server" c. Fill all mandatory fields (it doesn't need to be valid information) d. Click "Submit" 2. Add the created SMTP server to a library a. Go to Administration -> Basic parameters -> Libraries b. Choose a library and click on Edit (in column "Actions") c. On the line "SMTP server" select the server created d. Click "Submit" 3. Check the display a. Go to Administration -> Basic parameters -> Libraries b. Check that the name of the SMTP server you just selected is displayed in the column SMTP server c. Click on the name of the library you modified d. Check that the line "SMTP server" shows the correct information. 4. Test with different permissions a. If the logged-in user has both 'manage_libraries' and 'manage_smtp_servers' permissions the SMTP server name should be liked to the edit form for that server. b. If the logged-in user has only 'manage_libraries' permission there should be no link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Bosse <bosse@gustavsson.one> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177360|0 |1 is obsolete| | --- Comment #3 from Bosse <bosse@gustavsson.one> --- Created attachment 177361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177361&action=edit 0001-Bug-38773-SMTP-server-is-not-showing-on-the-library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Bosse, can you please re-attach your signed-off patch? If you are not using git-bz the comand would me something like: git format-patch origin If you are using git-bz, which we recommend, you can do this with: git-bz attach 38773 HEAD^.. the application/mbox format attached cannot be processed by our tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177360|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177361|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Bosse <bosse@gustavsson.one> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177360|0 |1 is obsolete| | --- Comment #5 from Bosse <bosse@gustavsson.one> --- Created attachment 177393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177393&action=edit Bug 38773: SMTP server is not showing on the library detail Sorry, I ran this command according to the wiki: git format-patch -s origin/main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Bosse from comment #5)
Created attachment 177393 [details] Bug 38773: SMTP server is not showing on the library detail
Sorry, I ran this command according to the wiki:
git format-patch -s origin/main
OK, maybe it's in how you attached the patch. We expect a file in .patch format as a result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177393|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Bosse <bosse@gustavsson.one> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177393|0 |1 is obsolete| | --- Comment #7 from Bosse <bosse@gustavsson.one> --- Created attachment 177394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177394&action=edit Bug 38773: SMTP server is not showing on the library detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we now stepped on each others toes, but result looks good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 --- Comment #9 from Bosse <bosse@gustavsson.one> --- Found the error. I wasn't marking it as a "patch" in bugzilla. Sorry and thanks:) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't forge to switch the status to "Signed off" - leaving it to you since the change gets counted for the dashboard :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Bosse <bosse@gustavsson.one> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Bosse <bosse@gustavsson.one> --- Yes, sorry and thanks for the help! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177399&action=edit Bug 38773: SMTP server is not showing on the library detail page This patch fixes and incorrect template variable name, making it possible to see a library's SMTP server when viewing the details of an individual library. Test plan copied from the original bug report: 1. Create an SMTP server in Koha (it doesn't need to be valid) a. Go to Administration -> Additional parameters -> SMTP servers b. Click "New STP server" c. Fill all mandatory fields (it doesn't need to be valid information) d. Click "Submit" 2. Add the created SMTP server to a library a. Go to Administration -> Basic parameters -> Libraries b. Choose a library and click on Edit (in column "Actions") c. On the line "SMTP server" select the server created d. Click "Submit" 3. Check the display a. Go to Administration -> Basic parameters -> Libraries b. Check that the name of the SMTP server you just selected is displayed in the column SMTP server c. Click on the name of the library you modified d. Check that the line "SMTP server" shows the correct information. 4. Test with different permissions a. If the logged-in user has both 'manage_libraries' and 'manage_smtp_servers' permissions the SMTP server name should be liked to the edit form for that server. b. If the logged-in user has only 'manage_libraries' permission there should be no link. Signed-off-by: Bo Gustavsson <bosse@gustavsson.one> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Attachment #177394|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes a bug on release notes| |the branch/library | |administration page where | |SMTP information was not | |correctly displaying. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Bosse from comment #11)
Yes, sorry and thanks for the help!
You are very welcome! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the|This patch fixes a bug on |This fixes the library release notes|the branch/library |detail page (Administration |administration page where |> Libraries > [view a |SMTP information was not |library]) so that the SMTP |correctly displaying. |server information is now | |shown (where it exists). | |Previously, the SMTP server | |was showing in the list of | |libraries, but not on the | |library's individual detail | |page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #17 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org