[Bug 38073] New: Missing use after Bug 25812
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 Bug ID: 38073 Summary: Missing use after Bug 25812 Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 25812 added some code with Koha::XXX objects. They must be added in used modules : use Koha::Account::Lines; use Koha::Items; use Koha::Number::Price; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 [Bug 25812] Fines can be displayed on SIP checkin/checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 172582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172582&action=edit Bug 38073: Add missing use in C4/SIP/ILS.pm Bug 25812 added some code with Koha::XXX objects. They must be added in used modules Test plan : Check SIP server still runs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172582|0 |1 is obsolete| | --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 173083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173083&action=edit Bug 38073: Add missing use in C4/SIP/ILS.pm Bug 25812 added some code with Koha::XXX objects. They must be added in used modules Test plan : Check SIP server still runs Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Test notes: In ktd repo edit docker-compose-light.yml Under services: koha: ports: add port - "6001:6001" In ktd --shell install telnet sudo apt update && sudo apt install telnet Set a patron username and password to test SIP. I used Henry Acevedo username:ace password: 1234Abcd Apply patch and restart_all Connect to SIP server: telnet localhost 6001 Authenticate as SIP user: 9300CNterm1|COterm1|CPCPL| Send patron info request: 6300020060329 201700Y AOCPL|AAace|AD1234Abcd| Confirm response: 64 00020241021 202455000000000000000000000000AOCPL|AA23529000035676|AEHenry Acevedo|BLY|CQY|BHUSD|BV0|CC5|BD4345 Library Rd. Springfield, MA 44224|BF(212) 555-1212|PB19580530|PCS|PIY|AFGreetings from Koha. | I'd be happy to test more is there is a more specific test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173083|0 |1 is obsolete| | --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173920&action=edit Bug 38073: Add missing use in C4/SIP/ILS.pm Bug 25812 added some code with Koha::XXX objects. They must be added in used modules Test plan : Check SIP server still runs Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |me@paulderscheid.xyz |y.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Merge conflicts with 24.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org