[Bug 38283] New: Patron search modal has a button opened by a <button> and closed by a </a>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Bug ID: 38283 Summary: Patron search modal has a button opened by a <button> and closed by a </a> Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: victor@tuxayo.net QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com <button type="button" class="btn btn-default cancel" data-bs-dismiss="modal">Close</a> https://git.koha-community.org/Koha-community/Koha/src/commit/247ab7d1acf087... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This would be good for our hackfest next week. Should it be a or button? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #1)
This would be good for our hackfest next week.
Luckily I remembered!
Should it be a or button? :)
It really doesn't matter from the perspective of style or functionality but <button> is more consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Ewa Gózd <ewa.gozd@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ewa.gozd@gmail.com Assignee|oleonard@myacpl.org |ewa.gozd@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|CONFIRMED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 173966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173966&action=edit Bug 38283: fixed wrong ending tag in patron search modal Fixed mis-matched a/button tags on "Close" button. To test: - Apply patch - In staff interface: Go to acquisitions > suggestions - Create a new suggestion - Click on "Set to patron" - Verify the close button in the modal looks correct and works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173966|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 173967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173967&action=edit Bug 38283: fixed wrong ending tag in patron search modal Fixed mis-matched a/button tags on "Close" button. To test: - Apply patch - In staff interface: Go to acquisitions > suggestions - Create a new suggestion - Click on "Set to patron" - Verify the close button in the modal looks correct and works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173967|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 173968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173968&action=edit Bug 38283: fixed wrong ending tag in patron search modal Fixed mis-matched a/button tags on "Close" button. To test: - Apply patch - In staff interface: Go to acquisitions > suggestions - Create a new suggestion - Click on "Set to patron" - Verify the close button in the modal looks correct and works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Jan Steinberg <jan.steinberg@gesis.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Jan Steinberg <jan.steinberg@gesis.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173968|0 |1 is obsolete| | --- Comment #6 from Jan Steinberg <jan.steinberg@gesis.org> --- Created attachment 173970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173970&action=edit Bug 38283: fixed wrong ending tag in patron search modal Fixed mis-matched a/button tags on "Close" button. To test: - Apply patch - In staff interface: Go to acquisitions > suggestions - Create a new suggestion - Click on "Set to patron" - Verify the close button in the modal looks correct and works Signed-off-by: Jan Steinberg <jan.steinberg@gesis.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173970|0 |1 is obsolete| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174043&action=edit Bug 38283: fixed wrong ending tag in patron search modal Fixed mis-matched a/button tags on "Close" button. To test: - Apply patch - In staff interface: Go to acquisitions > suggestions - Create a new suggestion - Click on "Set to patron" - Verify the close button in the modal looks correct and works Signed-off-by: Jan Steinberg <jan.steinberg@gesis.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38283 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org