[Bug 27889] New: Form fields in OPAC are "out of shape"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 Bug ID: 27889 Summary: Form fields in OPAC are "out of shape" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org There is something weird going on with different input fields in the OPAC. Examples: - OPAC > Advanced search: The search fields are suddenly as wide as the screen. - When OpacAddMastheadLibraryPulldown is active, it is much wider than the longest entry. I noticed these on 20.05.03 - so it would be nice to have a fix for these things with 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Form fields in OPAC are |Form fields in OPAC are |"out of shape" |"out of shape" and pull | |downs in wrong font --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- On 20.11.03 I also see that the pull downs all have a wrong serif font. I cleaned out OpacUserJs and OpacUserCSS for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk --- Comment #3 from Henry Bolshaw <bolshawh@parliament.uk> --- Are you using Firefox? Could the serif font issue be the same issue of bug 27566? I would have guessed that the input fields issue was related to the bootstrap upgrade and the new form-control class but perhaps not if it's appearing in 20.05... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry Henry, just noticed my typo in the first comment. It's 20.11.03 I have confirmed it in and master. bug 27566 could help - I'll try to test, thx for pointing it out! I think the form fields being too long is a different issue tho. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118336&action=edit Bug 27889: Adjust responsive width of OPAC advanced search form This patch tweaks the CSS for the advanced search form in the OPAC so that it adjusts well at various browser widths, including preventing the form from taking up the whole width of the page at higher browser widths. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - In the OPAC, go to the advanced search page. - Test the appearance of the fields in the first "Search for" section, confirming that everything adjusts well at all widths large and small. - Click the "More options" button and test that configuration as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118343&action=edit Bug 27889: (follow-up) Adjust width of OpacAddMastheadLibraryPulldown This patch adds some responsive classes to the OpacAddMastheadLibraryPulldown container so that it will adjust better at various browser widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118336|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 119059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119059&action=edit Bug 27889: Adjust responsive width of OPAC advanced search form This patch tweaks the CSS for the advanced search form in the OPAC so that it adjusts well at various browser widths, including preventing the form from taking up the whole width of the page at higher browser widths. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - In the OPAC, go to the advanced search page. - Test the appearance of the fields in the first "Search for" section, confirming that everything adjusts well at all widths large and small. - Click the "More options" button and test that configuration as well. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118343|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 119060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119060&action=edit Bug 27889: (follow-up) Adjust width of OpacAddMastheadLibraryPulldown This patch adds some responsive classes to the OpacAddMastheadLibraryPulldown container so that it will adjust better at various browser widths. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- The changes worked fine on the latest Firefox on Ubuntu 18.04. One minor thing I noticed was that in the OPAC advanced search with more options, if one of the values (such as Subject and broader terms) is selected, the form doesn't display it in full and it gets cut off. (The drop down list is fine). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- David I'm not sure I understand what you mean. Could you attach a screenshot? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 119085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119085&action=edit Buge 27889 - Screenshots if more options display Hi Owen. Before and after screenshots showing what I tried to explain! After an advanced search option is selected it does not display to the full width of the option text. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119085|Buge 27889 - Screenshots if |Buge 27889 - Screenshots of description|more options display |more options display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Form fields in OPAC are |Form fields in OPAC are |"out of shape" and pull |"out of shape" |downs in wrong font | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Updatingbug descripton - we have taken care of the fonts on bug 27566. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119059|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119152&action=edit Bug 27889: Adjust responsive width of OPAC advanced search form This patch tweaks the CSS for the advanced search form in the OPAC so that it adjusts well at various browser widths, including preventing the form from taking up the whole width of the page at higher browser widths. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - In the OPAC, go to the advanced search page. - Test the appearance of the fields in the first "Search for" section, confirming that everything adjusts well at all widths large and small. - Click the "More options" button and test that configuration as well. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119060|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119153&action=edit Bug 27889: (follow-up) Adjust width of OpacAddMastheadLibraryPulldown This patch adds some responsive classes to the OpacAddMastheadLibraryPulldown container so that it will adjust better at various browser widths. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The length of the input fields looks ok to me on different screen sizes. I could not replicate what David showed in the screenshots. Might need some fine-tuning later, but I believe this is already a fix for the regression. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch tweaks the CSS release notes| |for the advanced search | |form in the OPAC so that it | |adjusts well at various | |browser widths, including | |preventing the form from | |taking up the whole width | |of the page at higher | |browser widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #16)
Pushed to master for 21.05, thanks to everybody involved!
This also appears in 20.11, could it please be backported? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #18)
Pushed to 20.11.x for 20.11.05 Thanks Frido!
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |andrew@bywatersolutions.com --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Issues not present in 20.05, not backported. Please chime in if I'm wrong and this is needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org