[Bug 27926] New: Since bug 15400 date of birth sorting when British English format is applied is broken.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Bug ID: 27926 Summary: Since bug 15400 date of birth sorting when British English format is applied is broken. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 15400 added an include to always output date of birth properly formatted via $KohaDates and with `(age XX)` appended. This has broken the sorting in some tables; for example the patron selection table when searching for a patron for circulation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118118&action=edit Bug 27926: Add 'title-string' for dates on circ-patron-results This patch adds the title string sorting for the data of birth field in the circulation patron results table. This has the side effect of adding a tooltip that displays the date of birth in ISO format, so I'm not entirely sure it's the right approach. Test plan 1/ Set your date format preferences to British English (dd-mm-yyyy) 2/ Do a search that will yield multiple patrons via "Check out" 3/ Try sorting on date of birth and not the order is incorrect. 4/ Apply the patch 5/ Refresh the page and try sorting on date again 6/ The order should now be correct 7/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm not sure about the solution chosen here.. see the caveat in the commit message. We will also need to deal with the same issue on guarantor_search and members_results at least.. maybe more. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118118|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 118124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118124&action=edit Bug 27926: Add 'title-string' for dates on circ-patron-results This patch adds the title string sorting for the data of birth field in the circulation patron results table. This has the side effect of adding a tooltip that displays the date of birth in ISO format, so I'm not entirely sure it's the right approach. Test plan 1/ Set your date format preferences to British English (dd-mm-yyyy) 2/ Do a search that will yield multiple patrons via "Check out" 3/ Try sorting on date of birth and not the order is incorrect. 4/ Apply the patch 5/ Refresh the page and try sorting on date again 6/ The order should now be correct 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 --- Comment #4 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works for me with both DD/MM/YYYY and MM/DD/YYYY formats. Happy to test again once it's ready for sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, Going for pragmatic here.. I'm going to set this one to NSO and leave it as only fixing the circ search case. I'll open another bug for the other patron search results tables.. they're somewhat more complicated being old style ajax tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Sally :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118181&action=edit Bug 27926: (QA follow-up) Switch to using data-order This patch switches away from using the title attribute for ordering and instead uses data-order which is supported in modern DataTables. This has the effect of allowing our ordering to continue to work but without adding the unwanted tooltip on hover. Test plan 1/ Ensure sorting is still working as expected 2/ Hover over any of the date of birth fields and note that you are not longer faced with a tooltip. 3/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27934 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Since bug 15400 date of |Date of birth sorting with |birth sorting when British |British English format is |English format is applied |broken |is broken. | Depends on| |15400 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 [Bug 15400] Display patron age in useful places in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118124|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119159&action=edit Bug 27926: Add 'title-string' for dates on circ-patron-results This patch adds the title string sorting for the data of birth field in the circulation patron results table. This has the side effect of adding a tooltip that displays the date of birth in ISO format, so I'm not entirely sure it's the right approach. Test plan 1/ Set your date format preferences to British English (dd-mm-yyyy) 2/ Do a search that will yield multiple patrons via "Check out" 3/ Try sorting on date of birth and not the order is incorrect. 4/ Apply the patch 5/ Refresh the page and try sorting on date again 6/ The order should now be correct 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118181|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119160&action=edit Bug 27926: (QA follow-up) Switch to using data-order This patch switches away from using the title attribute for ordering and instead uses data-order which is supported in modern DataTables. This has the effect of allowing our ordering to continue to work but without adding the unwanted tooltip on hover. Test plan 1/ Ensure sorting is still working as expected 2/ Hover over any of the date of birth fields and note that you are not longer faced with a tooltip. 3/ Signoff Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.05 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27926 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |andrew@bywatersolutions.com --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependencies, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org