[Bug 8539] New: Library transfer limits page has incorrect permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 Priority: P5 - low Change sponsored?: --- Bug ID: 8539 CC: gmcharlt@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Library transfer limits page has incorrect permission Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: NEW Version: master Component: System Administration Product: Koha Permissions for branch_transfer_limits.pl are defined as "flagsrequired => {borrowers => 1}." This makes the page accessible to any user with permission to add or modify patrons. Based on the other admin scripts, the correct setting appears to be "parameters => 'parameters_remaining_permissions'" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29658&action=edit Bug 8539: Library transfer limits page has incorrect permission Without this patch the library transfer page required the 'borrowers' permission, which is not quite right for a page in the administration module. This patch changes the permission to 'parameters_remaining_permissions' To test: Verify the page is accessbile with: - superlibrarian - administration (full) - administration, remaining permissions (without manage_circ_rules) Verify the page is not accessible without all of those permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29658|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 30645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30645&action=edit [SIGNED OFF] Bug 8539: Library transfer limits page has incorrect permission Without this patch the library transfer page required the 'borrowers' permission, which is not quite right for a page in the administration module. This patch changes the permission to 'parameters_remaining_permissions' To test: Verify the page is accessbile with: - superlibrarian - administration (full) - administration, remaining permissions (without manage_circ_rules) Verify the page is not accessible without all of those permissions. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Nick! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30645|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30859&action=edit [PASSED QA] Bug 8539: Library transfer limits page has incorrect permission Without this patch the library transfer page required the 'borrowers' permission, which is not quite right for a page in the administration module. This patch changes the permission to 'parameters_remaining_permissions' To test: Verify the page is accessbile with: - superlibrarian - administration (full) - administration, remaining permissions (without manage_circ_rules) Verify the page is not accessible without all of those permissions. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.3. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org