http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12325 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12325 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |dcook@prosentient.com.au Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12325 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to M. de Rooy from comment #2)

But do we or even should we support IE8 for the staff client?

I don't see why not. We don't "officially" support any browser. While IE isn't popular amongst developers, it's used out in the real world. While I might be one of the few willing to report and fix bugs that surface for IE users, I don't think that makes the patches any less useful or desirable for the Koha codebase. If I were adding an IE-specific hack, I could understand some reluctance to include it into the codebase. However, in this case, I'm not adding hacks, doing browser detection, or even feature detection (which I think is actually pretty good to do anyway). I'm removing a line of code that probably shouldn't be there regardless of what browser is executing it. I'm also fixing the display of in-line links for all browser, although I suppose I could've done a separate patch for that. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12325 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #4)

I am happy to see IE bugs fixed as I have recently learned that one of our libraires is relying on using it for accessibility reasons. So I think as long as no evil hacks are involved and they go the normal way in, fixing IE bugs is a nice thing to do.

Thanks, Katrin :). Yeah, I refuse to send in patches with IE hacks. In this case, that "return true" shouldn't be there regardless of the browser (although it only plays up in IE). I have another patch for "window.open" issues where IE can't handle spaces in the "name" parameter, but Mozilla recommends not having spaces there anyway. For other cases, feature detection works pretty well for Javascript issues. CSS can get tricky... but CSS is also really easy to localize, so I don't worry too much about that. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12325 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28567|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30764&action=edit [SIGNED-OFF] Bug 12325 - Marc and Card view in Z39.50 Results doesn't work properly in IE 8 This patch removes an unnecessary and problematic "return true" which causes conflicts with Greybox when clicking on "MARC" or "Card" in the search results of a Z39.50 search. The result is that the user is taken to the showmarc.pl page and cannot return to the results, which makes Z39.50 searching pretty much unusable for IE 8 users. This patch also cleans up the "inline links" display for the separate Z39.50 search pages. The 'biblio' version now has inline links for LCCN, and the 'authority' version now prevents inline links for the MARC and Import cells. _TEST PLAN_ 1) Open Internet Explorer 8 (if you don't have IE 8, use whatever Internet Explorer version you do have. You can use F12 developer tools to emulate it.) 2) Go to Cataloguing > New from Z39.50 3) Do a search that will get results (N.B. if you're using IE9+, hit F12 in the pop-up and change to IE 8 mode) 4) Click on "MARC" or "Card". 5) Note that Greybox tries to open a pop-over, but instead follows the link to showmarc.pl. (If you're on IE 8, you can't use "Back" to go back to the search results. If you're using an emulated version, you can.) (If you're testing the inline links, click on the LCCN cell for a biblio search (not that no inline links appear), or MARC and Import cells when doing an authority search (not that inline links do appear). Look at bug 10096 for authority z39.50 server details.) 6) Apply the patch 7) Repeat steps 1-5 8) Note that Greybox now appears correctly when clicking "MARC" and "Card" 9) Note also that inline links now appear for LCCN cell for biblio searches, and inline links no longer appear for MARC and Import cells when doing authority searches. 10) Profit Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30764|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30857&action=edit [PASSED QA] Bug 12325 - Marc and Card view in Z39.50 Results doesn't work properly in IE 8 This patch removes an unnecessary and problematic "return true" which causes conflicts with Greybox when clicking on "MARC" or "Card" in the search results of a Z39.50 search. The result is that the user is taken to the showmarc.pl page and cannot return to the results, which makes Z39.50 searching pretty much unusable for IE 8 users. This patch also cleans up the "inline links" display for the separate Z39.50 search pages. The 'biblio' version now has inline links for LCCN, and the 'authority' version now prevents inline links for the MARC and Import cells. _TEST PLAN_ 1) Open Internet Explorer 8 (if you don't have IE 8, use whatever Internet Explorer version you do have. You can use F12 developer tools to emulate it.) 2) Go to Cataloguing > New from Z39.50 3) Do a search that will get results (N.B. if you're using IE9+, hit F12 in the pop-up and change to IE 8 mode) 4) Click on "MARC" or "Card". 5) Note that Greybox tries to open a pop-over, but instead follows the link to showmarc.pl. (If you're on IE 8, you can't use "Back" to go back to the search results. If you're using an emulated version, you can.) (If you're testing the inline links, click on the LCCN cell for a biblio search (not that no inline links appear), or MARC and Import cells when doing an authority search (not that inline links do appear). Look at bug 10096 for authority z39.50 server details.) 6) Apply the patch 7) Repeat steps 1-5 8) Note that Greybox now appears correctly when clicking "MARC" and "Card" 9) Note also that inline links now appear for LCCN cell for biblio searches, and inline links no longer appear for MARC and Import cells when doing authority searches. 10) Profit Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested for regressions in Firefox and Chromium, no problems found. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.