[Bug 25862] New: TinyMCE editor mangles local url links (relative_urls is true) in tools/koha-new.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Bug ID: 25862 Summary: TinyMCE editor mangles local url links (relative_urls is true) in tools/koha-new.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: didier.gautheron@biblibre.com Reporter: didier.gautheron@biblibre.com QA Contact: testopia@bugs.koha-community.org I don't know if it's an oversight but Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 removed relative_urls : false and now it's impossible to enter a link with a local URL, like a report. cf. https://www.tiny.cloud/docs/configure/url-handling/#document_base_url -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |22661 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- How does this bug manifest? I did a quick test to add a relative url to IntranetMainUserBlock and it seemed to work for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 --- Comment #2 from didier <didier.gautheron@biblibre.com> --- 1 create a report 1 if it doesn't exist 2 open /cgi-bin/koha/tools/koha-news.pl 3 create a news 4 add a HTML link with Insert/Edit link tinyMCE dialog box to /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run%20this%20report "report 1" 5 save 6 on the main page "report 1" link returns a 404 error TinyMCE has replaced /cgi-bin/koha/reports.... with ../reports/guided_reports.pl?reports=1&phase=Run%20this%20report document_base_url isn't set and 'This option specifies the base URL for all relative URLs in the document. The default value is the directory of the current document. If a value is provided, it must specify a directory (not a document) and must end with a /.' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Ah, sorry, you're right. I see it now too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 --- Comment #4 from didier <didier.gautheron@biblibre.com> --- Created attachment 106250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106250&action=edit Bug 25862: TinyMCE editor mangles local url links in tools/koha-new.pl To test: 1 create a report 1 if it doesn't exist 2 open /cgi-bin/koha/tools/koha-news.pl 3 create a news 4 add a HTML link with Insert/Edit link tinyMCE dialog box to /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run%20this%20report "report 1" 5 save 6 on the main page "report 1" link returns a 404 error Apply patch 7 Modify news' URL 8 It works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106250|0 |1 is obsolete| | --- Comment #5 from didier <didier.gautheron@biblibre.com> --- Created attachment 106251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106251&action=edit Bug 25862: TinyMCE editor mangles local url links in tools/koha-new.pl To test: 1 create a report 1 if it doesn't exist 2 open /cgi-bin/koha/tools/koha-news.pl 3 create a news 4 add a HTML link with Insert/Edit link tinyMCE dialog box to /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run%20this%20report "report 1" 5 save 6 on the main page "report 1" link returns a 404 error Apply patch 7 Modify news' URL 8 Test it works in: tools/koha-new.pl admin/branches.pl and admin/preferences.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 106856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106856&action=edit Bug 25862: TinyMCE editor mangles local url links in tools/koha-new.pl To test: 1 create a report 1 if it doesn't exist 2 open /cgi-bin/koha/tools/koha-news.pl 3 create a news 4 add a HTML link with Insert/Edit link tinyMCE dialog box to /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run%20this%20report "report 1" 5 save 6 on the main page "report 1" link returns a 404 error Apply patch 7 Modify news' URL 8 Test it works in: tools/koha-new.pl admin/branches.pl and admin/preferences.pl Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106251|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106856|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106893&action=edit Bug 25862: TinyMCE editor mangles local url links in tools/koha-new.pl To test: 1 create a report 1 if it doesn't exist 2 open /cgi-bin/koha/tools/koha-news.pl 3 create a news 4 add a HTML link with Insert/Edit link tinyMCE dialog box to /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run%20this%20report "report 1" 5 save 6 on the main page "report 1" link returns a 404 error Apply patch 7 Modify news' URL 8 Test it works in: tools/koha-new.pl admin/branches.pl and admin/preferences.pl Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106893|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107085&action=edit Bug 25862: Prevent TinyMCE to mangles local url links To test: 1 create a report 1 if it doesn't exist 2 open /cgi-bin/koha/tools/koha-news.pl 3 create a news 4 add a HTML link with Insert/Edit link tinyMCE dialog box to /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run%20this%20report "report 1" 5 save 6 on the main page "report 1" link returns a 404 error Apply patch 7 Modify news' URL 8 Test it works in: tools/koha-new.pl admin/branches.pl and admin/preferences.pl Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Didier, make sure you write correct commit titles. Usually copy/paste of the bug report title is not a good idea for bugfixes. See https://wiki.koha-community.org/wiki/Commit_messages#Examples -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- To me this bug is not minor as it has some serious implications with more HTML system prefs finding their way into the News feature, which is a good thing! That is also why I will also shamelessly plug Bug 22660 here. If we could use TinyMCE or CodeMirror in the news cool I'd be more comfortable. :) Thanks Didier! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass from comment #11)
To me this bug is not minor as it has some serious implications with more HTML system prefs finding their way into the News feature, which is a good thing!
That's a good point. I actually was bitten recently because post-upgrade the existing HTML got mangled after they did an update. I worked around it, but I imagine many people could have been bitten by this and not known how to work around it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in| |19.11.09 CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org