https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 106360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106360&action=edit Bug 25868 - Screenshots of behavour Hi Fridolin. This change now works as expected. However, if you do two transfers (one after the other for different items) the list of transfers shows: - the last transfer entered, and - the previous transfers show as "No title" and the link doesn't go anywhere See before and after screenshots. David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to David Nind from comment #2)

Created attachment 106360 [details] Bug 25868 - Screenshots of behavour

Hi Fridolin.

This change now works as expected.

However, if you do two transfers (one after the other for different items) the list of transfers shows: - the last transfer entered, and - the previous transfers show as "No title" and the link doesn't go anywhere

See before and after screenshots.

David

Thanks a lot for testing, i'got a fix ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106256|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 106380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106380&action=edit Bug 25868 : Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed <form> tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfert 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106380|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 106385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106385&action=edit Bug 25868 : Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed <form> tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfers 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106529&action=edit Bug 25868: Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed <form> tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfert 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.