[Bug 9432] New: acqui/addorderiso2409.pl is not Plack-friendly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9432 Bug ID: 9432 Summary: acqui/addorderiso2409.pl is not Plack-friendly Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jcamins@cpbibliography.com I get the following error: Can't call method "param" on an undefined value at /home/jcamins/kohaclone/acqui/addorderiso2709.pl line 445. at /home/jcamins/kohaclone/acqui/addorderiso2709.pl line 450 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9432 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9432 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 14722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14722&action=edit Bug 9432: Plack changes for acqui/addorderiso2409.pl Without this patch, after selecting the file I want to add acquisitions from, Plack explodes. With this patch, it works. To test without Plack: 1) Apply patch. 2) Try adding an order item from a staged file. 3) If it works, there are no regressions from the patch. To test with Plack: 1) Try adding an order item from a staged file. It will fail. 2) Apply patch. 3) Try adding an order item from a staged file. 3) If it works, the patch is successful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9432 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14722|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 15080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15080&action=edit Bug 9432: Plack changes for acqui/addorderiso2409.pl Without this patch, after selecting the file I want to add acquisitions from, Plack explodes. With this patch, it works. To test without Plack: 1) Apply patch. 2) Try adding an order item from a staged file. 3) If it works, there are no regressions from the patch. To test with Plack: 1) Try adding an order item from a staged file. It will fail. 2) Apply patch. 3) Try adding an order item from a staged file. 3) If it works, the patch is successful. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Fixes Plack, does not break Apache. Works as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9432 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9432 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jcamins@cpbibliography.com |ity.org | QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Simple patch, works with Plack and Apache. Marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9432 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15080|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15100&action=edit Bug 9432: Plack changes for acqui/addorderiso2409.pl Without this patch, after selecting the file I want to add acquisitions from, Plack explodes. With this patch, it works. To test without Plack: 1) Apply patch. 2) Try adding an order item from a staged file. 3) If it works, there are no regressions from the patch. To test with Plack: 1) Try adding an order item from a staged file. It will fail. 2) Apply patch. 3) Try adding an order item from a staged file. 3) If it works, the patch is successful. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Fixes Plack, does not break Apache. Works as expected. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9432 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9432 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org