[Bug 9421] New: tools/picture-upload.pl not Plack-compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 Bug ID: 9421 Summary: tools/picture-upload.pl not Plack-compatible Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: jcamins@cpbibliography.com I get the following error when I try to upload a patron image: Can't call method "param" on an undefined value at /home/jcamins/kohaclone/tools/picture-upload.pl line 300, <fh00001jcamins_headshot.jpg> line 79. at /home/jcamins/kohaclone/tools/picture-upload.pl line 316 This happens because $template is not available in the subroutines in that file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 14692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14692&action=edit Bug 9421: tools/picture-upload.pl not Plack-compatible This patch avoids using file-level private variables in subroutines by passing the needed variables as parameters to the subroutines. To test (under Plack): 1) Try uploading a patron image without applying the patch. Notice it fails. 2) Apply patch. 3) Try uploading a patron image again, noticing this time it succeeds. To test (under Apache): 1) Apply patch. 2) Try uploading a patron image, confirm that it works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jcamins@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 15079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15079&action=edit Bug 9421: tools/picture-upload.pl not Plack-compatible This patch avoids using file-level private variables in subroutines by passing the needed variables as parameters to the subroutines. To test (under Plack): 1) Try uploading a patron image without applying the patch. Notice it fails. 2) Apply patch. 3) Try uploading a patron image again, noticing this time it succeeds. To test (under Apache): 1) Apply patch. 2) Try uploading a patron image, confirm that it works. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Fixes Plack, does not break Apache. Works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14692|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Works with Plack and Apache. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15079|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15103&action=edit Bug 9421: tools/picture-upload.pl not Plack-compatible This patch avoids using file-level private variables in subroutines by passing the needed variables as parameters to the subroutines. To test (under Plack): 1) Try uploading a patron image without applying the patch. Notice it fails. 2) Apply patch. 3) Try uploading a patron image again, noticing this time it succeeds. To test (under Apache): 1) Apply patch. 2) Try uploading a patron image, confirm that it works. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Fixes Plack, does not break Apache. Works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org