[Bug 39544] New: New > New record generates warnings in log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Bug ID: 39544 Summary: New > New record generates warnings in log Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: januszop@gmail.com Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When creating a new record starting from Normal records view, by using New > New record warnings in the log will be generated like: [2025/04/03 12:45:33] [WARN] Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 513. etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 180504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180504&action=edit Bug 39544: New > New record generates warnings in log When creating a new record starting from Normal records view, by using New > New record warnings in the log will be generated like: [2025/04/03 12:45:33] [WARN] Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 513. Test plan: ========== 1. In staff interface, open any record in Normal view. 2. From upper menu chose New > New record. 3. Check the plack-intranet-error.log file, you should see fresh warnings with "Use of uninitialized value $frameworkcode". 4. Apply the patch ; restart_all. 5. Repeat p. 1.-3. No new warnings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180504|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 180525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180525&action=edit Bug 39544: New > New record generates warnings in log When creating a new record starting from Normal records view, by using New > New record warnings in the log will be generated like: [2025/04/03 12:45:33] [WARN] Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 513. Test plan: ========== 1. In staff interface, open any record in Normal view. 2. From upper menu chose New > New record. 3. Check the plack-intranet-error.log file, you should see fresh warnings with "Use of uninitialized value $frameworkcode". 4. Apply the patch ; restart_all. 5. Repeat p. 1.-3. No new warnings. Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180525|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 180528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180528&action=edit Bug 39544: New > New record generates warnings in log When creating a new record starting from Normal records view, by using New > New record warnings in the log will be generated like: [2025/04/03 12:45:33] [WARN] Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 513. Test plan: ========== 1. In staff interface, open any record in Normal view. 2. From upper menu chose New > New record. 3. Check the plack-intranet-error.log file, you should see fresh warnings with "Use of uninitialized value $frameworkcode". 4. Apply the patch ; restart_all. 5. Repeat p. 1.-3. No new warnings. Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180528|0 |1 is obsolete| | --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 180566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180566&action=edit Bug 39544: New > New record generates warnings in log When creating a new record starting from Normal records view, by using New > New record warnings in the log will be generated like: [2025/04/03 12:45:33] [WARN] Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 513. Test plan: ========== 1. In staff interface, open any record in Normal view. 2. From upper menu chose New > New record. 3. Check the plack-intranet-error.log file, you should see fresh warnings with "Use of uninitialized value $frameworkcode". 4. Apply the patch ; restart_all. 5. Repeat p. 1.-3. No new warnings. Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@openfifth.c |y.org |o.uk CC| |matt.blenkinsop@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|New > New record generates |New / New record generates |warnings in log |warnings in log -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- +$frameworkcode //= ''; We usually prefer q{} for empty string. You can see it for example : $op = $input->param('op') // q{}; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org