[Bug 39108] New: Clicking the Ignore button on hold found modal for already-waiting hold does not dismiss the modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Bug ID: 39108 Summary: Clicking the Ignore button on hold found modal for already-waiting hold does not dismiss the modal Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1 - place a hold 2 - check in an item that can fill the hold 3 - in the hold found modal, click Ignore 4 - the modal dismisses and nothing changes on the hold (this is the desired behavior) 5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 6 - check in the item again, confirm the modal says "Item is already waiting" 7 - click Ignore, confirm modal reloads 8 - click Ignore, confirm modal reloads 9 - click Ignore, confirm modal reloads -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- That said, if one clicks "Confirm" the modal goes away without sending a new notice of changing the state of the hold. That makes the Ignore button a little redundant. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 178484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178484&action=edit Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal When ignoring a waiting hold, we don't need to take any further action, we shoudlsimply close the modal This patch adds JS to prevent form submission To test: 1 - place a hold 2 - check in an item that can fill the hold 3 - in the hold found modal, click Ignore 4 - the modal dismisses and nothing changes on the hold (this is the desired behavior) 5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 6 - check in the item again, confirm the modal says "Item is already waiting" 7 - click Ignore, confirm modal reloads 8 - click Ignore, confirm modal reloads 9 - click Ignore, confirm modal reloads 10 - Apply patch 11 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 12 - check in the item again, confirm the modal says "Item is already waiting" 13 - click Ignore, nothign happens! Orange you glad I didn't say banana? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178484|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178609&action=edit Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal When ignoring a waiting hold, we don't need to take any further action, we shoudlsimply close the modal This patch adds JS to prevent form submission To test: 1 - place a hold 2 - check in an item that can fill the hold 3 - in the hold found modal, click Ignore 4 - the modal dismisses and nothing changes on the hold (this is the desired behavior) 5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 6 - check in the item again, confirm the modal says "Item is already waiting" 7 - click Ignore, confirm modal reloads 8 - click Ignore, confirm modal reloads 9 - click Ignore, confirm modal reloads 10 - Apply patch 11 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 12 - check in the item again, confirm the modal says "Item is already waiting" 13 - click Ignore, nothign happens! Orange you glad I didn't say banana? Signed-off-by: Amanda Campbell <acampbell@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178609|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178693&action=edit Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal When ignoring a waiting hold, we don't need to take any further action, we shoudlsimply close the modal This patch adds JS to prevent form submission To test: 1 - place a hold 2 - check in an item that can fill the hold 3 - in the hold found modal, click Ignore 4 - the modal dismisses and nothing changes on the hold (this is the desired behavior) 5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 6 - check in the item again, confirm the modal says "Item is already waiting" 7 - click Ignore, confirm modal reloads 8 - click Ignore, confirm modal reloads 9 - click Ignore, confirm modal reloads 10 - Apply patch 11 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 12 - check in the item again, confirm the modal says "Item is already waiting" 13 - click Ignore, nothign happens! Orange you glad I didn't say banana? Signed-off-by: Amanda Campbell <acampbell@hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Clicking the Ignore button |Clicking the 'Ignore' |on hold found modal for |button on hold found modal |already-waiting hold does |for already-waiting hold |not dismiss the modal |does not dismiss the modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41345 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org