[Bug 34169] New: Add pattern check for monetary fields to acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Bug ID: 34169 Summary: Add pattern check for monetary fields to acquisition module Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: michaela.sieber@kit.edu In the patron module we validate the input fields for monetary values using a pattern check (see https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC2:_Input_type_.22n...), but we don't do the same in acq. Especially for countries that use decimal comma this can lead to problems. At the moment Koha only accepts decimal point and a wrongly entered value might get turned from 1,00 to 100 or similar easily. Until we can fix the input formats properly, we should extend the pattern check to fields in the acq module I think. Also: We can use the pattern check later to identify any fields that needs work for different input formats. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34231 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This could be a quick fix while we work on 34231. Joubu suggested using a CSS class and adding the pattern check with jQuery in the global .js file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tried to write a POC using jQuery starting with the normal acq order form: $("#acq_neworderempty #unitprice").attr({inputmode: "decimal", pattern: "^\d+(\.\d{2})?$" }); It didn't work there, because we use the validate JS plugin. But we could maybe use that to our advantage. With Joubu's help: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt index 42f537a5924..7f0be4c0af2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt @@ -669,7 +669,7 @@ </li> <li class="ordering_unitprice"> <label for="unitprice">Actual cost: </label> - <input type="text" id="unitprice" size="20" name="unitprice" value="[% unitprice | html %]" /> + <input type="text" id="unitprice" size="20" name="unitprice" value="[% unitprice | html %]" class="price" /> [% IF (invoiceincgst == 1) %](tax inc.)[% ELSE %](tax exc.)[% END %] </li> <li> diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js index 74af1ad89ae..aeab2be8667 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js +++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ -110,6 +110,9 @@ $(document).ready(function() { $(".validated").each(function() { $(this).validate(); }); + jQuery.validator.addClassRules("price", { + number: true + }); $("#logout").on("click",function(){ logOut(); * It allows to add negative and positive amounts with decimal dot. This is OK as we do need the ability to add negatives in acquisitions. * It does allow entering thousand separators with a ., but Koha hates it and won't save the value: check_budget_total.pl: XML Parsing Error: syntax error Location: http://localhost:8081/cgi-bin/koha/acqui/check_budget_total.pl?budget_id=2&total=21.60 Line Number 1, Column 1: -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add pattern check for |Add validation for monetary |monetary fields to |input fields in acquisition |acquisition module |module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153568&action=edit Bug 34169: Use jQuery validator plugin to validate amounts This is a first step towards more consistency and possibly supporting multiple input formats as well in the future. It allows us to mark all input fields for monetary values, such as prices, replacement prices, fees etc. with a class that is linked to a check for the 'number' format in the jQuery Validator plugin. This is the base patch that does nothing by itself, please see test plan in second patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153569&action=edit Bug 34169: Add decimal class to all relevant input fields in the acquisitions module This is a first step towards more consistency and possibly supporting multiple input formats as well in the future. It marks all input fields for monetary values, such as prices, replacement prices etc. with a class that is linked to a check for number format with the jQuery Validator plugin. To test: For any input field to test, try adding various false entries, like "abc" or "1,00". It should only accept inputs with decimal dot, like: "1.00" 0) Apply patch, restart_all 1) Suggestion * Add a new suggestion in the staff interface * Test: price input field at the bottom of the form. * Accept the suggestion 2) Order form * Create a new basket * Create an order line from an existing record * Test: list price, replacement price, and actual price. * Check the checkbox for uncertain price before you save 3) Uncertain prices * Go to the uncertain prices page for this vendor * Test: price field Note: this form does its own validation, but the change should not change behaviour for now * Resolve the uncertain price * Close order 4) Receive shipment * Test: Shipping cost 5) Receive the order * Test: replacement price, actual price * Check checkbox for price in foreign currency * Test: price in foreign currency * Receive order line 6) Invoice summary * Finish receiving * Test: shipping cost * Test: invoice adjustments: amount in the form for the first entry, amount in the table after adding it 7) Merging invoices * Receive another shipment and create and invoice * Go to invoices and search all * Check the 2 entries for merging * Test: shipping cost 8) Adding orders from a staged/new file * Export some records using the cart or list * Create a new basket * Order from new file * Import your file, ignore item records * Test: price and replacement price + Bonus: also test with items, test plan and file from bug 22802 are really helpful here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153568|0 |1 is obsolete| | --- Comment #5 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 153577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153577&action=edit Bug 34169: Use jQuery validator plugin to validate amounts This is a first step towards more consistency and possibly supporting multiple input formats as well in the future. It allows us to mark all input fields for monetary values, such as prices, replacement prices, fees etc. with a class that is linked to a check for the 'number' format in the jQuery Validator plugin. This is the base patch that does nothing by itself, please see test plan in second patch. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153569|0 |1 is obsolete| | --- Comment #6 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 153578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153578&action=edit Bug 34169: Add decimal class to all relevant input fields in the acquisitions module This is a first step towards more consistency and possibly supporting multiple input formats as well in the future. It marks all input fields for monetary values, such as prices, replacement prices etc. with a class that is linked to a check for number format with the jQuery Validator plugin. To test: For any input field to test, try adding various false entries, like "abc" or "1,00". It should only accept inputs with decimal dot, like: "1.00" 0) Apply patch, restart_all 1) Suggestion * Add a new suggestion in the staff interface * Test: price input field at the bottom of the form. * Accept the suggestion 2) Order form * Create a new basket * Create an order line from an existing record * Test: list price, replacement price, and actual price. * Check the checkbox for uncertain price before you save 3) Uncertain prices * Go to the uncertain prices page for this vendor * Test: price field Note: this form does its own validation, but the change should not change behaviour for now * Resolve the uncertain price * Close order 4) Receive shipment * Test: Shipping cost 5) Receive the order * Test: replacement price, actual price * Check checkbox for price in foreign currency * Test: price in foreign currency * Receive order line 6) Invoice summary * Finish receiving * Test: shipping cost * Test: invoice adjustments: amount in the form for the first entry, amount in the table after adding it 7) Merging invoices * Receive another shipment and create and invoice * Go to invoices and search all * Check the 2 entries for merging * Test: shipping cost 8) Adding orders from a staged/new file * Export some records using the cart or list * Create a new basket * Order from new file * Import your file, ignore item records * Test: price and replacement price + Bonus: also test with items, test plan and file from bug 22802 are really helpful here Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Michaela Sieber <michaela.sieber@kit.edu> --- Could please someone check 8) Adding orders from a staged/new file I tested it in http://staff-pricevalid.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/acqui/baske... but the prices are not stored, the price is always 0.00 I'm not sure if I did everything correctly. Perhaps this is a separate bug and has nothing to do with the validation. 1) - 7) Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Michaela Sieber from comment #7)
Could please someone check
8) Adding orders from a staged/new file
I tested it in http://staff-pricevalid.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/acqui/ basket.pl?basketno=4
but the prices are not stored, the price is always 0.00
I'm not sure if I did everything correctly.
Perhaps this is a separate bug and has nothing to do with the validation.
1) - 7) Signed Off
Hi Michaela, could it have been: Bug 18914 - 'Add order' links from staged file order information isn't carried over It happens when you use the order link to add a single order line insted of using the checkboxes and the button at the bottom. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think there is something wrong still with the multi-select. If I pick more than one, only the price of the first is carried over into the order. I'll have a look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153580&action=edit Bug 34169: (follow-up) Fix ordering from staged files by removing superfluous form Removes the unneded new form element as we have one big form for the whole page. This should fix the situation where only the prices and information of the first selected record carreid over into the order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153577|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153581&action=edit Bug 34169: Use jQuery validator plugin to validate amounts This is a first step towards more consistency and possibly supporting multiple input formats as well in the future. It allows us to mark all input fields for monetary values, such as prices, replacement prices, fees etc. with a class that is linked to a check for the 'number' format in the jQuery Validator plugin. This is the base patch that does nothing by itself, please see test plan in second patch. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153578|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153582&action=edit Bug 34169: Add decimal class to all relevant input fields in the acquisitions module This is a first step towards more consistency and possibly supporting multiple input formats as well in the future. It marks all input fields for monetary values, such as prices, replacement prices etc. with a class that is linked to a check for number format with the jQuery Validator plugin. To test: For any input field to test, try adding various false entries, like "abc" or "1,00". It should only accept inputs with decimal dot, like: "1.00" 0) Apply patch, restart_all 1) Suggestion * Add a new suggestion in the staff interface * Test: price input field at the bottom of the form. * Accept the suggestion 2) Order form * Create a new basket * Create an order line from an existing record * Test: list price, replacement price, and actual price. * Check the checkbox for uncertain price before you save 3) Uncertain prices * Go to the uncertain prices page for this vendor * Test: price field Note: this form does its own validation, but the change should not change behaviour for now * Resolve the uncertain price * Close order 4) Receive shipment * Test: Shipping cost 5) Receive the order * Test: replacement price, actual price * Check checkbox for price in foreign currency * Test: price in foreign currency * Receive order line 6) Invoice summary * Finish receiving * Test: shipping cost * Test: invoice adjustments: amount in the form for the first entry, amount in the table after adding it 7) Merging invoices * Receive another shipment and create and invoice * Go to invoices and search all * Check the 2 entries for merging * Test: shipping cost 8) Adding orders from a staged/new file * Export some records using the cart or list * Create a new basket * Order from new file * Import your file, ignore item records * Test: price and replacement price + Bonus: also test with items, test plan and file from bug 22802 are really helpful here Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153580|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153583&action=edit Bug 34169: (follow-up) Fix ordering from staged files by removing superfluous form Removes the unneded new form element as we have one big form for the whole page. This should fix the situation where only the prices and information of the first selected record carreid over into the order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I found an fixed it for the checkboxes/multi-select. Bug 18914 is not fixed by it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153581|0 |1 is obsolete| | Attachment #153582|0 |1 is obsolete| | Attachment #153583|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 153801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153801&action=edit Bug 34169: Use jQuery validator plugin to validate amounts This is a first step towards more consistency and possibly supporting multiple input formats as well in the future. It allows us to mark all input fields for monetary values, such as prices, replacement prices, fees etc. with a class that is linked to a check for the 'number' format in the jQuery Validator plugin. This is the base patch that does nothing by itself, please see test plan in second patch. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 153802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153802&action=edit Bug 34169: Add decimal class to all relevant input fields in the acquisitions module This is a first step towards more consistency and possibly supporting multiple input formats as well in the future. It marks all input fields for monetary values, such as prices, replacement prices etc. with a class that is linked to a check for number format with the jQuery Validator plugin. To test: For any input field to test, try adding various false entries, like "abc" or "1,00". It should only accept inputs with decimal dot, like: "1.00" 0) Apply patch, restart_all 1) Suggestion * Add a new suggestion in the staff interface * Test: price input field at the bottom of the form. * Accept the suggestion 2) Order form * Create a new basket * Create an order line from an existing record * Test: list price, replacement price, and actual price. * Check the checkbox for uncertain price before you save 3) Uncertain prices * Go to the uncertain prices page for this vendor * Test: price field Note: this form does its own validation, but the change should not change behaviour for now * Resolve the uncertain price * Close order 4) Receive shipment * Test: Shipping cost 5) Receive the order * Test: replacement price, actual price * Check checkbox for price in foreign currency * Test: price in foreign currency * Receive order line 6) Invoice summary * Finish receiving * Test: shipping cost * Test: invoice adjustments: amount in the form for the first entry, amount in the table after adding it 7) Merging invoices * Receive another shipment and create and invoice * Go to invoices and search all * Check the 2 entries for merging * Test: shipping cost 8) Adding orders from a staged/new file * Export some records using the cart or list * Create a new basket * Order from new file * Import your file, ignore item records * Test: price and replacement price + Bonus: also test with items, test plan and file from bug 22802 are really helpful here Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 153803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153803&action=edit Bug 34169: (follow-up) Fix ordering from staged files by removing superfluous form Removes the unneded new form element as we have one big form for the whole page. This should fix the situation where only the prices and information of the first selected record carreid over into the order. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- There are places where you end up with NaN when you enter invalid format, but you cannot submit and this seems a large improvement, passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #20 from Michaela Sieber <michaela.sieber@kit.edu> --- Thank you! Is backporting for 23.05.x possible ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Long lasting bug I gladly backport. Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Missing dependencies for 22.11.x. Not pushing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |At the moment Koha only release notes| |accepts and calculates with | |amounts that are formatted | |with a decimal comma, but | |inputs were not always | |validated which could lead | |to calculation errors and | |wrong amounts. Now entered | |amounts are validated | |before saving. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|At the moment Koha only |At the moment Koha only release notes|accepts and calculates with |accepts and calculates with |amounts that are formatted |amounts that are formatted |with a decimal comma, but |with a decimal comma, but |inputs were not always |inputs were not always |validated which could lead |validated which could lead |to calculation errors and |to calculation errors and |wrong amounts. Now entered |wrong amounts. Now entered |amounts are validated |amounts are validated |before saving. |before saving. | | | |**Sponsored | |by** The Research | |University in the Helmholtz | |Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|At the moment Koha only |At the moment Koha can only release notes|accepts and calculates with |calculate with amounts that |amounts that are formatted |are formatted with a |with a decimal comma, but |decimal comma, but inputs |inputs were not always |were not always validated |validated which could lead |which could lead to errors |to calculation errors and |and wrong amounts. Now |wrong amounts. Now entered |entered amounts are |amounts are validated |validated before saving |before saving. |throughout the acquisitions | |module. |**Sponsored | |by** The Research |**Sponsored by** |University in the Helmholtz |*The Research University in |Association (KIT) |the Helmholtz Association | |(KIT)* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892 [Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org