[Bug 34938] New: Add collection column to holds ratio report (circ/reserveratios.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Bug ID: 34938 Summary: Add collection column to holds ratio report (circ/reserveratios.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com It would be helpful if the holds ratio report had a column displaying collection. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 156305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156305&action=edit Bug 34938: Add collection column to hold ratio report To test: 1. Create enough holds on items so that they will appear on the holds ratio report. 2. Visit circ/reserveratios.pl by going to Circulation > Holds ratios 3. No collection column. 4. Apply patch and restart services 5. Look again at circ/reserveratios.pl, now you should see a collection column. 6. Ensure that the data in the column looks correct. 7. Go to Administration > Table settings to ensure you can hide that column, and other columns in the table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- If testing on KTD you'll likely need to make sure you turn strict_sql_modes off in the koha-conf because it doesn't like GROUP BY. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #3 from Kristi <kkrueger@cuyahogalibrary.org> --- Created attachment 156308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156308&action=edit HoldsRatio_Screenshot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 --- Comment #4 from Kristi <kkrueger@cuyahogalibrary.org> --- In testing, when I go to Circulation > Holds ratios, I get the errors in the attached screenshot. If this is user error on my part, please let me know how I can adjust. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Hi, NOt sure you did anything strictly wrong here - Lucas points out that the testing docker (which the sandboxes use) needs to have a very specific setting disabled, and I'm not sure - but will check! - that the sandboxes allow turning that setting off, which would make it challenging to test this bug there. We'll see if there is a way we can allow this kind of bug to be tested in the sandboxes. Cheers, Liz (In reply to Kristi from comment #4)
In testing, when I go to Circulation > Holds ratios, I get the errors in the attached screenshot. If this is user error on my part, please let me know how I can adjust.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Kristi from comment #4)
In testing, when I go to Circulation > Holds ratios, I get the errors in the attached screenshot. If this is user error on my part, please let me know how I can adjust.
Kristi, this is the thing I mention here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938#c2 KTD and the sandboxes are set by default with SQL strict mode enabled. Since the code in reserveratios.pl contains several GROUP BY's it fails with strict mode on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156305|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 156462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156462&action=edit Bug 34938: Add collection column to hold ratio report To test: 1. Create enough holds on items so that they will appear on the holds ratio report. 2. Visit circ/reserveratios.pl by going to Circulation > Holds ratios 3. No collection column. 4. Apply patch and restart services 5. Look again at circ/reserveratios.pl, now you should see a collection column. 6. Ensure that the data in the column looks correct. 7. Go to Administration > Table settings to ensure you can hide that column, and other columns in the table. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156462|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158347&action=edit Bug 34938: Add collection column to hold ratio report To test: 1. Create enough holds on items so that they will appear on the holds ratio report. 2. Visit circ/reserveratios.pl by going to Circulation > Holds ratios 3. No collection column. 4. Apply patch and restart services 5. Look again at circ/reserveratios.pl, now you should see a collection column. 6. Ensure that the data in the column looks correct. 7. Go to Administration > Table settings to ensure you can hide that column, and other columns in the table. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158348&action=edit Bug 34938: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.06 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/824 Documentation| |Lucy Vaux-Harvey contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 --- Comment #12 from Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> --- New screenshot added -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Lucy Vaux-Harvey from comment #12)
New screenshot added
Lucy, see comment #2: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938#c2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 --- Comment #14 from Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> --- (In reply to Lucas Gass from comment #13)
(In reply to Lucy Vaux-Harvey from comment #12)
New screenshot added
Lucy, see comment #2:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938#c2
Thanks Lucas, all worked fine for producing a new screenshot for the manual - https://koha-community.org/manual/latest/en/html/circulation.html#hold-ratio... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org