[Bug 37686] New: render_resource_not_found() and render_resource_deleted() misses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Bug ID: 37686 Summary: render_resource_not_found() and render_resource_deleted() misses Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com Some bugs pushed later, and some misses, made bug 36495 incomplete. I filed bug 37672 when dealing with record sources, but there are more. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |36495, 24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 [Bug 36495] Add render_resource_not_found() and render_resource_deleted() helpers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 170498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170498&action=edit Bug 37686: Fix render_resource_not_found() and render_resource_deleted() misses This patch refactors some small pieces of code to use the helpers as prescribed on our coding guidelines [1] instead of manually crafting responses. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ => SUCCESS: All tests pass 3. Sign off :-D [1] https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#REST4:_Controll... Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37672 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170498|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 170541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170541&action=edit Bug 37686: Fix render_resource_not_found() and render_resource_deleted() misses This patch refactors some small pieces of code to use the helpers as prescribed on our coding guidelines [1] instead of manually crafting responses. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ => SUCCESS: All tests pass 3. Sign off :-D [1] https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#REST4:_Controll... Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170541|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 170553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170553&action=edit Bug 37686: Fix render_resource_not_found() and render_resource_deleted() misses This patch refactors some small pieces of code to use the helpers as prescribed on our coding guidelines [1] instead of manually crafting responses. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ => SUCCESS: All tests pass 3. Sign off :-D [1] https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#REST4:_Controll... Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What is it missing? (please update bug description :) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really wish you all would stop sneaking Biblio back in: https://wiki.koha-community.org/wiki/Terminology#B git grep "Biblio not found" Koha/REST/V1/Holds.pm: openapi => "Biblio not found." api/v1/swagger/paths/biblios.yaml: description: Biblio not found api/v1/swagger/paths/biblios.yaml: description: Biblio not found api/v1/swagger/paths/biblios.yaml: description: Biblio not found api/v1/swagger/paths/biblios.yaml: description: Biblio not found api/v1/swagger/paths/biblios.yaml: description: Biblio not found api/v1/swagger/paths/biblios.yaml: description: Biblio not found api/v1/swagger/paths/biblios.yaml: description: Biblio not found api/v1/swagger/paths/biblios.yaml: description: Biblio not found api/v1/swagger/paths/biblios.yaml: description: Biblio not found api/v1/swagger/paths/biblios.yaml: description: Biblio not found api/v1/swagger/paths/biblios.yaml: description: Biblio not found api/v1/swagger/paths/biblios_merge.yaml: description: Biblio not found api/v1/swagger/paths/deleted_biblios.yaml: description: Biblio not found api/v1/swagger/paths/deleted_biblios.yaml: description: Biblio not found api/v1/swagger/paths/holds.yaml: description: Biblio not found api/v1/swagger/paths/items.yaml: description: Biblio not found misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl: $debug and warn '[ERROR] Biblio not found.'; misc/maintenance/process_record_through_filter.pl: print "Biblio not found\n"; t/db_dependent/api/v1/deleted_biblios.t: ->json_is( '/error', 'Biblio not found' ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #5)
I really wish you all would stop sneaking Biblio back in: https://wiki.koha-community.org/wiki/Terminology#B
git grep "Biblio not found"
Maybe that query is too broad heh. Happy to provide a follow-up tomorrow morning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You only added one of these, I pondered fixing it.. then got discouraged by the number of occurences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actually you would need to fix: + return $c->render_resource_not_found("Biblio"); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 [Bug 37791] Fix terminology 'Biblio not found' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #9)
Actually you would need to fix: + return $c->render_resource_not_found("Biblio");
I've actually filed bug 37791. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This development finished release notes| |the code cleanup we | |implemented on bug 36495, | |by performing the same code | |changes in new code that | |was added in between and | |some misses too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org