[Bug 37515] New: Add common class to all places where an item type image is shown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 Bug ID: 37515 Summary: Add common class to all places where an item type image is shown Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Related to Bug 35189, it would be useful to put a common class on all <img> tags showing item type images. This would allow libraries to consistently apply custom styles. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169863&action=edit Bug 37515: Add common class to all places where an item type image is shown This patch adds an "itemtype-image" class to templates in all places where we show itemtype images. This patch affects both the OPAC and the staff client. To test you should have icons associated with multiple item types. - Apply the patch and go to Administration -> System preferences - Search for "itemtype" - noItemTypeImages should be set to "Show" - OpacNoItemTypeImages should be set to "Show" - BiblioItemtypeInfo should be set to "Show" - Search for "usercss" - Add an obvious style rule for item type images to IntranetUserCSS and OPACUserCSS, e.g. .itemtype-image { border: 3px solid orange; } - In the staff interface, check the following pages to confirm that your custom style is visible: - Administration -> Item types -> Edit - Administration -> Authorized values -> CCODE -> Edit a CCODE - Advanced search - Search results - Bibliographic details - Place hold - Lists -> List contents view (must set the item-level_itypes preference to "bibliographic record") - In the OPAC: - Advanced search - Search results - Bibliographic details - Place hold - Log in as a user with checkouts -> - View the checkouts tab on the patron summary page - Lists -> List contents view (must set the item-level_itypes preference to "bibliographic record") Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35189 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169863|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169878&action=edit Bug 37515: Add common class to all places where an item type image is shown This patch adds an "itemtype-image" class to templates in all places where we show itemtype images. This patch affects both the OPAC and the staff client. To test you should have icons associated with multiple item types. - Apply the patch and go to Administration -> System preferences - Search for "itemtype" - noItemTypeImages should be set to "Show" - OpacNoItemTypeImages should be set to "Show" - BiblioItemtypeInfo should be set to "Show" - Search for "usercss" - Add an obvious style rule for item type images to IntranetUserCSS and OPACUserCSS, e.g. .itemtype-image { border: 3px solid orange; } - In the staff interface, check the following pages to confirm that your custom style is visible: - Administration -> Item types -> Edit - Administration -> Authorized values -> CCODE -> Edit a CCODE - Advanced search - Search results - Bibliographic details - Place hold - Lists -> List contents view (must set the item-level_itypes preference to "bibliographic record") - In the OPAC: - Advanced search - Search results - Bibliographic details - Place hold - Log in as a user with checkouts -> - View the checkouts tab on the patron summary page - Lists -> List contents view (must set the item-level_itypes preference to "bibliographic record") Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA'd by RM. Minor rebase in results.tt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the markup which is used to | |show item type images in | |both the OPAC and staff | |interface. The change adds | |a common class attribute, | |"itemtype-image", so that | |the display of these images | |can be changed with custom | |CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37515 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org